Re: [DISCUSS] Why add unit tests for hudi-cli module

2020-05-12 Thread hddong
This is mainly a function test, not a parameter test. Also, ensure that all base commands are executed successfully.

Re: [DISCUSS] Why add unit tests for hudi-cli module

2020-05-12 Thread Vinoth Chandar
+1 People rely on CLI to operate on Hudi datasets. So having some tests there, would definitely be useful On Tue, May 12, 2020 at 12:39 PM Shiyan Xu wrote: > Hi, the tests in hudi-cli are more of functional tests. They are conducive > to verifying features in cli module are working. Though not

Re: [DISCUSS] Why add unit tests for hudi-cli module

2020-05-12 Thread Shiyan Xu
Hi, the tests in hudi-cli are more of functional tests. They are conducive to verifying features in cli module are working. Though not covering all options, it is always better to have some assuring passing tests than none, isn't it? :) On Tue, May 12, 2020 at 8:31 AM hmantu wrote: > hi all, >

[DISCUSS] Why add unit tests for hudi-cli module

2020-05-12 Thread hmantu
hi all, I can not understand why add so many tests for hudi-cli module? We know that each command has many options, unit tests can not cover all of these options, and each module has thier own unit tests, so I think they are redundant, any thoughs? Thanks