Re: Reverting commit

2021-02-28 Thread Peter Vary
Thanks Ryan, Went for the option to create the quick fix and push it: - Pre-Commit tests are green - Only a single test is broken on non-UTC test runs - The fix is simple - straightforward Here is the fix (https://github.com/apache/iceberg/pull/2283 )

Re: Reverting commit

2021-02-27 Thread Ryan Blue
If you think a commit broke something, then I think it's always okay to revert it if needed. I also think it's okay to push a fix for it if you have one and then make sure it's reviewed by other committers as soon as you can. When in doubt, I'd probably go for the option to revert but it depends on