+1 on defining it clearly in the spec. Note the “spec doc” is the spec
itself, which requires more accurate description than doc. We may also need
spec test to check whether compute engine conforms to spec, not the other
way around.
Yufei Gu 于2024年4月17日 周三01:08写道：
> For me, (b) is the right behav
For me, (b) is the right behavior, we may just be clearer in the spec doc,
but open for suggestions in case I missed something.
Yufei
On Mon, Apr 15, 2024 at 11:02 PM Renjie Liu wrote:
> Hi, Wing:
>
> I totally agree that we should clearly define the expected behavior in
> spec. I lean towards
Hi, Wing:
I totally agree that we should clearly define the expected behavior in
spec. I lean towards a), e.g. the row should be completed ignored or
completed same as original row, intermediate state should be defined as
invalid.
On Tue, Apr 16, 2024 at 8:40 AM Wing Yew Poon
wrote:
> Hi Yufei,
Hi Yufei,
Thank you for your response.
It sounds like on 2, your thinking is that (b) is the correct behavior.
Indeed, I have tried it out with Spark and afaict, it does (b). However,
that does not mean that it is the correct behavior. The spec should clearly
define it.
- Wing Yew
On Mon, Apr 15,
Hi Renjie,
Thank you for your perspective.
On 1, I am inclined to the same view as you.
On 2, I feel that the spec should clearly define the expected behavior; it
should not be left to engines. At worst, the spec can say, e.g., that the
correct behavior is (b) but it is acceptable for an engine to
Hi Wing Yew Poon,
Here is my understanding, but not necessarily how an engine implements it.
It should only consider the columns in equality_ids when we apply eq
deletes. Also the engine should ignore the unrelated columns.
It will still delete the row with id 3 in the following case you described
Hi, Wing:
1. Are the options either (a) write only the column(s) listed in equality_ids
or (b) write all the columns? i.e, no in between.
Yes, I think so.
2. If we write all the columns, are only columns listed in equality_ids
considered? What happens if a non-equality_id column does not matc
