Re: Apache Ignite 2.0 Release

2017-04-11 Thread Dmitriy Setrakyan
Awesome! Great addition to the project. On Tue, Apr 11, 2017 at 8:27 PM, Denis Magda wrote: > Spring Data integration caught up the train and will be released in 2.0: > https://issues.apache.org/jira/browse/IGNITE-1192 < > https://issues.apache.org/jira/browse/IGNITE-1192> >

Re: Move documentation from readme.io to GitHub pages

2017-04-11 Thread Dmitriy Setrakyan
Pavel, We all agree that the documentation should be in our GIT repo in either Markdown or AsciiDoc format. However, it is a very big undertaking to migrate it from readme and properly structure it. If anyone in the community would volunteer, would be great. D. On Tue, Apr 11, 2017 at 9:36 PM,

Re: CREATE TABLE SQL command syntax

2017-04-11 Thread Dmitriy Setrakyan
Agree, the updated syntax looks better. One change though: KEY -> PRIMARY KEY. Sergi, what do you think? D. On Tue, Apr 11, 2017 at 9:50 PM, Pavel Tupitsyn wrote: > I think "WITH" syntax is ugly and cumbersome. > > We should go with this one: > CREATE TABLE Person (id

Re: CREATE TABLE SQL command syntax

2017-04-11 Thread Pavel Tupitsyn
I think "WITH" syntax is ugly and cumbersome. We should go with this one: CREATE TABLE Person (id int AFFINITY KEY, uid uuid KEY, firstName varchar, lastName varchar) All databases (i.e. [1], [2]) work this way, I see no reason to invent something different and confuse the users. [1]

Re: Move documentation from readme.io to GitHub pages

2017-04-11 Thread Pavel Tupitsyn
> Git approach is no way to go for us because all the documentation has to be hosted on ASF side Well, our Git repository [1] is hosted by ASF, isn't it? GitHub pages just generates HTML from MarkDown via Jekyll [2] static site generator. I understand the concern about GitHub pages, though. And

Re: IGNITE-1192 Implementation (Integration with Spring Data)

2017-04-11 Thread Denis Magda
Folks, good news, The integration has been just merged into the master branch and will be released in Apache Ignite 2.0. Eduard, thanks for tremendous work done by you especially on the side of query generator module! In general, I’ve just polished your pull request, added more tests and

Re: CREATE TABLE SQL command syntax

2017-04-11 Thread Alexander Paschenko
Dmitry, For H2 it would be something like this - please note all those quotes, commas and equality signs that would be mandatory: CREATE TABLE Person (id int, uid uuid, firstName varchar, lastName varchar) WITH "keyFields=id,uuid","affinityKey=id" With suggested approach, it would be something

Re: CREATE TABLE SQL command syntax

2017-04-11 Thread Dmitriy Setrakyan
Alexeander, Can you please provide an example of what the CREATE TABLE command would look like if we use WITH syntax from H2 vs. what you are proposing? D. On Tue, Apr 11, 2017 at 6:35 PM, Alexander Paschenko < alexander.a.pasche...@gmail.com> wrote: > Hello Igniters, > > Yup, it's THAT time

CREATE TABLE SQL command syntax

2017-04-11 Thread Alexander Paschenko
Hello Igniters, Yup, it's THAT time once again as we haven't ultimately settled on anything with the subj. as of yet, but I believe that now with DDL on its way this talk can't be avoided anymore (sorry guys). The last time we talked about Ignite specific stuff we need to have in CREATE TABLE

Re: Sorting fields of Binarilyzable objects on write

2017-04-11 Thread Dmitriy Setrakyan
On Tue, Apr 11, 2017 at 1:28 PM, Sergi Vladykin wrote: > I'm just trying to understand the current state of things and risks. May be > we need to do some adjustments here before 2.0 to be on the safe side. > > Actually looks like this not really important, we just have

Re: IGNITE-2741 - spring session design

2017-04-11 Thread Rishi Yagnik
Hi Val, I will build it from master s and let you know by tomorrow. Thanks, On Tue, Apr 11, 2017 at 3:53 PM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Hi Rishi, > > What was the issue with the HttpSessionCsrfTokenRepository? I didn't have > any problems after I added code

Changes in web session clustering

2017-04-11 Thread Valentin Kulichenko
Hi Saikat, I recall you made a lot of changes in web session clustering component. I was working on [1] and found piece of code in WebSessionFilter#doFilterV2 that was supposed to handle the case of changed session ID. It was actually never called because of the issue. I removed it and replaced

Re: IGNITE-2741 - spring session design

2017-04-11 Thread Valentin Kulichenko
Hi Rishi, What was the issue with the HttpSessionCsrfTokenRepository? I didn't have any problems after I added code you provided. The fix for [1] is already in master. Can you try building from there and check if everything works fine for you? [1]

[jira] [Created] (IGNITE-4948) Web session clustering fails to work with Spring Security

2017-04-11 Thread Valentin Kulichenko (JIRA)
Valentin Kulichenko created IGNITE-4948: --- Summary: Web session clustering fails to work with Spring Security Key: IGNITE-4948 URL: https://issues.apache.org/jira/browse/IGNITE-4948 Project:

Re: Sorting fields of Binarilyzable objects on write

2017-04-11 Thread Sergi Vladykin
I'm just trying to understand the current state of things and risks. May be we need to do some adjustments here before 2.0 to be on the safe side. Actually looks like this not really important, we just have to clearly document that DML builds keys this way and require from user to do the same to

Re: IGNITE-1794 is ready for review

2017-04-11 Thread Вадим Опольский
Denis, yes, I mean issue https://issues.apache.org/jira/browse/IGNITE-1794 Yes I added some fixes in addition to previous changes. This fixes repeat the Semyon's fixes. Vadim 2017-04-11 19:55 GMT+03:00 Denis Magda : > Vadim, > > Do you mean this task? > >

Re: IGNITE-1794 is ready for review

2017-04-11 Thread Вадим Опольский
Hi Semyon! I've seen all fixes abut hibernate5 in ignite-3477-master. Will you finish this issue? Vadim Opolski 2017-04-11 19:54 GMT+03:00 Semyon Boikov : > Hi Vadim, > > I already fixed all issues with hibernate5 tests and merged in > ignite-3477-master, it will be

Re: Stable binary key representation

2017-04-11 Thread Denis Magda
I don’t see either unless a key’s field is of a float type. However, it sounds like an artificial use case. Thanks for the details. — Denis > On Apr 11, 2017, at 11:50 AM, Dmitriy Setrakyan wrote: > > Denis, I think it is important that we know which specific field to

Re: Stable binary key representation

2017-04-11 Thread Dmitriy Setrakyan
Denis, I think it is important that we know which specific field to use for the affinity resolution, but I don't see any issue in using both, primary and foreign keys, for hashcode and equality. Do you? D. On Tue, Apr 11, 2017 at 11:46 AM, Igor Sapego wrote: > Denis, > >

Re: Sorting fields of Binarilyzable objects on write

2017-04-11 Thread Dmitriy Setrakyan
Sergi, why do you not like the alphabetical order? Seems like it would be a much easier to understand requirement from the user standpoint. Do you see some issues here? On Mon, Apr 10, 2017 at 10:43 AM, Sergi Vladykin wrote: > I'm sorry, looks like I do not really well

Re: Stable binary key representation

2017-04-11 Thread Igor Sapego
Denis, The whole binary representation of the object is used now for hash code generation and equality comparison. So the answer - all fields are used for this. Best Regards, Igor On Mon, Apr 10, 2017 at 9:50 PM, Denis Magda wrote: > Considering this simple example > >

Re: AffinityKeyMapper: break compatibility before 2.0

2017-04-11 Thread Dmitriy Setrakyan
OK, let's drop it. But we should provide clear instructions in the 2.0 migration guide about this change. On Tue, Apr 11, 2017 at 1:33 AM, Sergi Vladykin wrote: > +1 to Vladimir. > > Sergi > > 2017-04-11 10:48 GMT+03:00 Vladimir Ozerov : > > >

[GitHub] ignite pull request #1776: Ignite 4587 review

2017-04-11 Thread agura
GitHub user agura opened a pull request: https://github.com/apache/ignite/pull/1776 Ignite 4587 review You can merge this pull request into a Git repository by running: $ git pull https://github.com/agura/incubator-ignite ignite-4587-review Alternatively you can review and

Re: IGNITE-1794 is ready for review

2017-04-11 Thread Denis Magda
Vadim, Do you mean this task? > https://issues.apache.org/jira/browse/IGNITE-1794 > As I see Semen has already promised to review it and merge into the master by the end of the week. Did you add anything else in addition to previous changes?

Re: IGNITE-1794 is ready for review

2017-04-11 Thread Semyon Boikov
Hi Vadim, I already fixed all issues with hibernate5 tests and merged in ignite-3477-master, it will be merged in master soon. Thanks On Tue, Apr 11, 2017 at 7:51 PM, Вадим Опольский wrote: > Hello guys! > > I added folder hibernate5 as module to project settings and

Re: transaction , waiting for prepare response

2017-04-11 Thread Andrey Gura
Aleksey, timer like you are mentioned exists - it is transaction timeout. On Tue, Apr 11, 2017 at 3:25 PM, ALEKSEY KUZNETSOV wrote: > Igniters! If we started transaction, and in phase prepare the primary node > doesnt receive GridDhtPrepareResponse then the transaction

Re: IGNITE-1794 is ready for review

2017-04-11 Thread Вадим Опольский
Hello guys! I added folder hibernate5 as module to project settings and discovered some errors. Fixed errors in pull request - https://github.com/vopolski/ignite/pull/1/files But some tests from hibernate5 is failed. I'll fix them. How much time do I have? Vadim Opolski 2017-04-06 13:04

[jira] [Created] (IGNITE-4947) Create AI 2.0 TC suites

2017-04-11 Thread Alexander Paschenko (JIRA)
Alexander Paschenko created IGNITE-4947: --- Summary: Create AI 2.0 TC suites Key: IGNITE-4947 URL: https://issues.apache.org/jira/browse/IGNITE-4947 Project: Ignite Issue Type: Task

[GitHub] ignite pull request #1775: Ignite 4938

2017-04-11 Thread alexpaschenko
GitHub user alexpaschenko opened a pull request: https://github.com/apache/ignite/pull/1775 Ignite 4938 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4938 Alternatively you can review and apply

Re: Move documentation from readme.io to GitHub pages

2017-04-11 Thread Denis Magda
Pavel, I totally agree that it’s becoming more and more inconvenient to run the documentation on readme.io . At the same time the Git approach is no way to go for us because all the documentation has to be hosted on ASF side. Presently we violate this policy and I look

Re: TouchedExpiryPolicy works incorrect in some cases IGNITE-4401

2017-04-11 Thread Denis Magda
Hello, Do you have sample code? — Denis > On Apr 11, 2017, at 2:45 AM, ALEKSEY KUZNETSOV > wrote: > > Hi, igniters! > While doing https://issues.apache.org/jira/browse/IGNITE-4401 ticket i came > across the fact that cache querying returns null , while cache still

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-04-11 Thread Denis Magda
Yasha, I’ve updated the javadoc for IgniteConfiguration.metricsUpdateFrequency and merged the changes into your branch (see JIRA). The rest is fine for now. An advance documentation on how the heartbeats are implemented can be done in readme.io . — Denis > On Apr 11, 2017,

Re: IgniteSemaphore and failoverSafe flag

2017-04-11 Thread Dmitry Karachentsev
Hi Vladislav, Thanks for your contribution! But it seems doesn't fix related tickets, in particular [1]. Could you please take a look? [1] https://issues.apache.org/jira/browse/IGNITE-4173 Thanks! 06.04.2017 16:27, Vladisav Jelisavcic пишет: Hey Dmitry, sorry for the late reply, I'll try

[GitHub] ignite pull request #1774: IGNITE-4946

2017-04-11 Thread gvvinblade
GitHub user gvvinblade opened a pull request: https://github.com/apache/ignite/pull/1774 IGNITE-4946 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4946 Alternatively you can review and apply

[jira] [Created] (IGNITE-4946) GridCacheP2PUndeploySelfTest became failed

2017-04-11 Thread Igor Seliverstov (JIRA)
Igor Seliverstov created IGNITE-4946: Summary: GridCacheP2PUndeploySelfTest became failed Key: IGNITE-4946 URL: https://issues.apache.org/jira/browse/IGNITE-4946 Project: Ignite Issue

transaction , waiting for prepare response

2017-04-11 Thread ALEKSEY KUZNETSOV
Igniters! If we started transaction, and in phase prepare the primary node doesnt receive GridDhtPrepareResponse then the transaction got stuck for a long time. Why don't we have got timer that causes rollback if transaction time on waiting has expired ? -- *Best Regards,* *Kuznetsov Aleksey*

[GitHub] ignite pull request #1726: IGNITE-3583: Replaced passing by value with passi...

2017-04-11 Thread isapego
Github user isapego closed the pull request at: https://github.com/apache/ignite/pull/1726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #1663: IGNITE-3575: CPP: Implemented remote filters for ...

2017-04-11 Thread isapego
Github user isapego closed the pull request at: https://github.com/apache/ignite/pull/1663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #1724: IGNITE-3582 CPP: Replaced pointers with reference...

2017-04-11 Thread isapego
Github user isapego closed the pull request at: https://github.com/apache/ignite/pull/1724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (IGNITE-4945) Web console: Redesign filter controls for tables.

2017-04-11 Thread Andrey Novikov (JIRA)
Andrey Novikov created IGNITE-4945: -- Summary: Web console: Redesign filter controls for tables. Key: IGNITE-4945 URL: https://issues.apache.org/jira/browse/IGNITE-4945 Project: Ignite Issue

[jira] [Created] (IGNITE-4944) Web Console Highlight hovered line in table

2017-04-11 Thread Andrey Novikov (JIRA)
Andrey Novikov created IGNITE-4944: -- Summary: Web Console Highlight hovered line in table Key: IGNITE-4944 URL: https://issues.apache.org/jira/browse/IGNITE-4944 Project: Ignite Issue Type:

CachePojoStore data loading with binary marshaller

2017-04-11 Thread Dmitriy Govorukhin
Hi all, I found problem related to CacheJdbcPojoStore. If try to load data, with enabled binary marshaller, error may occur. Problem in entryMappings (this map helps resolve stored type when data loading). If binary marshaller disable we just put entry with java type in this map, if enable we

Re: Move documentation from readme.io to GitHub pages

2017-04-11 Thread Igor Sapego
Pavel, I totally agree with you, but what about documentations for different versions? How do you suppose to solve this problem with GitHub pages? On Tue, Apr 11, 2017 at 12:02 PM, Pavel Tupitsyn wrote: > Igniters, > > Currently we host documentation on >

TouchedExpiryPolicy works incorrect in some cases IGNITE-4401

2017-04-11 Thread ALEKSEY KUZNETSOV
Hi, igniters! While doing https://issues.apache.org/jira/browse/IGNITE-4401 ticket i came across the fact that cache querying returns null , while cache still has got entry. Cache query : SELECT nameProp FROM EDUProp WHERE EDUId = 1 Cache get operation : ignite().cache("eduPropCache").get(new

[GitHub] ignite pull request #1773: IGNITE-4565

2017-04-11 Thread devozerov
GitHub user devozerov opened a pull request: https://github.com/apache/ignite/pull/1773 IGNITE-4565 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4565 Alternatively you can review and apply these

[jira] [Created] (IGNITE-4943) Web Console: Improve design of tables with grouping on Admin Panel Screen

2017-04-11 Thread Andrey Novikov (JIRA)
Andrey Novikov created IGNITE-4943: -- Summary: Web Console: Improve design of tables with grouping on Admin Panel Screen Key: IGNITE-4943 URL: https://issues.apache.org/jira/browse/IGNITE-4943

[jira] [Created] (IGNITE-4942) Remove old JdbcQueryTask

2017-04-11 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-4942: --- Summary: Remove old JdbcQueryTask Key: IGNITE-4942 URL: https://issues.apache.org/jira/browse/IGNITE-4942 Project: Ignite Issue Type: Task

[jira] [Created] (IGNITE-4941) Remove GridDhtPartitionSupplyMessage

2017-04-11 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-4941: --- Summary: Remove GridDhtPartitionSupplyMessage Key: IGNITE-4941 URL: https://issues.apache.org/jira/browse/IGNITE-4941 Project: Ignite Issue Type: Task

Move documentation from readme.io to GitHub pages

2017-04-11 Thread Pavel Tupitsyn
Igniters, Currently we host documentation on apacheignite.readme.io (and also apacheignite-net.readme.io, apacheignite-cpp.readme.io, apacheignite-mix.readme.io, etc). readme.io has a lot of problems mostly due to lack of proper version control: * Each "version" is just a copy. When fixing

Re: Prohibit stateful affinity (FairAffinityFunction)

2017-04-11 Thread Yakov Zhdanov
Guys, after some thoughts I would say that even distribution is more important for affinity function than traffic on rebalancing (which should be kept to minimum also). Even distribution gives even load on stable topology, while rebalancing is somet disaster. Apparently, grids should spend more

Re: AffinityKeyMapper: break compatibility before 2.0

2017-04-11 Thread Sergi Vladykin
+1 to Vladimir. Sergi 2017-04-11 10:48 GMT+03:00 Vladimir Ozerov : > Dima, > > The whole idea of AffinityKeyMapper appears to be wrong since we will have > only BinaryMarshaller. We do not have classes on server, how can we rely on > interface this class extends? I think

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-04-11 Thread Yakov Zhdanov
Messages renaming is never compatible =) Denis, did you try to update javadocs? --Yakov 2017-04-10 21:41 GMT+03:00 Denis Magda : > Yasha, > > Thanks, I’ve replied you in the ticket. > > In a nutshel, let’s try to merge current breaking changes to 2.0 and do > the rest of

Re: one point optimisation

2017-04-11 Thread ALEKSEY KUZNETSOV
Hi! Your talking about node ordering? What is the point of the ordering? How is it implemented? Thanks for the answering in advance! ср, 5 апр. 2017 г. в 15:14, Alexey Goncharuk : > This optimization does not work when near cache is enabled because we need > the same

Re: AffinityKeyMapper: break compatibility before 2.0

2017-04-11 Thread Vladimir Ozerov
Dima, The whole idea of AffinityKeyMapper appears to be wrong since we will have only BinaryMarshaller. We do not have classes on server, how can we rely on interface this class extends? I think we should do the following: 1) Allow @AffinityKeyMapped annotation on fields only (it doesn't work on

Re: AffinityKeyMapper: break compatibility before 2.0

2017-04-11 Thread Dmitriy Setrakyan
I agree that this interface is problematic. However, I don't think that dropping it right away would be fair to our users. Can we deprecate it and print out a warning that AffinityKeyMapper cannot be used with DDL statements? D. On Tue, Apr 11, 2017 at 12:32 AM, Sergi Vladykin

AffinityKeyMapper: break compatibility before 2.0

2017-04-11 Thread Sergi Vladykin
Guys, We are moving in direction of better distributed SQL support, it means that we always will need to know an affinity field name for key type. Now we have AffinityKeyMapper which hides it from us. Since we have other means of configuring the affinity key, e.g CacheKeyConfiguration and

[jira] [Created] (IGNITE-4940) GridCacheWriteBehindStore lose more data then necessary

2017-04-11 Thread Alexander Belyak (JIRA)
Alexander Belyak created IGNITE-4940: Summary: GridCacheWriteBehindStore lose more data then necessary Key: IGNITE-4940 URL: https://issues.apache.org/jira/browse/IGNITE-4940 Project: Ignite