Re: Request for review : IGNITE-3303 Apache Flink Integration - Flink source

2018-09-08 Thread Saikat Maitra
Hi Andrew, Alexey I have incorporated the review changes. I have also refactored the CacheEventSerializer class and moved it to test folder because it is used only in the FlinkIgniteSourceSelfExample and not required for IgniteSource. Build links

Re: Critical worker threads liveness checking drawbacks

2018-09-08 Thread Andrey Kuznetsov
David, Yakov, I understand your fears. But liveness checks deal with _critical_ conditions, i.e. when such a condition is met we conclude the node as totally broken, and there is no sense to keep it alive regardless the data it contains. If we want to give it a chance, then the condition (long

Re: Critical worker threads liveness checking drawbacks

2018-09-08 Thread Yakov Zhdanov
Agree with David. We need to have an opporunity set backups count threshold (at runtime also!) that will not allow any automatic stop if there will be a data loss. Andrey, what do you think? --Yakov