Re: New Monitoring System: items to complete before GA

2020-04-24 Thread Denis Magda
Nikolay, thanks for a detailed response. (I've created a handful of tickets linking to IEP-35 with the label named similarly. I didn't assign any tickets on you letting you decide what you'd like to take over personally) With filter user can exclude arbitrary registry from arbitrary exporter. > E

[jira] [Created] (IGNITE-12946) Add description to MBeans

2020-04-24 Thread Denis A. Magda (Jira)
Denis A. Magda created IGNITE-12946: --- Summary: Add description to MBeans Key: IGNITE-12946 URL: https://issues.apache.org/jira/browse/IGNITE-12946 Project: Ignite Issue Type: Improvement

[jira] [Created] (IGNITE-12945) Put Ignite MBeans under a proper path

2020-04-24 Thread Denis A. Magda (Jira)
Denis A. Magda created IGNITE-12945: --- Summary: Put Ignite MBeans under a proper path Key: IGNITE-12945 URL: https://issues.apache.org/jira/browse/IGNITE-12945 Project: Ignite Issue Type: Ta

[jira] [Created] (IGNITE-12944) Remove additional parameters required for collection of some metrics

2020-04-24 Thread Denis A. Magda (Jira)
Denis A. Magda created IGNITE-12944: --- Summary: Remove additional parameters required for collection of some metrics Key: IGNITE-12944 URL: https://issues.apache.org/jira/browse/IGNITE-12944 Project:

Re: [DISCUSSION] `static final` code-style constant naming rules

2020-04-24 Thread Ivan Pavlukhin
Maxim, Thank you for efforts in a code quality improvement! Unfortunately I do not agree with the proposal. Usually I like to refer a following guide [1]. While a question "what is a constant" is not trivial but I suppose that every static final field capitalization can cause some problems. For e

[jira] [Created] (IGNITE-12943) Document how to filter out metrics from registries

2020-04-24 Thread Denis A. Magda (Jira)
Denis A. Magda created IGNITE-12943: --- Summary: Document how to filter out metrics from registries Key: IGNITE-12943 URL: https://issues.apache.org/jira/browse/IGNITE-12943 Project: Ignite I

Re: [DISCUSSION] Major changes in Ignite in 2020

2020-04-24 Thread Denis Magda
Dmitry, highlighted such a disclaimer in italic. Thanks. - Denis On Thu, Apr 23, 2020 at 3:53 AM Dmitriy Pavlov wrote: > Hi Denis, > > Thank you for driving this. > > Igniters, > > I would suggest to stress that Apache Ignite community does not guarantee > these features to be available. > > C

[jira] [Created] (IGNITE-12942) control.sh add command for checking that inline size is same on all cluster nodes

2020-04-24 Thread Sergey Antonov (Jira)
Sergey Antonov created IGNITE-12942: --- Summary: control.sh add command for checking that inline size is same on all cluster nodes Key: IGNITE-12942 URL: https://issues.apache.org/jira/browse/IGNITE-12942

[jira] [Created] (IGNITE-12941) .NET: Support .NET 5

2020-04-24 Thread Pavel Tupitsyn (Jira)
Pavel Tupitsyn created IGNITE-12941: --- Summary: .NET: Support .NET 5 Key: IGNITE-12941 URL: https://issues.apache.org/jira/browse/IGNITE-12941 Project: Ignite Issue Type: New Feature

Re: [DISCUSSION] `static final` code-style constant naming rules

2020-04-24 Thread Pavel Tupitsyn
> All static final object reference types that are never followed by "." (dot) With this way of thinking we can say that everything is a constant if we don't change it - no need for static final. "Constant" is usually something that you can't change, even you want - compiler won't let you. In Java

[jira] [Created] (IGNITE-12940) .NET: NuGet tests fail with compilation error

2020-04-24 Thread Pavel Tupitsyn (Jira)
Pavel Tupitsyn created IGNITE-12940: --- Summary: .NET: NuGet tests fail with compilation error Key: IGNITE-12940 URL: https://issues.apache.org/jira/browse/IGNITE-12940 Project: Ignite Issue

[jira] [Created] (IGNITE-12939) Add WhitespaceAround support checkstyle rule

2020-04-24 Thread Maxim Muzafarov (Jira)
Maxim Muzafarov created IGNITE-12939: Summary: Add WhitespaceAround support checkstyle rule Key: IGNITE-12939 URL: https://issues.apache.org/jira/browse/IGNITE-12939 Project: Ignite Issue

Re: Tool for performance statistics reports

2020-04-24 Thread Denis Magda
> > Tracing is more deeply takes statistics. If it will be possible, I'm for > reuse. Looks like we need to sync up on these activities/initiatives to ensure we don't do a duplicate job. If you think a separate discussion is necessary let's kick it off. - Denis On Fri, Apr 24, 2020 at 9:18 AM

[jira] [Created] (IGNITE-12938) controls.sh utility commands: IdleVerify and ValidateIndexes use eventual payload check.

2020-04-24 Thread Stanilovsky Evgeny (Jira)
Stanilovsky Evgeny created IGNITE-12938: --- Summary: controls.sh utility commands: IdleVerify and ValidateIndexes use eventual payload check. Key: IGNITE-12938 URL: https://issues.apache.org/jira/browse/IGNITE

Re: [DISCUSSION] `static final` code-style constant naming rules

2020-04-24 Thread Pavel Pereslegin
Maxim, > But what exactly is `constant` means?! I'd suggest applying this rule > to all class fields with `static final` modifiers without any clauses. > (check Java Naming convention [2] paragraph 3.3). I disagree with this and want to clarify what exactly the Java naming convention says: >> Th

Re: [DISCUSSION] `static final` code-style constant naming rules

2020-04-24 Thread Sergey Antonov
Maxim, It's a good idea! Please don't forget to update out code style guidelines too. Thank you for keeping the code cleaner! пт, 24 апр. 2020 г. в 19:49, Maxim Muzafarov : > Igniters, > > > It is not directly mentioned through the Apache Ignite Coding > Guidelines [1] about naming the `static

[DISCUSSION] `static final` code-style constant naming rules

2020-04-24 Thread Maxim Muzafarov
Igniters, It is not directly mentioned through the Apache Ignite Coding Guidelines [1] about naming the `static final` class fields using only upper-case letters. I'd like to suggest to fill this gap. > Constants should all be upper-case. But what exactly is `constant` means?! I'd suggest applyi

[jira] [Created] (IGNITE-12937) Create pull-request template for the github repo

2020-04-24 Thread Maxim Muzafarov (Jira)
Maxim Muzafarov created IGNITE-12937: Summary: Create pull-request template for the github repo Key: IGNITE-12937 URL: https://issues.apache.org/jira/browse/IGNITE-12937 Project: Ignite I

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Denis, Ilya, I will try to integrate profiling functionality into control.sh utility. > Speaking of the probes/statistics collection approach, is it supposed to > reuse tracing capabilities that are to be added as part of IEP-35? Tracing is more deeply takes statistics. If it will be possible, I'

Re: Tool for performance statistics reports

2020-04-24 Thread Ilya Kasnacheev
Hello! I suggest that it's one of the places where it could be put instead of adding a new tool. Regards, -- Ilya Kasnacheev пт, 24 апр. 2020 г. в 18:56, Nikita Amelchev : > Ilya, > > You suggest using control.sh to build the report? > > пт, 24 апр. 2020 г. в 18:20, Ilya Kasnacheev : > > > >

Re: Tool for performance statistics reports

2020-04-24 Thread Denis Magda
Nikita, Thanks for preparing the IEP and breaking the initiative down into pieces. I studied the IEP and it feels like the goal is to built a tool similar to Oracle AWR. If it's so then shouldn't we add this as an extra function to either visorcmd or control.sh. Hopefully, we can start moving in t

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Ilya, You suggest using control.sh to build the report? пт, 24 апр. 2020 г. в 18:20, Ilya Kasnacheev : > > Hello! > > You need to throw in control.sh also, which does some kind of statistics > too, such as idle_verify. > > Regards, > -- > Ilya Kasnacheev > > > пт, 24 апр. 2020 г. в 18:06, Вячесла

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Slava, The web-console is used to interactive configuration wizard, management and monitoring tool [1]. I want to implement a profiling tool. It's one of the monitoring parts and helps to answer the question: What will be running slow? See IEP-35 [2]. [1] https://apacheignite-tools.readme.io/doc

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Maxim, > Can you provide more information about the binary logging format? I started to investigate. It should be with minimal effect on performance. I haven't any details for now. > What the additional log category are you talking about? PoC is based on logging performance statistics to the "pro

Re: Tool for performance statistics reports

2020-04-24 Thread Ilya Kasnacheev
Hello! You need to throw in control.sh also, which does some kind of statistics too, such as idle_verify. Regards, -- Ilya Kasnacheev пт, 24 апр. 2020 г. в 18:06, Вячеслав Коптилин : > Hello Nikita, > > Perhaps, I am missing something... > Apache Ignite already has a web-console tool. Do we w

Re: Tool for performance statistics reports

2020-04-24 Thread Вячеслав Коптилин
Hello Nikita, Perhaps, I am missing something... Apache Ignite already has a web-console tool. Do we want to improve the existing tool instead of creating a new one? It seems to me, this can be confusing for users. - visor (which is deprecated) - web-console (to be honest, I don't quite understa

Re: Tool for performance statistics reports

2020-04-24 Thread Maxim Muzafarov
Hello, Nikita Nice to have such a tool in Apache Ignite. Can you provide more information about the binary logging format? Do you have any examples? Is there are any problems you faced? >The Ignite will log some additional internal statistics using separate log >category of IgniteLogger. What t

[jira] [Created] (IGNITE-12936) .NET inspections fail on master

2020-04-24 Thread Igor Sapego (Jira)
Igor Sapego created IGNITE-12936: Summary: .NET inspections fail on master Key: IGNITE-12936 URL: https://issues.apache.org/jira/browse/IGNITE-12936 Project: Ignite Issue Type: Bug

Re: [DISCUSSION] Hot cache backup

2020-04-24 Thread Maxim Muzafarov
Alexey, I've addressed all your comments, please, take a look at the PR [1]. Additional tests were added. Additional comments with further steps were added. [1] https://github.com/apache/ignite/pull/7607 [2] https://issues.apache.org/jira/browse/IGNITE-11073 On Tue, 21 Apr 2020 at 09:53, Alexe

Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Hi, Igniters. I'm working on cluster profiling and the tool for creating a performance report. [1] I have prepared PoC based on performance logging to a separate category of Ignite log. The report contains: - Cache operations and its distribution by types [2] - Transactions and histogram of durat

Re: [MTCGA]: new failures in builds [5251854, 5251851] needs to be handled

2020-04-24 Thread Pavel Tupitsyn
This is correct. I've talked to Igor earlier today and he is working on it. On Fri, Apr 24, 2020 at 1:40 PM Dmitriy Pavlov wrote: > My best guess it is related to IGNITE-12853 > : Introduced features > for the thin client protocol > > Build de

Re: [MTCGA]: new failures in builds [5251854, 5251851] needs to be handled

2020-04-24 Thread Dmitriy Pavlov
My best guess it is related to IGNITE-12853 : Introduced features for the thin client protocol Build details https://ci.ignite.apache.org/viewLog.html?buildId=5254068&tab=Inspection&buildTypeId=IgniteTests24Java8_PlatformNetInspections says th

[jira] [Created] (IGNITE-12935) Disadvantages in log of historical rebalance

2020-04-24 Thread Vladislav Pyatkov (Jira)
Vladislav Pyatkov created IGNITE-12935: -- Summary: Disadvantages in log of historical rebalance Key: IGNITE-12935 URL: https://issues.apache.org/jira/browse/IGNITE-12935 Project: Ignite I