Re: IGNITE-12997 Rename pub-sub module to pub-sub-ext

2020-05-10 Thread Saikat Maitra
Hi Denis, Thank you for reviewing the PR. I have merged the changes. Regards, Saikat On Sun, May 10, 2020 at 2:50 AM Denis Magda wrote: > Hi Saikat, please go ahead and merge the changes. > > > - > Denis > > > On Sat, May 9, 2020 at 2:25 PM Saikat Maitra > wrote: > > > Hi, > > > > I have rai

Re: [DISCUSSION] ASF Board Report Draft, May 2020

2020-05-10 Thread Dmitriy Pavlov
Hi Denis, Thank you for your valuable proposals, I appreciate it. I've updated the description. Eventually, we need to update it in the ASF records, I guess at projects.apache.org. Report's description is taken from somewhere else and is auto-generated. I've added all points to project or commun

Re: [DISCUSS] Apache Ignite mascot

2020-05-10 Thread Denis Magda
Hi Saikat, I love this idea and, frankly, have been contemplating for a while about the same. Such characters (aka. mascots) can convey the spirit of our project and community as well as make life more entertaining. I bet that every Java developer instantly associates Java (as a project and commu

Re: IGNITE-12997 Rename pub-sub module to pub-sub-ext

2020-05-10 Thread Denis Magda
Hi Saikat, please go ahead and merge the changes. - Denis On Sat, May 9, 2020 at 2:25 PM Saikat Maitra wrote: > Hi, > > I have raised a tiny PR for following issue: > > IGNITE-12997 Rename pub-sub module to pub-sub-ext > > https://issues.apache.org/jira/browse/IGNITE-12997 > > PR : https://gi

Re: IGNITE-12976: Invalid SQL syntax for NULLS LAST / NULLS FIRST in IgniteQueryGenerator

2020-05-10 Thread Denis Magda
Hi Mikhail, Thanks for taking care of this. Please check JIRA. Changes look good to me but I would add a test to ensure that issue doesn't bubble up in the future. - Denis On Sun, May 10, 2020 at 12:33 AM Mikhail Kostyuckovich < m.kostyuckov...@irdeto.com> wrote: > Hello Ignite Developers, > >

IGNITE-12976: Invalid SQL syntax for NULLS LAST / NULLS FIRST in IgniteQueryGenerator

2020-05-10 Thread Mikhail Kostyuckovich
Hello Ignite Developers, I have prepared a small PR fixing the following issue related to Spring Data integration: IGNITE-12976: Invalid SQL syntax for NULLS LAST / NULLS FIRST in IgniteQueryGenerator https://issues.apache.org/jira/browse/IGNITE-12976 Could you please have a look and approve