Re: [VOTE] Ignite Packaging IEP

+1 On Fri, Aug 26, 2022 at 2:55 PM Aleksandr Pakhomov wrote: > +1 > > > On 22 Aug 2022, at 17:04, Mikhail Pochatkin > wrote: > > > > Thank you Anton, for this clarification. Yeah, all points in my previous > > message and IEP only in the context of Ignite 3. > > > > On Mon, Aug 22, 2022 at

Re: IgniteSet, thin client, and WeakReferenceCloseableIterator

I would personally prefer the closeable iterator approach, since it is what most Java libraries use and most users should be familiar with it. Also most IDEs will warn you, if you don't close an AutoCloseable. On Fri, Jun 24, 2022 at 6:24 PM Pavel Tupitsyn wrote: > Igniters, > > I'm working on

Re: [VOTE] Release Apache Ignite 3.0.0-alpha5 RC1

Looks good, so many great features! +1 On Thu, Jun 9, 2022 at 6:42 PM Andrey Gura wrote: > Dear Community, > > In the last few month the following major features have been added: > > - Pluggable storages: ability to choose a specific storage for a > table (RocksDB based storage, Page memory

Re: [ANNOUNCE] Apache Ignite 3.0.0 alpha 5: Code freeze

Hello again, there's another issue that blocks building the release branch: https://issues.apache.org/jira/browse/IGNITE-17144. Fix will be provided shortly On Mon, Jun 6, 2022 at 5:56 PM Andrey Gura wrote: > Igniters, > > our release schedule has shifted a bit. But it is time for a code >

Re: [ANNOUNCE] Apache Ignite 3.0.0 alpha 5: Code freeze

Hello, dear Igniters. I've discovered a bug regarding the Pluggable Storage Engines feature. Please consider adding it to the release scope: https://issues.apache.org/jira/browse/IGNITE-17139 On Mon, Jun 6, 2022 at 5:56 PM Andrey Gura wrote: > Igniters, > > our release schedule has shifted a

Re: [VOTE] Add micronaut dependency to Ignite 3 (reopened)

Aleksandr, Thanks for the update, but can you please explain what security capabilities are planned to be used? Maybe it should be included in the IEP as well. On Sun, May 29, 2022 at 11:03 PM Aleksandr Pakhomov wrote: > Dear community, > > We’ve had a productive discussion about > a micronaut

Re: [VOTE] Add swagger dependency to Ignite 3

+1 from me, I've seen many projects using this approach and I personally find it quite useful On Wed, May 25, 2022 at 5:54 PM Andrey Gura wrote: > Ilya, > > are there any alternatives to Swagger that you could recommend that > don't have the mentioned drawback? > > It seems that OPen API itself

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

er-core/wiki/Swagger-2.X---Annotations#quick-annotation-overview > > > On 23 May 2022, at 12:37, Alexander Polovtcev > wrote: > > > > I'm not that scared of having a big library, I just believe that it might > > be possible to avoid using it altogether. Don't swagger

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

> I get your concerns about additional library, but micronaut itself is quite small. I'm not that scared of having a big library, I just believe that it might be possible to avoid using it altogether. Don't swagger generators have their own annotations? > The IEP replaces (that is important) one

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

Hello, Aleksandr! I agree with the usage of Swagger for generating REST API specifications as it, for example, removes the burden of manually keeping the documentation up to date. However, why do we need the Micronaut framework? No other modules use it, and it brings a lot of dependencies that

Re: [DISCUSSION] Error handling in Ignite 3

Ivan, thanks for the prepared document! I've left a couple questions. On Wed, Mar 23, 2022 at 10:49 AM Ivan Bessonov wrote: > Hi everyone, > > I'd like to continue the discussion. I created IEP with the attempt to > summarize > all the information above, you can find it here [1]. What do you

Re: Ignite 3 Join Protocol

21 февр. 2022 г. в 14:32, Anton Vinogradov : > > > > > Yes, but how about to have explicitly separated the IGNITE-3 project at > > the > > > confluence, where Ignite 3's IEPs will be located? > > > We may also call them I3EP to make clear it's about Ignite 3. > >

Re: Ignite 3 Join Protocol

I've updated the title, is the current name ok? On Mon, Feb 21, 2022 at 12:29 PM Anton Vinogradov wrote: > Alexander, > > Could you please specify (at IEP's name) this IEP is related to the Ignite > 3 (only)? > > On Tue, Feb 15, 2022 at 3:28 PM Alexander Polovtcev < >

Ignite 3 Join Protocol

Hello, dear Igniters! We've prepared an IEP about how to assemble a cluster and add new nodes to it in Ignite 3. Please note that some aspects are out of scope of this particular IEP (like the

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

022 г. в 15:58, Sergey : > > > > > > > > > > +1 for option2 (only @Nullable) > > > > > > > > > > Best regards, > > > > > Sergey Kosarev. > > > > > > > > > > > > > > > чт, 13 янв. 2022 г. в 13:25, Alexander Polo

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

+1 to option 2 On Thu, Jan 13, 2022 at 1:25 PM Alexander Polovtcev wrote: > Dear Igniters, > > In this thread > <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've > discussed possible approaches to using null-related annotations. As the > result,

[VOTE] @Nullable/@NotNull annotation usage in Ignite 3

Dear Igniters, In this thread we've discussed possible approaches to using null-related annotations. As the result, the following approaches were proposed: 1. Use both @Nullable and @NotNull annotations everywhere; 2. Use

Re: [DISCUSSION] @Nullable/@NotNull annotation usage in Ignite 3

;> but > >> > also does not clutter the code with too many annotations. > >> > > >> > I would also keep in mind that annotations are used not only for > static > >> > analysis, but by developers as well. And from this standpoint, I feel > >>

Re: [DISCUSSION] @Nullable/@NotNull annotation usage in Ignite 3

ical. > > 2021-12-17 14:47 GMT+03:00, Alexander Polovtcev : > > Maksim, thank you for the suggestion. > > > > I've never used NullAway, but after having a quick look I think it might > be > > an overkill, since it is a plugin for the ErrorProne, which is a separate

Re: [DISCUSSION] @Nullable/@NotNull annotation usage in Ignite 3

Maksim, thank you for the suggestion. I've never used NullAway, but after having a quick look I think it might be an overkill, since it is a plugin for the ErrorProne, which is a separate tool. I recall some efforts of introducing ErrorProne to Ignite 3 and they were not successful. But again, I

[DISCUSSION] @Nullable/@NotNull annotation usage in Ignite 3

Dear Igniters! I would like to propose a discussion about defining a policy regarding where and how to use @Nullable/@NotNull annotations. These annotations are used in conjunction with a static analysis engine (e.g. built in IDEA) and are useful for avoiding null dereferencing and specifying

Re: [DISCUSSION] Separate Jira project and Confluence space for Ignite 3

+1 This is a welcome proposal, because we already have some pending Ignite 3 specific documents, and it is not clear where to put them at the moment. On Sat, Sep 18, 2021 at 4:22 AM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Igniters, > > I think it's clear to all of us that

Re: [VOTE] Allow or prohibit usages of the Guava library methods

guava in transitive > dependencies. > Can you describe how it should be and where should this explicit > dependency reside? > > > On 13 Sep 2021, at 17:15, Alexander Polovtcev > wrote: > > > > Petr, > > In the original thread we decided to add Guava as an explic

Re: [VOTE] Allow or prohibit usages of the Guava library methods

Ivanov wrote: > Should we somehow restrict using this dependency in the project with Maven > (or any other tools)? > > > On 13 Sep 2021, at 12:47, Alexander Polovtcev > wrote: > > > > The voting has finished and the results are the following: > > &g

Re: [VOTE] Allow or prohibit usages of the Guava library methods

The voting has finished and the results are the following: [+1 Allow]: 1 [-1 Prohibit]: 5 Therefore it is decided to prohibit using Guava in Ignite 3 codebase, even if it is included as a direct dependency. I will add this to the Ignite 3 code style document (or similar) as soon as it is

Re: Ban Java Streams usage in Ignite 3 code

-1 I think that it is not very productive to assume that 100% of your code is on the hot path, it would be impossible to write and maintain. Humans are not very good at guessing where the performance bottlenecks are, so the performance of the possible hot paths should be measured first and only

Re: Re[2]: Google Guava in Ignite 3

ussion in order > to avoid a new flaming thread in the voting topic. > > On Thu, Sep 2, 2021 at 6:04 PM Alexander Polovtcev > wrote: > > > > Andrey, > > > > > It just doesn't work. If there is precedent of usage of Guava methods > > then somebody

Re: [VOTE] Allow or prohibit usages of the Guava library methods

+1 We already have some utility methods that are copy-pasted from Guava, which can be removed, and I believe that *reasonable* usage of this library can benefit the code and the product quality. On Tue, Sep 7, 2021 at 6:27 PM Alexander Polovtcev wrote: > Dear Igniters, > > In th

[VOTE] Allow or prohibit usages of the Guava library methods

Dear Igniters, In this thread we've been discussing the problems and opportunities of using Guava in Ignite 3. We have agreed that it

Re: Re[2]: Google Guava in Ignite 3

hat nobody supports this code. So, from my point of view, it isn't a > problem. > > On Thu, Sep 2, 2021 at 2:52 PM Alexander Polovtcev > wrote: > > > > Andrey, > > I think that the benefits of using Guava methods instead of copy-pasting > them are quite obvious: you

Re: Re[4]: Google Guava in Ignite 3

y-pasting Guava method > to > >> Ignite and use Guava one. > >> The resulted jar will have one copy of such method, but in the second > case, > >> we have to care about compatibility when the transitive Guava dependency > >> will be updated to a new version.

Re: Re[2]: Google Guava in Ignite 3

rectly. > > > On Thu, Sep 2, 2021 at 11:56 AM Alexander Polovtcev < > alexpolovt...@gmail.com> > wrote: > > > Hi, Andrey! > > I mostly agree with your proposal, but, since we already have some > > copy-paste in our code, can we at least use Guava to remo

Re: Re[2]: Google Guava in Ignite 3

r :) > > > > This is a common pratice to reduce language possibilies subset and > > limiting using of some libraries in order to provide more or less > > unified approach to coding. So I propose to disallow using Guava in > > our code base. > > >

Re: Re[2]: Google Guava in Ignite 3

wrote: > I think since Calcite brings it in already then your arguments make sense. > Would it be pinned to the same version as Calcite? Risk NoSuchMethodError > at runtime if not. > +1 > > On Mon, Aug 9, 2021 at 9:56 AM Alexander Polovtcev < > alexpolovt...@gmail.co

Re: [DISCUSSION] Code style for Ignite 3

Hi, Val. This is an extremely welcome change, thank you! On Fri, Aug 20, 2021 at 12:17 AM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Igniters, > > I would like to discuss a potential change to the coding guidelines for > Ignite 3. Currently, we're using the existing guidelines

Re: Ignite 3 async continuation executor

asyncContinuationExecutor" which allows two values "direct" and > "commonPool". > > I'm leaning towards the latter: > > { > "node": { > "metastorageNodes": [ "node-0" ], > "asyncContinuationE

Re: Ignite 3 async continuation executor

Hi, Pavel! Can you please provide an example (e.g. HOCON snippet) of how this configuration is going to look like in Ignite 3? Or how is this property going to be set? On Thu, Aug 19, 2021 at 6:00 PM Pavel Tupitsyn wrote: > Igniters, > > I propose to add a configurable async continuation

Re: Re[2]: Google Guava in Ignite 3

at 12:45 PM Alexander Polovtcev wrote: > Zhenya, > > > But there is no restrictions from running ignite server nodes from some > other code with it`s own guava version seems we obtain fast path to jar > hell here? > > I'm not sure if I fully understand your questi

Re: Re[2]: Google Guava in Ignite 3

Zhenya, > But there is no restrictions from running ignite server nodes from some other code with it`s own guava version seems we obtain fast path to jar hell here? I'm not sure if I fully understand your question, but it looks like we are in this situation already, because we have some

Re: Google Guava in Ignite 3

Thank you for the reply, Courtney! > We use Ignite entirely as a thick client and already have Guava version conflicts from other projects AFAIK and as Ivan wrote before, there are no plans of providing the thick client functionality in Ignite 3, so this may not be an issue. > Even Calcite

Re: Google Guava in Ignite 3

Zhenya, My intentions are the following: 1. Remove some copy-pasted code (like the "bytecode" module or some utility methods). Please see my original message for the links to the code. 2. Explicitly pin the Guava version to avoid conflicts in the runtime. About allowing to use Guava in the

Re: Google Guava in Ignite 3

d it a necessary evil > > > > -- > > Regards, > > Konstantin Orlov > > > > > > > > > On 5 Aug 2021, at 16:37, Alexei Scherbakov < > alexey.scherbak...@gmail.com> > > wrote: > > > > > > +1 > > > &g

Google Guava in Ignite 3

Hello, dear Igniters! I would like to discuss the possibility of using Guava in Ignite 3. I know about the restrictive policy of using it in Ignite 2, but I have the following reasons: 1. We are de-facto using it already as an implicit dependency, since the

Re: [DISCUSS] Confuse default inspections.

this is a very welcome change for me On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin wrote: > + for both points. > > 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > > Hi! > > > > Firstly, lets talk about interfaces. > > > > 1. First of all, do we have an automatic inspection for it? AFAIK we >

Re: Welcome message and contribution request

d to the contributors' list in > Ignite JIRA. > > > - > Denis > > > On Fri, Mar 12, 2021 at 5:08 AM Alexander Polovtcev < > alexpolovt...@gmail.com> > wrote: > > > Hello everyone! My name is Aleksandr and I would like to contribute to > >

Re: Welcome message and contribution request

Sorry, I forgot to include my JIRA username, here it is: apolovtcev With regards, Aleksandr Polovtcev On Fri, Mar 12, 2021 at 2:07 PM Alexander Polovtcev wrote: > Hello everyone! My name is Aleksandr and I would like to contribute to > Ignite. I would like to start by updating the fol

Welcome message and contribution request

Hello everyone! My name is Aleksandr and I would like to contribute to Ignite. I would like to start by updating the following page: https://cwiki.apache.org/confluence/display/IGNITE/TCP+Discovery+SPI+under+the+hood, mostly for correcting typos and grammar. What is the correct process to do that?