Re: IGNITE-640: multimap initial implementation

2018-07-09 Thread Amir Akhmedov
. Please, do not hesitate to directly email me if you mind to have a chat/call. On Wed, Jun 27, 2018 at 11:26 AM Anton Vinogradov wrote: > Sure, > Hope it will be tomorrow > > ср, 27 июн. 2018 г. в 18:11, Amir Akhmedov : > > > Anton V, > > I put some comments into jira ticket.

Relevance of IGNITE-6409

2018-07-07 Thread Amir Akhmedov
Hi Igniters, I want to work on IGNITE-6409 (SQL: bypass H2 during index update) and want to ask about it's status. Is it still relevant ticket to work on? Vladimir Ozerov, as a reporter, can you please give your feedback please? Thanks, Amir

Review for IGNITE-8880: Add setIgnite() in SpringCacheManager and SpringTransactionManager

2018-07-06 Thread Amir Akhmedov
Igniters, Please review my changes. That's a simple change, a setter method was added. Thanks, Amir

Re: IgniteSet implementation: changes required

2018-06-27 Thread Amir Akhmedov
memory directly then its entries can be stored in Ignite persistence > automatically (if the latter is on). Does it mean that the data structure > will be fully recovered after a restart and its entries can be pulled from > disk on demand? > > -- > Denis > > > On Tue, Jun

Re: IGNITE-640: multimap initial implementation

2018-06-27 Thread Amir Akhmedov
Anton V, I put some comments into jira ticket. Can you please take a look once you have a chance? Thanks, Amir On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov wrote: > Amir, > > Everything is fine, I'll check changes this week. > > вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov : >

[jira] [Created] (IGNITE-8880) Add setIgnite() in SpringCacheManager and SpringTransactionManager

2018-06-26 Thread Amir Akhmedov (JIRA)
Amir Akhmedov created IGNITE-8880: - Summary: Add setIgnite() in SpringCacheManager and SpringTransactionManager Key: IGNITE-8880 URL: https://issues.apache.org/jira/browse/IGNITE-8880 Project: Ignite

Re: IgniteSet implementation: changes required

2018-06-26 Thread Amir Akhmedov
I also think it will better to remove setDataMap support cause 1. It's making extra pressure on GC by keeping entries on heap 2. It has difficult logic to support with lots of nuances 3. To maintain setDataMap today GridCacheMapEntry calls cctx.dataStructures().onEntryUpdated() on each entry

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
Great, thanks! As always, happy to contribute! Thanks, Amir On Fri, Jun 22, 2018 at 7:32 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Amir, > > I merged you change to master and 2.6. Thanks! > > -Val > > On Fri, Jun 22, 2018 at 4:21 PM Amir Akhmed

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
Val, I replied to it already :) Thanks, Amir On Fri, Jun 22, 2018 at 7:20 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Amir, > > Thanks for quick reaction. I added a follow up question in the ticket. > > -Val > > On Fri, Jun 22, 2018 at 3:4

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
continuing to contribute. >> >> Bumping up this thread. >> >> Igniters, who has an expertise here? >> >> >> вс, 17 июн. 2018 г. в 17:59, Amir Akhmedov : >> >> > Hi All, >> > Can you please review my changes for IGNITE-8740. >>

Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-17 Thread Amir Akhmedov
Hi All, Can you please review my changes for IGNITE-8740. PR: https://github.com/apache/ignite/pull/4208 TC: https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll Thanks, Amir

Re: IGNITE-640: multimap initial implementation

2018-06-16 Thread Amir Akhmedov
://github.com/apache/ignite.git pull/XXX/head --squash > > > > вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov : > > > Dmitry P., Anton V., > > I made some changes and updated the ticket. Also as was asked I tried to > > squash the commits into one but looks like I screwed

Re: IGNITE-640: multimap initial implementation

2018-06-05 Thread Amir Akhmedov
чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov : > > > Hi Amir, > > > > This is a very necessary contribution, the patch defenetely will not be > > ignored. > > > > Igniters, > > > > Who can make a review from the committers? > > > > Sincerely,

Re: IGNITE-3999 review

2018-05-08 Thread Amir Akhmedov
r, thank you for stepping in. > > > > This case confirms the usefulness of the practice of discussing the > problem > > at the devlist before implementation. > > > > вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <voze...@gridgain.com>: > > > >

Re: IGNITE-3999 review

2018-05-07 Thread Amir Akhmedov
ext few days. > > > В Ср, 11/04/2018 в 14:51 +, Amir Akhmedov пишет: > > Hi Nikolay, > > > > Did you have a chance to check my changes? > > > > Thanks, > > Amir >

Re: IGNITE-640: multimap initial implementation

2018-05-07 Thread Amir Akhmedov
add the following to > MissingMembers array there: > > "multimap" // IGNITE-8425 > > Thanks, > Pavel > > > [1] https://issues.apache.org/jira/browse/IGNITE-8425 > > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <amir.akhme...@gmail.com> > wr

IGNITE-640: multimap initial implementation

2018-04-29 Thread Amir Akhmedov
Hi Igniters, I raised a pull request [1] for Ignite multimap [2]. TC run [3] seems ok to me, some tests are failed though. Can someone review it please and let me know? Thanks, Amir [1] https://github.com/apache/ignite/pull/3926 [2] https://issues.apache.org/jira/browse/IGNITE-640 [3]

Re: IGNITE-3999 review

2018-04-11 Thread Amir Akhmedov
Hi Nikolay, Did you have a chance to check my changes? Thanks, Amir

Re: IGNITE-3999 review

2018-04-07 Thread Amir Akhmedov
CommentId=16426473=com.atlassian.jira. > plugin.system.issuetabpanels:comment-tabpanel#comment-16426473 > > В Ср, 04/04/2018 в 20:16 -0400, Amir Akhmedov пишет: > > Hi Nikolay, > > > > Just a gentle reminder :) > > > > Thanks, > > Amir > > > > On Fri

Re: IGNITE-3999 review

2018-04-04 Thread Amir Akhmedov
Hi Nikolay, Just a gentle reminder :) Thanks, Amir On Fri, Mar 30, 2018 at 12:29 PM, Nikolay Izhikov wrote: > I will take a look at the next week. > > В Пт, 23/03/2018 в 09:50 +0700, Alexey Kuznetsov пишет: > > Vladimir, > > > > As SQL expert, could you review this PR? >

Re: IGNITE-3999 review

2018-03-22 Thread Amir Akhmedov
an) > location: variable qryProc of type > org.apache.ignite.internal.processors.query.GridQueryProcessor > > Sincerely, > Dmitriy Pavlov > > чт, 22 мар. 2018 г. в 6:02, Amir Akhmedov <amir.akhme...@gmail.com>: > > > Dmitry, > > > > TeamCity RunAll completed but

Re: Subject: new committer: Dmitry Pavlov

2018-03-22 Thread Amir Akhmedov
Congratulations! Such an impressive amount of work in such a short time! Thanks, Amir

Re: IGNITE-3999 review

2018-03-21 Thread Amir Akhmedov
Dmitry, TeamCity RunAll completed but the results look awkward. Almost all test suites marked as failed. I noticed the same behavior for other builds though. If you don't mind could you please check is it alright and let me know?

Re: IGNITE-3999 review

2018-03-21 Thread Amir Akhmedov
Dmitry, Since the last TC test run has been done almost 2 months ago I decided to run it again since lot of changes were introduced. I will let you know when tests are finished. Thanks, Amir

IGNITE-3999 review

2018-03-21 Thread Amir Akhmedov
Hi Team, Can anybody review https://github.com/apache/ignite/pull/3444 please? Thanks, Amir

IGNITE-3999: Design discussion

2016-11-06 Thread Amir Akhmedov
possible way, this change can be done with changing the generic type of setFields (which will not be backward compatible) and released in Ignite 2.0. Please advise on this, or maybe you have an alternative solutions? -- Sincerely Yours Amir Akhmedov

PR review

2016-11-06 Thread Amir Akhmedov
Hi Igniters, I raised PR for IGNITE-4176. Can you please review it and let me know? https://issues.apache.org/jira/browse/IGNITE-4176 -- Sincerely Yours Amir Akhmedov

Pull request for IGNITE-3699

2016-08-31 Thread Amir Akhmedov
Hi community, I raised a pull request [1] Can you please review it? [1] https://github.com/apache/ignite/pull/1011 Thanks.

Re: IGNITE-640: IgniteMultimap interface draft version

2016-08-14 Thread Amir Akhmedov
I updated the ticket with design details. Can you please review it and put your comments? https://issues.apache.org/jira/browse/IGNITE-640 On Fri, Aug 12, 2016 at 4:03 PM, Amir Akhmedov <amir.akhme...@gmail.com> wrote: > I think we need both Collection and List interfaces as

IGNITE-640: IgniteMultimap interface draft version

2016-08-11 Thread Amir Akhmedov
* @throws IgniteException If job failed. */ public R affinityCall(IgniteCallable job) throws IgniteException; } -- Sincerely Yours Amir Akhmedov

Re: IGNITE-1227 patch available

2015-11-16 Thread Amir Akhmedov
s > > (identations, brackets usage, etc.). You have some issues in your code > > related to guidelines. You’ll see them when familiarize yourself with > this > > doc: > > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines < > > https://cwik

Re: Implement IgniteMultimap data structures

2015-11-13 Thread Amir Akhmedov
I'll do my best :) Then I'll assign it to me. Thanks. 2015-11-13 14:47 GMT+03:00 Yakov Zhdanov <yzhda...@apache.org>: > Amir, you are welcome! It would be cool if we can get it to 1.6 > > --Yakov > > 2015-11-13 13:50 GMT+03:00 Amir Akhmedov <amir.akhme

IGNITE-1227 patch available

2015-11-13 Thread Amir Akhmedov
Hi Igniters, I submitted patch for IGNITE-1227 <https://issues.apache.org/jira/browse/IGNITE-1227>, could review it whenever it is possible. Thanks. -- Sincerely Yours Amir Akhmedov

Implement IgniteMultimap data structures

2015-11-13 Thread Amir Akhmedov
Hi, If no objections then I would like to start to work on this ticket ( IGNITE-640 <https://issues.apache.org/jira/browse/IGNITE-640>) -- Sincerely Yours Amir Akhmedov

Re: Integration with Spring Transaction Manager

2015-11-04 Thread Amir Akhmedov
hat was granted all > required permissions? > > -- > Denis > > > On 11/4/2015 1:01 PM, Amir Akhmedov wrote: > >> Hi Dmitriy, >> >> I want to give a try on this ticket. Could you assign it to me? >> >> Thanks. >> >> > -- Sincerely Yours Amir Akhmedov

Re: Integration with Spring Transaction Manager

2015-11-04 Thread Amir Akhmedov
Hi Dmitriy, I want to give a try on this ticket. Could you assign it to me? Thanks.