[GitHub] ignite pull request #4239: IGNITE-8849

2018-12-10 Thread EdShangGG
Github user EdShangGG closed the pull request at: https://github.com/apache/ignite/pull/4239 ---

[GitHub] ignite pull request #5623: IGNITE-10623 Possible JVM crash when node stopped...

2018-12-10 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/5623 IGNITE-10623 Possible JVM crash when node stopped with errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite

[GitHub] ignite pull request #5431: Ignite 10328

2018-11-19 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/5431 Ignite 10328 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10328 Alternatively you can review and apply

[GitHub] ignite pull request #4917: IGNITE-9796 NPE if you call array() method on emp...

2018-10-04 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4917 IGNITE-9796 NPE if you call array() method on empty GridLongList You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #4605: IGNITE-8911

2018-08-23 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4605 IGNITE-8911 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8911-1 Alternatively you can review and apply

[GitHub] ignite pull request #4291: Ignite-8911

2018-08-23 Thread EdShangGG
Github user EdShangGG closed the pull request at: https://github.com/apache/ignite/pull/4291 ---

[GitHub] ignite pull request #4562: IGNITE-9302 Java Thin Clients TC configuration ha...

2018-08-16 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4562 IGNITE-9302 Java Thin Clients TC configuration hangs because of no ti… …meout on tests You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] ignite pull request #4544: IGNITE-9266 Cache 2 TC configuration timeouts bec...

2018-08-14 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4544 IGNITE-9266 Cache 2 TC configuration timeouts because of hangs on latch You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache

[GitHub] ignite pull request #4471: IGNITE-9159 Basic 2 TC configuration is halted by...

2018-08-01 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4471 IGNITE-9159 Basic 2 TC configuration is halted by failure handler You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #4441: IGNITE-9100 Split Basic and Cache TC configuratio...

2018-07-26 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4441 IGNITE-9100 Split Basic and Cache TC configurations on pure in-memory… … and with disk usage one You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ignite pull request #4433: IGNITE-9083 Compute (Affinity Run) TC configurati...

2018-07-25 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4433 IGNITE-9083 Compute (Affinity Run) TC configuration timeouts because … …of infinite socket operation You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ignite pull request #4430: IGNITE-9080 Activate | Deactivate Cluster is kill...

2018-07-25 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4430 IGNITE-9080 Activate | Deactivate Cluster is killed by Linux OOM killer You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache

[GitHub] ignite pull request #4423: IGNITE-9069 Hadoop and IGFS TC configurations fai...

2018-07-24 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4423 IGNITE-9069 Hadoop and IGFS TC configurations fail with exit code = 130 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache

[GitHub] ignite pull request #4390: IGNITE-9039 AssertionError on cache stop

2018-07-20 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4390 IGNITE-9039 AssertionError on cache stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9039 Alternatively

[GitHub] ignite pull request #4386: IGNITE-8220

2018-07-19 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4386 IGNITE-8220 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8220-1 Alternatively you can review and apply

[GitHub] ignite pull request #4383: IGNITE-9004

2018-07-19 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4383 IGNITE-9004 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9004 Alternatively you can review and apply these

[GitHub] ignite pull request #4377: IGNITE-9025 "PDS 1" TC configuration could hang b...

2018-07-17 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4377 IGNITE-9025 "PDS 1" TC configuration could hang because of SegmentedR… …ingByteBufferTest Signed-off-by: EdShangGG You can merge this pull request into a Git repository

[GitHub] ignite pull request #4373: IGNITE-9018 PDS1 TC configuration hangs periodica...

2018-07-17 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4373 IGNITE-9018 PDS1 TC configuration hangs periodically Signed-off-by: EdShangGG You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain

[GitHub] ignite pull request #4369: Ignite-9013

2018-07-16 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4369 Ignite-9013 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9013 Alternatively you can review and apply these

[GitHub] ignite pull request #4367: IGNITE-9012 Test IgniteServiceReassignmentTest.te...

2018-07-16 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4367 IGNITE-9012 Test IgniteServiceReassignmentTest.testZombieAssignmentsC… …leanup fails Signed-off-by: EdShangGG You can merge this pull request into a Git repository by running

[GitHub] ignite pull request #4346: Stockengine

2018-07-10 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4346 Stockengine You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite stockengine Alternatively you can review and apply these

[GitHub] ignite pull request #4327: Ignite-8955

2018-07-06 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4327 Ignite-8955 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8955-1 Alternatively you can review and apply

[GitHub] ignite pull request #4291: Ignite-8911

2018-07-02 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4291 Ignite-8911 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8911 Alternatively you can review and apply these

[GitHub] ignite pull request #4269: Revert "IGNITE-8749 Exception for "no space left"...

2018-06-27 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4269 Revert "IGNITE-8749 Exception for "no space left" situation should be… … propagated to FailureHandler - Fixes #4200." This reverts commit 3fff8a8 Sign

[GitHub] ignite pull request #4239: IGNITE-8849

2018-06-21 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4239 IGNITE-8849 Signed-off-by: EdShangGG You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8849 Alternatively you

[GitHub] ignite pull request #4201: Ignite-2.5.1-p7

2018-06-15 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4201 Ignite-2.5.1-p7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.5.1-p7 Alternatively you can review and

[GitHub] ignite pull request #4104: IGNITE-8673 Reconcile isClient* methods

2018-05-31 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/4104 IGNITE-8673 Reconcile isClient* methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8673 Alternatively

[GitHub] ignite pull request #3916: Ignite 7628 1

2018-04-25 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3916 Ignite 7628 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7628-1 Alternatively you can review and apply

[GitHub] ignite pull request #3757: SqlQuery hangs indefinitely with additional not r...

2018-04-05 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3757 SqlQuery hangs indefinitely with additional not registered in baseline node. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache

[GitHub] ignite pull request #3736: Ignite 2.4.2 master

2018-04-02 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3736 Ignite 2.4.2 master You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.4.2-master Alternatively you can review

[GitHub] ignite pull request #3734: IGNITE-8114 Add fail recovery mechanism to tracki...

2018-04-02 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3734 IGNITE-8114 Add fail recovery mechanism to tracking pages You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8114

[GitHub] ignite pull request #3718: Ignite 2.4.2 p7

2018-03-29 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3718 Ignite 2.4.2 p7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.4.2-p7 Alternatively you can review and

[GitHub] ignite pull request #3677: IGNITE-8007 We should treat as empty any partitio...

2018-03-21 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3677 IGNITE-8007 We should treat as empty any partition as empty if it doe… …sn't have any data You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ignite pull request #3632: IGNITE-7947 Not all OWNING partitions saved in Pa...

2018-03-14 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3632 IGNITE-7947 Not all OWNING partitions saved in PartitionAllocationMap… … during checkpoint You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ignite pull request #3512: IGNITE-7626 Unify code in test which clean up per...

2018-02-12 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3512 IGNITE-7626 Unify code in test which clean up persistence directories You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #3510: IGNITE-7676 Add affinity version to snapshot plug...

2018-02-12 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3510 IGNITE-7676 Add affinity version to snapshot plugin stub You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7676

[GitHub] ignite pull request #3509: GG-13266 Node which not in baseline participating...

2018-02-12 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3509 GG-13266 Node which not in baseline participating in snapshot GG-13344 CANCEL of RESTORE could hang You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ignite pull request #3509: GG-13266 Node which not in baseline participating...

2018-02-12 Thread EdShangGG
Github user EdShangGG closed the pull request at: https://github.com/apache/ignite/pull/3509 ---

[GitHub] ignite pull request #3477: IGNITE-7626 Unify code in test which clean up per...

2018-02-05 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3477 IGNITE-7626 Unify code in test which clean up persistence directories You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #3476: IGNITE-7626

2018-02-05 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3476 IGNITE-7626 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-gg-13414 Alternatively you can review and apply

[GitHub] ignite pull request #3432: Ignite 7521

2018-01-24 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3432 Ignite 7521 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7521 Alternatively you can review and apply these

[GitHub] ignite pull request #3431: IGNITE-7520 Provide util-methods to get baseline ...

2018-01-24 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/3431 IGNITE-7520 Provide util-methods to get baseline from context You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite

[GitHub] ignite pull request #2913: Ignite 6512

2017-10-24 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2913 Ignite 6512 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6512 Alternatively you can review and apply these

[GitHub] ignite pull request #2912: IGNITE-6720 Move operation with file system outsi...

2017-10-24 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2912 IGNITE-6720 Move operation with file system outside checkpoint write … …lock You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain

[GitHub] ignite pull request #2910: Ignite 6512

2017-10-23 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2910 Ignite 6512 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6512 Alternatively you can review and apply these

[GitHub] ignite pull request #2817: IGNITE-6577

2017-10-08 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2817 IGNITE-6577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6577 Alternatively you can review and apply these

[GitHub] ignite pull request #2772: Ignite 6512

2017-09-28 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2772 Ignite 6512 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6512 Alternatively you can review and apply these

[GitHub] ignite pull request #2718: Ignite 6434

2017-09-21 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2718 Ignite 6434 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6434 Alternatively you can review and apply these

[GitHub] ignite pull request #2707: IGNITE-6460 Wrong consistentId for lightweight Cl...

2017-09-20 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2707 IGNITE-6460 Wrong consistentId for lightweight ClusterNode instances You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #2694: Ignite 6342 2

2017-09-19 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2694 Ignite 6342 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6342-2 Alternatively you can review and apply

[GitHub] ignite pull request #2679: Ignite 6342

2017-09-17 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2679 Ignite 6342 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6342 Alternatively you can review and apply these

[GitHub] ignite pull request #2605: Ignite 6277

2017-09-06 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2605 Ignite 6277 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6277 Alternatively you can review and apply these

[GitHub] ignite pull request #2507: IGNITE-6175 JVM Crash in "Ignite Binary Objects S...

2017-08-23 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2507 IGNITE-6175 JVM Crash in "Ignite Binary Objects Simple Mapper Basic" … …suite You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] ignite pull request #2423: IGNITE-5943

2017-08-09 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2423 IGNITE-5943 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite IGNITE-5943 Alternatively you can review and apply these

[GitHub] ignite pull request #2347: IGNITE-5843 Ignite PDS: We don't save cache confi...

2017-07-26 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2347 IGNITE-5843 Ignite PDS: We don't save cache configuration if we get i… …t on join You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] ignite pull request #2294: ignite-5747

2017-07-13 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2294 ignite-5747 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5747 Alternatively you can review and apply these

[GitHub] ignite pull request #2275: ignite-5662

2017-07-10 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2275 ignite-5662 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5662 Alternatively you can review and apply these

[GitHub] ignite pull request #2078: Ignite gg 8.0.4.ea2 for tests

2017-06-05 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2078 Ignite gg 8.0.4.ea2 for tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-gg-8.0.4.ea2 Alternatively you

[GitHub] ignite pull request #2029: IGNITE-5301 JVM crashes on H2TreeIndex destroy

2017-05-29 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/2029 IGNITE-5301 JVM crashes on H2TreeIndex destroy You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5301

[GitHub] ignite pull request #1894: IGNITE-4989 Assertion error in BPlusTree#finishTa...

2017-05-02 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/1894 IGNITE-4989 Assertion error in BPlusTree#finishTail You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4989

[GitHub] ignite pull request #1299: Ignite 4332

2016-11-29 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/1299 Ignite 4332 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite IGNITE-4332 Alternatively you can review and apply these

[GitHub] ignite pull request #949: Ignite 2546

2016-08-11 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/949 Ignite 2546 You can merge this pull request into a Git repository by running: $ git pull https://github.com/EdShangGG/ignite ignite-2546 Alternatively you can review and apply these

[GitHub] ignite pull request #931: IGNITE-1192

2016-08-08 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/931 IGNITE-1192 You can merge this pull request into a Git repository by running: $ git pull https://github.com/EdShangGG/ignite IGNITE-1192 Alternatively you can review and apply these

[GitHub] ignite pull request #907: Ignite 3513

2016-07-28 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/907 Ignite 3513 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3513 Alternatively you can review and apply these

[GitHub] ignite pull request #885: ignite-3476

2016-07-26 Thread EdShangGG
Github user EdShangGG closed the pull request at: https://github.com/apache/ignite/pull/885 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #885: ignite-3476

2016-07-22 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/885 ignite-3476 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3476 Alternatively you can review and apply these

[GitHub] ignite pull request #884: Ignite 3476

2016-07-22 Thread EdShangGG
Github user EdShangGG closed the pull request at: https://github.com/apache/ignite/pull/884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #884: Ignite 3476

2016-07-22 Thread EdShangGG
GitHub user EdShangGG opened a pull request: https://github.com/apache/ignite/pull/884 Ignite 3476 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3476 Alternatively you can review and apply these