Re: [apache/ignite] [IGNITE-2929] IgniteContext should not have type parameters (#740)

2016-05-25 Thread Dmitriy Setrakyan
In my view this change fixes a fundamental problem in the initial design, so I vote to have it merged. We should make it very clear to users that this change is incompatible with previous releases and provide a simple upgrade example in the documentation. On Wed, May 25, 2016 at 10:20 AM, Ahmad

Re: [apache/ignite] [IGNITE-2929] IgniteContext should not have type parameters (#740)

2016-05-25 Thread Alexey Goncharuk
Dmitriy, Yakov, Alexey K., What are your thoughts?

Re: [apache/ignite] [IGNITE-2929] IgniteContext should not have type parameters (#740)

2016-05-25 Thread Ahmad Alkilani
Yes this is a breaking change however it addresses a real problem. I was going to pick up the ticket had someone not already fixed this. Thanks for taking care of this. For what it's worth, the original "bug" causes more problems than any breaking change would to fix it. Also Valentin's note about

Re: [apache/ignite] [IGNITE-2929] IgniteContext should not have type parameters (#740)

2016-05-24 Thread Alexey Goncharuk
Folks, The PR looks good to me. There is one concern - even though the type parameters were placed to IgniteContext by mistake, removing them will break backward compatibility. Are we ok with that? Val, can you comment? 2016-05-21 8:32 GMT-07:00 MaBiao : > @agoncharuk