Re: .NET naming convention + RegisterSameJavaType mode

2021-02-15 Thread Pavel Tupitsyn
> And if we make GetTypeName virtual then any user can make extension of BinaryBasicNameMapper and use it. > I thought we want to avoid this. Yes, let's avoid this. Making those methods virtual makes everything even harder to understand, especially the logic behind RegisterSameJavaType: we don't w

Re: .NET naming convention + RegisterSameJavaType mode

2021-02-14 Thread Nikolay Izhikov
Hello, Pavel. Thanks, for the feedback > We can create a derived class so that existing _registerSameJavaType logic > works. For now, BinaryBasicNameMapper#GetTypeName is not virtual. So we can’t override it. And if we make GetTypeName virtual then any user can make extension of BinaryBasicNa

.NET naming convention + RegisterSameJavaType mode

2021-02-12 Thread Nikolay Izhikov
Hello, Igniters. Currently, BasicBinaryNameMapper[isSimpleName=false] assumes that type names equals both in Java and .Net. • Java type - ru.company.Model • .Net type - ‘ru.company.Model` However, .net naming conventions [1] differs from java [2] So, if a user follows both conve