Re: CacheConfiguration reusage issues with EvictionPolicy enabled.

2017-10-30 Thread Andrey Mashenkov
Up. Would someone please review a PR#2896 for IGNITE-6649 [1]? [1] https://issues.apache.org/jira/browse/IGNITE-6649 On Sat, Oct 21, 2017 at 1:51 AM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > I don't think it's a big problem. But it would be great if someone better >

Re: CacheConfiguration reusage issues with EvictionPolicy enabled.

2017-10-20 Thread Valentin Kulichenko
I don't think it's a big problem. But it would be great if someone better experienced in Hadoop stuff chimes in. -Val On Fri, Oct 20, 2017 at 8:50 AM, Andrey Mashenkov < andrey.mashen...@gmail.com> wrote: > Val, > > It doesn't look possible to do without refactoring. > I've make a PR#2896 [1]

Re: CacheConfiguration reusage issues with EvictionPolicy enabled.

2017-10-20 Thread Andrey Mashenkov
Val, It doesn't look possible to do without refactoring. I've make a PR#2896 [1] with a fix and want to someone look at it as I'm not familiar with Hadoop module. Will it be ok to left it "as is" for now and create a ticket for refactoring? On Fri, Oct 20, 2017 at 3:15 AM, Valentin Kulichenko

Re: CacheConfiguration reusage issues with EvictionPolicy enabled.

2017-10-19 Thread Valentin Kulichenko
Andrey, Using factory instead of policy instance in configuration makes sense to me, I think we should do this change. As for Hadoop module issue, is it possible to do the mentioned validation after creating the policy? I think that should fix the problem. -Val On Thu, Oct 19, 2017 at 7:50 AM

CacheConfiguration reusage issues with EvictionPolicy enabled.

2017-10-19 Thread Andrey Mashenkov
Hi Igniters, I'm working on a ticket IGNITE-6649 [1] and got stuck. Currently, we allow user to set EvictionPolicy instance into configuration instead of factory. The leads to some isses when user tries to reuse EvictionPolicy instance, e.g. it doesn't clean its queue on cache stop. Seems, we