Hi Anton,
Teamcity Bot shows JIRA status in addition to a link to PR, so once PR
count is 100 instead of 1200 we easily can clean up it from time to time.
Just the same way with cleaning up git branches in the Apache repository.
I do this cleaning time to time and its not a problem. Just like I'v
Peter,
Not sure I've got how you're going to keep this ok in future.
This crusade is useful only in case you have the plan.
>> And closing PRs after merge or some decent waiting period of inactivity
seems to be at least sign of respect to each other of our community.
We have to find an easy (auto
Anton,
Maintaining order always worth it.
If we did not made this mess initially, no crusade would be required now.
And closing PRs after merge or some decent waiting period of inactivity seems
to be at least sign of respect to each other of our community.
Anyway, looks like that this task can
Folks,
Is it possible just to ignore obsolete PRs somehow?
Not sure this crusade worth it.
On Thu, Jul 25, 2019 at 1:18 PM Павлухин Иван wrote:
> Maxim,
>
> Quite a nice idea. Could we go even further? Add a comment to each 1-2
> year old PR asking if the author could close it (most likely with
Maxim,
Quite a nice idea. Could we go even further? Add a comment to each 1-2
year old PR asking if the author could close it (most likely with help
of some automation). As I know GitHub sends emails with PR comments to
authors.
чт, 25 июл. 2019 г. в 13:05, Dmitriy Pavlov :
>
> Folks, please clos
Folks, please close not needed PRs.
I don't have contact with Pyatkov & dkarachentsev. Folks, please step in.
Also, feel free to reopen PRs if you still want change to be merged.
чт, 25 июл. 2019 г. в 12:39, Maxim Muzafarov :
> Folks,
>
> Can we contact with some members manually and ask them to
Folks,
Can we contact with some members manually and ask them to close unused
PRs? Most of the users are active community members, so I think they
will respond quite fast.
I've briefly checked GitHub:
dkarachentsev - 62 opened PRs
ilantukh - 58 opened PRs
dgovorukhin - 44 opened PRs
mcherkasov -
Hi Alexey,
second need it to check all open PRs from community members for fixes,
which could be merged to Ignite codebase.
Which is why I'm not so sure that we should automatically close. I ask
everyone to close their PRs, and I manually double-check PRs remained
opened.
The third need is to au
The long period totally reduces the discontent and outrage of community
members (if you reduce to 2-6 weeks it could be intersected with human
events of most part of contributors like vacation, birthdays, wedding, spam
filters and etc.), believe me (I have the same experience as I mentioned)
>From
Alexey,
Yep, I imagined a similar procedure in my mind. Just curious, why do
you think that a period before actions are taken should be so long
(3-6 months)?.
чт, 25 июл. 2019 г. в 11:55, Alexey Zinoviev :
>
> Dear Igniters, I have one suggestion
>
> If a most of commiters will support idea of au
Dear Igniters, I have one suggestion
If a most of commiters will support idea of automatic "cleaning", we should
provide next options
- declare a long period for putting labels or leaving comments for
useful PRs from their authors (about 3-6 months)
- generate notifications for all autho
Nikolay, committer could after setting up a link between GH & Apache
accounts.
https://gitbox.apache.org/setup/
чт, 25 июл. 2019 г. в 11:17, Nikolay Izhikov :
> Yes.
>
> Do someone have permission to close my(or any other contributor) PR to
> apache/ignite?
>
> В Чт, 25/07/2019 в 11:05 +0300, Пав
Hi Ivan,
Thank you for bumping this topic.
I consider PRs for resolved or closed tickets are obsolete and I close it
from time to time.
TC Bot shows which PRs related to closed and resolved, so it is possible to
enter your GitHub ID at PRs page and see which PRs are not needed.
Also, committers
Yes.
Do someone have permission to close my(or any other contributor) PR to
apache/ignite?
В Чт, 25/07/2019 в 11:05 +0300, Павлухин Иван пишет:
> NIkolay,
>
> Do you mean technical ability?
>
> чт, 25 июл. 2019 г. в 10:33, Nikolay Izhikov :
> >
> > Hello, Ivan.
> >
> > Do we have the ability
NIkolay,
Do you mean technical ability?
чт, 25 июл. 2019 г. в 10:33, Nikolay Izhikov :
>
> Hello, Ivan.
>
> Do we have the ability to close PRs from other contributors?
>
> В Чт, 25/07/2019 в 09:12 +0300, Павлухин Иван пишет:
> > Igniters,
> >
> > I would like to resume a discussion about PRs cl
Hello, Ivan.
Do we have the ability to close PRs from other contributors?
В Чт, 25/07/2019 в 09:12 +0300, Павлухин Иван пишет:
> Igniters,
>
> I would like to resume a discussion about PRs cleanup. Additionally
> to concerns provided earlier some TC Bot operations are slowed down
> due to a hu
Igniters,
I would like to resume a discussion about PRs cleanup. Additionally
to concerns provided earlier some TC Bot operations are slowed down
due to a huge amount of open PRs.
As time has passed, I ask you all again to share an opinion about
centralized cleanup of obsolete PRs. Also, a preci
> On 11 Dec 2018, at 10:10, Nikolay Izhikov wrote:
>
> Hello, Ivan.
>
> Personally, I keep my PR's clear.
> So, I don't have dozens of opened PR.
>
> But, I don't support Dmitriy proposal for several reasons:
>
> 1. We introduce some new, not required, level of bureaucracy.
> From my experi
Infra should be the owner.
BTW, How about to specify strict PR flow and get community approval before
starting such batch closes?
On Tue, Dec 11, 2018 at 5:35 PM Pavel Tupitsyn wrote:
> Dmitriy, admin rights allow closing any PRs, I wonder who is admin for
> Ignite GitHub mirror.
>
> On Tue, De
Dmitriy, admin rights allow closing any PRs, I wonder who is admin for
Ignite GitHub mirror.
On Tue, Dec 11, 2018 at 1:29 PM Павлухин Иван wrote:
> Dmitiy,
>
> I see the point. And also I see that not everyone supports a suggested
> cleanup. (I personally like the idea very much). But all in all
Dmitiy,
I see the point. And also I see that not everyone supports a suggested
cleanup. (I personally like the idea very much). But all in all I
think that everyone is free to close his own PRs if he would like to.
As already have done I, Pavel and others.
Nikolay,
> 3. I dont' see any issues wi
+1
When I just joined the project I was really confused with the huge number
of opened PRs with poor description and cryptic reason.
This can give to newcomers a weird representation of what is
actually happening in the project.
Don't be lazy, just spend 5-10 minutes of free time and clean up afte
My point is - close your outdated PRs/if you don't need. It is not a
pattern nor enforcement nor bureaucracy.
You're absolutely free to use PRs in any way you like to (e.g. experiments
with TC runs).
Now count of PRs shocks newcomers.
вт, 11 дек. 2018 г. в 10:10, Nikolay Izhikov :
> Hello, Ivan
Hello, Ivan.
Personally, I keep my PR's clear.
So, I don't have dozens of opened PR.
But, I don't support Dmitriy proposal for several reasons:
1. We introduce some new, not required, level of bureaucracy.
From my experience - not required bureaucracy is a BAD thing.
2. We spread our work patte
Hi Ivan,
Unfortunately, I don't have the necessary rights to close PRs. Only PR
author can close.
I can only imagine the following way: Produce fake commit(s) with message
Fixes #. But this may be acceptable if PR author is not responding.
Simple expiration policy may have its own issues. Th
Agree with Dmitriy.
We use GitHub PRs in our workflow, therefore we should keep them in order.
We can close PRs that refer to closed tickets, this can be done with a
simple script.
On Tue, Dec 11, 2018 at 9:15 AM Павлухин Иван wrote:
> Nikolay,
>
> I must say that when I first saw 1K+ open PRs
Nikolay,
I must say that when I first saw 1K+ open PRs my first thought was
that something was wrong with a review process. In my mind in not very
big project open PR list can reflect very well the real work in
progress. For bigger projects things become more complicated.
Dmitriy,
Do you have so
The main concern is related to chances that newcomer will have to obtain a
review support from the community.
Actually, a lot of people doing their best to provide a feedback to
newcomers, and count of issues still in PA state goes down (84 is a
relatively small count of issues in PA state). But 1
Hello, Dmitriy.
What, exactly concerns newcomers?
What is wrong with opened PR?
How project will benefit from closed PR?
> The same proposal is related to IEP statuses. If you were involved in an
IEP, please validate its status
+1. We should maintain IEP description up to date.
пн, 10 дек. 2018
Hi Igniters,
Newcomers to Apache Ignite sometimes became concerned about many open PRs
in the project. Apache Ignite TC Bot also performs runs checks with a PR
open. Apache Ignite pulls list https://github.com/apache/ignite/pulls contains
1442 PRs open while only 84 issues are waiting for review.
30 matches
Mail list logo
