Re: Code Review Tool Proposal: Upsource

I've started the vote. Meanwhile, we have reached the user limit in the evaluation version. Some people report that they can't register; we will request proper open-source license as soon as the vote succeeds. On Wed, Nov 16, 2016 at 12:18 AM, Denis Magda wrote: > Pavel, > >

Re: Code Review Tool Proposal: Upsource

Pavel, Makes sense to me. Let’s start the voting process then adding the link to this discussion to the voting thread. I would wait no less than 5 days giving a chance to everyone to share his/her opinion. — Denis > On Nov 14, 2016, at 11:16 AM, Pavel Tupitsyn wrote: >

Re: Code Review Tool Proposal: Upsource

I'd say that Github may be good for small changes, but when you trying to review a big PR (like 100 files) it becomes almost unusable, because it loads everything in one shot with no convenient navigation. Also it happened to me that I lost some of my review comments on Github for no obvious

Re: Code Review Tool Proposal: Upsource

Denis, Contributors will have to start a review on branch or pull request manually (a couple of clicks really), then attach an URL to the JIRA ticket. Example: https://issues.apache.org/jira/browse/IGNITE-4116 > are there any examples of Apache projects that used some 3rd party tool for review

Re: Code Review Tool Proposal: Upsource

Why not / what is wrong with GitHub? Code is there anyhow... I've found this seems to be the way a lot of projects have gone. It allows me to review the code without checkout I can comment inline with a pr or code commit I can fork a project to my own space and create a pr back to the main

Re: Code Review Tool Proposal: Upsource

Hi Pavel, Very good idea! This will make review process transparent and more community-friendly. So huge +1. On Mon, Nov 14, 2016 at 4:17 PM, Andrey Gura wrote: > +1 > > Great tool. > > On Mon, Nov 14, 2016 at 3:19 PM, Anton Vinogradov < > avinogra...@gridgain.com> > wrote: >

Re: Code Review Tool Proposal: Upsource

+1 Great tool. On Mon, Nov 14, 2016 at 3:19 PM, Anton Vinogradov wrote: > +1 > > On Mon, Nov 14, 2016 at 3:08 PM, Pavel Tupitsyn > wrote: > > > Igniters, > > > > We have set up Upsource code review tool at > > http://reviews.ignite.apache.org/ >

Code Review Tool Proposal: Upsource

Igniters, We have set up Upsource code review tool at http://reviews.ignite.apache.org/ I propose to evaluate it and see if it works for us. * Why? Current JIRA-based process is not very efficient. Anyone who have used a review tool will probably agree: - No need to switch branches locally