Re: Enums and SQL queries

2016-07-28 Thread Dmitriy Setrakyan
Sergi, in this case, can you please describe the design n the ticket, so someone could pick this up? On Thu, Jul 28, 2016 at 4:14 AM, Sergi Vladykin wrote: > No, as I told you, we have to contribute this feature to H2. > > Sergi > > 2016-07-28 10:23 GMT+03:00 Dmitriy

Re: Enums and SQL queries

2016-07-28 Thread Sergi Vladykin
No, as I told you, we have to contribute this feature to H2. Sergi 2016-07-28 10:23 GMT+03:00 Dmitriy Setrakyan : > Sergi, is there a standard way to add a custom type to H2? Is it > documented? > > On Thu, Jul 28, 2016 at 2:17 AM, Sergi Vladykin

Re: Enums and SQL queries

2016-07-28 Thread Dmitriy Setrakyan
Sergi, is there a standard way to add a custom type to H2? Is it documented? On Thu, Jul 28, 2016 at 2:17 AM, Sergi Vladykin wrote: > Sure. > > https://issues.apache.org/jira/browse/IGNITE-3595 > > Sergi > > 2016-07-27 22:51 GMT+03:00 Dmitriy Setrakyan

Re: Enums and SQL queries

2016-07-28 Thread Sergi Vladykin
Sure. https://issues.apache.org/jira/browse/IGNITE-3595 Sergi 2016-07-27 22:51 GMT+03:00 Dmitriy Setrakyan : > Sorry, Sergi. What I meant is to file a ticket with the design you > suggested > > Dmitriy > > > > > On Jul 27, 2016, at 9:18 AM, Sergi Vladykin

Re: Enums and SQL queries

2016-07-27 Thread Dmitriy Setrakyan
Sorry, Sergi. What I meant is to file a ticket with the design you suggested Dmitriy > On Jul 27, 2016, at 9:18 AM, Sergi Vladykin wrote: > > I don't see how this can work to file a ticket, could you please give more > details? > > Sergi > > 2016-07-27 15:50

Re: Enums and SQL queries

2016-07-27 Thread Sergi Vladykin
I don't see how this can work to file a ticket, could you please give more details? Sergi 2016-07-27 15:50 GMT+03:00 Dmitriy Setrakyan : > Sergi, I still thinks my solution works or can be made to work. In the > example you provided, you can choose to return either String

Re: Enums and SQL queries

2016-07-27 Thread Dmitriy Setrakyan
Sergi, I still thinks my solution works or can be made to work. In the example you provided, you can choose to return either String or Enum as the query result. However, this is not a clean solution, I agree, but could be a quick one. I don't mind breaking compatibility on this issue, given that

Re: Enums and SQL queries

2016-07-27 Thread Sergi Vladykin
Nope. This will not work. Because take for example the following query: select my_enum_field from my_table where my_enum_field = 'BLA' Field well be evaluated only once here, but it must be a Sting and Enum at the same time. Probably we could contribute to H2 `User defined value types` and

Re: Enums and SQL queries

2016-07-27 Thread Dmitriy Setrakyan
Hm... I would prefer to find a way to handle Enums automatically. In case if user expects a String, can we catch an exception and do automatic conversion at that time? In this case, we could catch the exception once and remember the decision. Will something like this work? D. On Tue, Jul 26,

Re: Enums and SQL queries

2016-07-25 Thread Sergi Vladykin
GridQueryProcessor contains two types: BinaryProperty and ClassProperty. Indexing uses them for fields access. Probably we can change them, so that they will always return String instead of Enum type but this 1. looks like a compatibility breaking change; 2. users doing queries like `select

Re: Enums and SQL queries

2016-07-25 Thread Valentin Kulichenko
Sergi, Ideally, I would like this query to work: select * from MyTable where myEnumField = 'MY_ENUM_NAME' The problem is that the field value is not a string, it's a binary object with the enum value ordinal inside. We can add enum value names into the metadata, so that we can always map the

Re: Enums and SQL queries

2016-07-22 Thread Sergi Vladykin
I'm not sure what exactly you are going to patch in SQL engine. We could and some SQL function like enum('MY_ENUM_NAME') but probably it will not work if we will not pass enum type there as well, so it have look like enum('com.mycompany.MyEnum', 'MY_ENUM_NAME') which is ugly. Sergi On 23 июля

Enums and SQL queries

2016-07-22 Thread Valentin Kulichenko
Folks, I noticed that we currently have a very weird limitation for enum fields when running SQL queries. Basically, you can't use enum value names as many users would expect. Technically this happens because binary format stores only ordinal and the only way to run such query is to do something