Re: IGNITE-5123 Review

Thank you! Many thanks to Dmitry for his attitude and dedication! On 24.07.2017 16:47, Semyon Boikov wrote: Evgeniy and Dmitry, thanks for the fix! Merged into master. Thanks! On Sun, Jul 23, 2017 at 9:21 PM, Dmitry Pavlov wrote: Hi Evgeniy, From my point of view

Re: IGNITE-5123 Review

Evgeniy and Dmitry, thanks for the fix! Merged into master. Thanks! On Sun, Jul 23, 2017 at 9:21 PM, Dmitry Pavlov wrote: > Hi Evgeniy, > > From my point of view there are no problems with this fix. My testing > didn't show any issues with fix. > > Igniters, > > Are

Re: IGNITE-5123 Review

Hi Evgeniy, Thank you for such a careful research of the issue. If don’t mind, I would like to do additional tests with this PR changes. I will come back with result in couple of days Sincerely, Dmitriy Pavlov чт, 20 июл. 2017 г. в 19:18, Evgeniy Ignatiev : >

Re: IGNITE-5123 Review

Hi Nick, Thank you for your comment. Was onIgniteStart called after onKernalStart in 1.9? Or caches were available, but other of initialization was the same? Sincerely. Dmitriy Pavlov ср, 19 июл. 2017 г. в 17:06, Nick Pordash : > Hi Dmitriy, > > The ticket was a

Re: IGNITE-5123 Review

Hi Evgeniy, I've checked the results. All of failures are flaky tests, failed with issue link or were failed somewhere else. Sincerely, Dmitriy Pavlov чт, 20 июл. 2017 г. в 11:48, Evgeniy Ignatiev : > Rerun tests in "Run All" Ignite 2.0 group after merge with the

Re: IGNITE-5123 Review

Scheduled "Run All" in Ignite 2.0 Tests for pull/2285/head - http://ci.ignite.apache.org/viewQueued.html?itemId=734208 On 19.07.2017 17:55, Dmitry Pavlov wrote: Hi Evgeniy, Thank you. Ignite Basic is one suite from approximately 80 suites that covers Ignite by automated tests. Which is why I

Re: IGNITE-5123 Review

Hi Dmitriy, The ticket was a regression from 1.9 to 2.0. I don't think anyone would be expecting the behavior in 2.0 as it doesn't align with the javadoc and has only been broken since the 2.0 release. -Nick On Wed, Jul 19, 2017, 6:55 AM Dmitry Pavlov wrote: > Hi

Re: IGNITE-5123 Review

Hi Evgeniy, Thank you. Ignite Basic is one suite from approximately 80 suites that covers Ignite by automated tests. Which is why I suggested to use RunAll chain in ignite 2.0 group. Yes, several tests may fail, especially if it is flaky tests or failure is related to the specific JIRA issue.

Re: IGNITE-5123 Review

http://ci.ignite.apache.org/viewLog.html?buildId=720722=buildResultsDiv=IgniteTests_IgniteBasic - this one - there seem to be no new failed platform tests, other failed tests seem to fail in several other reviews too and are unrelated to my changes. On 19.07.2017 17:35, Dmitry Pavlov wrote:

Re: IGNITE-5123 Review

Hi Evgeniy, I was not able to find Teamcity run for this change. Could you please run http://ci.ignite.apache.org test for example on branch pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'. Or could you please share link to previous run on this changes? Sincerely, Dmitriy Pavlov ср, 19

Re: IGNITE-5123 Review

Igniters, Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: > Hello, Igniters. > > Could anyone review my request - https://issues.apache.org/jira > /browse/IGNITE-5123? - My previous pings seems to got lost. > > Best

IGNITE-5123 Review

Hello, Igniters. Could anyone review my request - https://issues.apache.org/jira/browse/IGNITE-5123? - My previous pings seems to got lost. Best regards, Yevgeniy