Thank you, Val.
Ilya, please let me know if the PR looks ok.
On Thu, 29 Apr 2021, 00:19 Valentin Kulichenko, <
valentin.kuliche...@gmail.com> wrote:
> I'm OK with the design.
>
> Ilya, please feel free to merge if the implementation and tests look good
> to you.
>
> -Val
>
> On Wed, Apr 28,
I'm OK with the design.
Ilya, please feel free to merge if the implementation and tests look good
to you.
-Val
On Wed, Apr 28, 2021 at 1:07 AM Atri Sharma wrote:
> Hi Ilya and Val,
>
> Thank you for taking a look and providing insights. I have updated the
> PR and raised another iteration.
>
Hi Ilya and Val,
Thank you for taking a look and providing insights. I have updated the
PR and raised another iteration.
Val, I have moved the configuration to TcpDiscoverySpi.
Please see and let me know your thoughts and comments.
Regards,
Atri
On Wed, Apr 28, 2021 at 2:11 AM Valentin
Hi Atri,
I've noticed that you added the property to the IgniteConfiguration, but
it's applied only within the discovery. I feel like something is wrong here.
If this feature only relates to the discovery, then we should have the
configuration property on the TcpDiscoverySpi instead. Otherwise,
Hi Val and Ilya,
Thank you for taking the time to pursue this issue.
I have raised a new PR for the discussed approach. Please see and let
me know what you think:
https://github.com/apache/ignite/pull/9048
Regards,
Atri
On Thu, Apr 22, 2021 at 3:34 PM Ilya Kasnacheev
wrote:
>
> Hello!
>
>
Hello!
I'm still not fully convinced, but Val's approach sounds rational to me.
Regards,
--
Ilya Kasnacheev
чт, 22 апр. 2021 г. в 12:45, Atri Sharma :
> Hello!
>
> I actually saw the shared container scenario being tried by somebody
> who wanted an external script to monitor all IPs being
Hello!
I actually saw the shared container scenario being tried by somebody
who wanted an external script to monitor all IPs being used by his
clusters and hence thought of this idea. Another thing that came in
was the Firewall blocking a few IP addresses, hence the idea.
I feel that the
Hello!
AFAIK, a S3 container, Azure blob container, etc, is a relatively
lightweight entity, similar to a table in an SQL database. Why would
different clusters need to share the same discovery storage container?
When I tested Azure IP finder, it created several blob containers for me on
demand,
Another thing is IP addresses blocked by firewalls -- such IPs will
cause the cluster bootstrap to slow down.
On Thu, Apr 22, 2021 at 10:20 AM Atri Sharma wrote:
>
> Hi Val,
>
> Consider a scenario where multiple Ignite clusters are running and for
> operational ease (and also compliance, in
Hi Andrey,
Thanks for the message. Yes, that is the case since I wanted to show
the functionality to the group first.
Val has made a point about an alternate approach which seems cleaner
to me, so let me explore that. If we go that route, then we will not
need to change at IPFinder level which
Hi Val,
Consider a scenario where multiple Ignite clusters are running and for
operational ease (and also compliance, in some cases, e.g. to make
auditing easier), people can configure cloud based IP finders to share
the same container (blob container in Azure, S3 container in AWS etc).
In such
Hi Atri,
You've added a new property to a base TcpDiscoveryIpFinder interface.
Actually, the only Azure IpFinder uses this setting, but the others.
This behavior may confuse the users.
Would you mind either making regexp filter setting a part of Azure IpFinder
only or fix other IpFinders as
Hi Atri,
Can you describe the scenario in a little more detail? What exactly do you
mean by a container shared by multiple clusters? What are the consequences
of this? How does the proposed solution solve the problem?
Also, I would suggest revisiting the design - I'm not sure such filtering
Hi,
When a container is shared by multiple clusters, then this can be useful
for filtering IPs.
Also, things like VPC based barriers can be circumvented using this
technique.
On Wed, 21 Apr 2021, 15:49 Ilya Kasnacheev,
wrote:
> Hello!
>
> What are the expected use cases for this feature? Can
Hello!
What are the expected use cases for this feature? Can you please elaborate?
Thanks,
--
Ilya Kasnacheev
ср, 21 апр. 2021 г. в 08:23, Atri Sharma :
> Hi All,
>
> I have opened the following JIRA for the said topic:
>
> https://issues.apache.org/jira/browse/IGNITE-14606
>
> The concept
Hi All,
I have opened the following JIRA for the said topic:
https://issues.apache.org/jira/browse/IGNITE-14606
The concept is to filter IPs based on a pattern or a blocklist in
IPFinders while consuming IPs. This is more pertinent for cloud based
IPFinders since they can have shared
Atri Sharma created IGNITE-14608:
Summary: Blocklist Based IP Filtering in IPFinders
Key: IGNITE-14608
URL: https://issues.apache.org/jira/browse/IGNITE-14608
Project: Ignite
Issue Type: Sub
17 matches
Mail list logo
