Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-07 Thread Saikat Maitra
Hi Denis, As discussed with Alexey I have captured the discussion details in confluence wiki page. I have not received any concerns or follow up questions on the release process. I can certainly pause and continue to work on current migration of existing modules if more time required for the revie

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-07 Thread Ivan Pavlukhin
Some more thoughts. I think we can try out a first release and decide if everything is ok along the way. I suppose that we should run tests with supported Ignite versions (perhaps not all) and provide results. And finally there will be a release vote. Best regards, Ivan Pavlukhin пт, 7 февр. 202

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-07 Thread Denis Magda
Folks, have we agreed on the release process? Saikat, could you point all of us to a related discussion. If my memory doesn't fail me Alex Goncharuk also wanted to step in before we do the first release. - Denis On Fri, Feb 7, 2020 at 8:02 AM Saikat Maitra wrote: > Hi Nikolay, Ivan, Denis > >

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-07 Thread Saikat Maitra
Hi Nikolay, Ivan, Denis I think we can release for spring boot autoconfigure module. I will also go ahead and make release for flink ext. I have pending PR for flume and zeromq, if I can get review and approval I can go ahead and merge and release these modules as well. Regards Saikat On Fri,

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-07 Thread Nikolay Izhikov
Thanks for clarification. Igniters, I will proceed with the release in the next few days if there is no objections on it. > 7 февр. 2020 г., в 10:57, Ivan Pavlukhin написал(а): > > Hi Nikolay, > > In fact I did not mean anything supernatural. A scheme you mentioned >> I thought we just releas

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-06 Thread Ivan Pavlukhin
Hi Nikolay, In fact I did not mean anything supernatural. A scheme you mentioned > I thought we just release module with the 1.0.0 version and specify supported > Ignite version somewhere in the documentation. sounds fine to me. Best regards, Ivan Pavlukhin чт, 6 февр. 2020 г. в 15:00, Nikolay

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-06 Thread Nikolay Izhikov
Hello, Ivan. > As usual we need to decide about versioning and a correspondence to Ignite > versions > As we are going to have a separate release cycle I can imagine an independent > versioning scheme with a range of supported Ignite versions. Please, clarify, what do you mean? Do you have any

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-06 Thread Ivan Pavlukhin
Nikolay, Thank you for driving it! It is great to establish this process in practice earlier because it seems that we need to release a Flink integration soon because Ignite 2.8 is going to be released without that integration bundled. As usual we need to decide about versioning and a corresponde

Re: [DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-05 Thread Denis Magda
Alex, did you have a chance to review Saikat’s changes related to the extensions repository organization and release approach? Denis On Wednesday, February 5, 2020, Nikolay Izhikov wrote: > Hello, Igniters. > > We don't have a release process for newly created ignite-extensions > modules. > I w

[DISCUSSION] ignite-extension - ignite-spring-boot-autoconfigurer release.

2020-02-05 Thread Nikolay Izhikov
Hello, Igniters. We don't have a release process for newly created ignite-extensions modules. I want to release two modules: * ignite-spring-boot-autoconfigure * ignite-client-spring-boot-autoconfigure Let's discuss it. Any objections to it? What should be done before release?

Re: Ignite-spring-boot-autoconfigurer

2020-01-28 Thread Saikat Maitra
Hi Nikolay, Here is the release process docs for Ignite [1] We do not have docs specific to Ignite Extensions, we will need to create docs for Ignite Extensions. Please find discussion on release process below [2] Regards, Saikat [1] https://cwiki.apache.org/confluence/display/IGNITE/Release+

Re: Ignite-spring-boot-autoconfigurer

2020-01-28 Thread Nikolay Izhikov
Merged to master [1] Igniters, I want to release both modules I added. Do we have documentation, how it should be done for ignite-extensions? [1] https://github.com/apache/ignite-extensions/commit/575ec510e4d48b1e0c2ec7e4cf8d596e7de82f70 пн, 27 янв. 2020 г. в 13:06, Nikolay Izhikov : > Hello, A

Re: Ignite-spring-boot-autoconfigurer

2020-01-27 Thread Nikolay Izhikov
Hello, Alexey Kuznetsov. I have two approvals from Saikat Maitra and Maxim Stepachov. I have plans to merge spring-boot autoconfigure modules to ignite-extensions. [1] Do you want to perform additional review? [1] https://github.com/apache/ignite-extensions/pull/6 пт, 24 янв. 2020 г. в 07:41, Sa

Re: Ignite-spring-boot-autoconfigurer

2020-01-23 Thread Saikat Maitra
Hi Nikolay, Thank you for updating the PR, the changes looks good. Regards, Saikat On Wed, Jan 22, 2020 at 1:33 PM Николай Ижиков wrote: > Hello, Saikat. > > Thank you so much for the review. > > I answered your questions and resolve all the comments. > Please, take a look, one more time. > >

Re: Ignite-spring-boot-autoconfigurer

2020-01-22 Thread Николай Ижиков
Hello, Saikat. Thank you so much for the review. I answered your questions and resolve all the comments. Please, take a look, one more time. > 22 янв. 2020 г., в 07:58, Saikat Maitra написал(а): > > Hi Nikolay, > > I have reviewed the PR and shared comments. > > Please let me know if you hav

Re: Ignite-spring-boot-autoconfigurer

2020-01-21 Thread Saikat Maitra
Hi Nikolay, I have reviewed the PR and shared comments. Please let me know if you have any feedback. Regards, Saikat On Mon, Jan 20, 2020 at 2:42 PM Николай Ижиков wrote: > Hello, Saikat. > > Thanks, for feedback. > > I raised a PR [1] to `ignite-extensions`. > > You can find description of t

Re: Ignite-spring-boot-autoconfigurer

2020-01-20 Thread Николай Ижиков
Hello, Saikat. Thanks, for feedback. I raised a PR [1] to `ignite-extensions`. You can find description of the new module below(examples can be found at [2]): Module provides the ability to integrate `Ignite` into you spring-boot application with zero(or minimal) configuration. After you add

Re: Ignite-spring-boot-autoconfigurer

2020-01-17 Thread Saikat Maitra
Hi Nikolay, Thank you for your email. As part of Ignite Extensions migration we are migrating Ignite Extensions to following repo. https://github.com/apache/ignite-extensions We have added flink and pub-sub modules and few additional modules are open in PR. You can refer to this PR to see how w

Re: Ignite-spring-boot-autoconfigurer

2020-01-17 Thread Николай Ижиков
Tests added. Please, review. Saikat, can you help with this PR [1]? I think it should be added as a separate module as we do with the flink integration. Can you help me with it? Do we have some how-to for it? [1] https://github.com/apache/ignite/pull/7237 > 16 янв. 2020 г., в 16:51, Николай Иж

Re: Ignite-spring-boot-autoconfigurer

2020-01-16 Thread Николай Ижиков
Hello, Denis. Thanks, for the feedback. Alexey, it seems, PR is ready to be reviewed, but I need some time(a day or two) to write tests. You can start with the core code review if you wish. Here are autoconfigurer requirements: 1. Start usage of Ignite with minimal(or zero) configuration. 2. C

Re: Ignite-spring-boot-autoconfigurer

2020-01-14 Thread Denis Magda
Nikolay, Thanks for contributing in this direction! That's one of the gaps on our end and the user community will be certainly thankful once we fill it in. *Alexey Kuznetsov*, as one of the Spring Boot experts, could you spend some time reviewing the changes? As for the extensions/modularization

Ignite-spring-boot-autoconfigurer

2020-01-11 Thread Николай Ижиков
Hello, Igniters. During Ignite meetup I took part in there was a request from the users. They propose to create a custom spring boot autoconfigurer module for Ignite. This module should provide a smooth injection of Ignite to any spring-boot application. I've implemented a tiny straightforward p