Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-17 Thread Ivan Pavlukhin
I updated javadoc TC job [1]. Completes successfully on master so far. [1] https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_Javadoc?branch=%3Cdefault%3E=overview=builds Best regards, Ivan Pavlukhin пт, 14 февр. 2020 г. в 16:23, Ivan Pavlukhin : > > I merged changes for [1] to

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-14 Thread Ivan Pavlukhin
I merged changes for [1] to master. Next steps will be updating TC javadoc to fail on a string "Javadoc Warnings" [1] https://issues.apache.org/jira/browse/IGNITE-12644 Best regards, Ivan Pavlukhin сб, 8 февр. 2020 г. в 21:03, Ivan Pavlukhin : > > I created a ticket [1] and PR [2]. Please

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-08 Thread Ivan Pavlukhin
I created a ticket [1] and PR [2]. Please review. [1] https://issues.apache.org/jira/browse/IGNITE-12644 [2] https://github.com/apache/ignite/pull/7356 Best regards, Ivan Pavlukhin вт, 4 февр. 2020 г. в 17:51, Ivan Pavlukhin : > > The next bit I found out is that links like >

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-04 Thread Ivan Pavlukhin
The next bit I found out is that links like "https://hadoop.apache.org/docs/current/api/" are needed to have working links to external classes in javadocs (e.g. Hadoop ones). Unfortunately, we are not consistent with external links. E.g. references to JCache classes are rendered as plain text in

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-04 Thread Ivan Pavlukhin
Alexey, Thank you for the hint. Actually my bet was the same. But currently I have no understanding how "https://hadoop.apache.org/docs/current/api/" tag is used and is it used at all. вт, 4 февр. 2020 г. в 15:01, Alexey Goncharuk : > > Ivan, > > My guess would be that the link was included for

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-04 Thread Alexey Goncharuk
Ivan, My guess would be that the link was included for the Hadoop Accelerator which we all agreed to remove [1]. I think it is safe to remove it from pom.xml completely. [1]

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-02-04 Thread Ivan Pavlukhin
I continued my experiments with javadocs and a next hurdle was an external link to Hadoop documentation https://hadoop.apache.org/docs/current/api/ . Javadoc build job scans logs for javadoc-specific warnings and it founds any it fails build. But there were many failures in the past in a form:

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-24 Thread Ivan Pavlukhin
Actually, I got stuck with a question what do modules like ignite-hibernate mean from a javadoc standpoint. It seems that modules sharing same packages and classes cannot be aggregated into valid javadoc bundle. And actually this problem should be solved as well (modularization?). But I suppose

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-24 Thread Maxim Muzafarov
Folks, It's true that my simple assumption (to include Javadoc profile) will not work by reasons mentioned by Petr. I've tested it under a new experimental suite [1] which I've created earlier. We will always have such warnings due to we have multiple modules with the same package declarations

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-24 Thread Ivan Pavlukhin
Petr, Thank you for that detail! Unfortunately I do not know how to fix it easily. Also I found that even without "javadoc" profile we miss some javadoc problems. I believe that it can be fixed by updating post-build javadoc checking condition. See below what problems do we miss (and there are a

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-24 Thread Petr Ivanov
We could not because of multiple hibernate modules, what is considered from the javadoc's point as warning, that always fails test. > On 24 Jan 2020, at 11:02, Ivan Pavlukhin wrote: > > Maxim, > > I suppose we can try to enable "javadoc" profile for a corresponding > job. Are there any

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-24 Thread Ivan Pavlukhin
Maxim, I suppose we can try to enable "javadoc" profile for a corresponding job. Are there any objections to do so? пн, 20 янв. 2020 г. в 13:25, Ivan Pavlukhin : > > Maxim, > > From the first glance it seems that "javadoc" profile was really > missed. Are there any other problems except

Re: JAVADOC fails on local build. Should it be checked on TC?

2020-01-20 Thread Ivan Pavlukhin
Maxim, >From the first glance it seems that "javadoc" profile was really missed. Are there any other problems except springdata22? If no then we can add the profile. Also it is interesting how it influence on execution time? пн, 13 янв. 2020 г. в 16:53, Maxim Muzafarov : > > Igniters, > > > I've

JAVADOC fails on local build. Should it be checked on TC?

2020-01-13 Thread Maxim Muzafarov
Igniters, I've run locally maven command according to DEVNOTES: mvn initialize -Pjavadoc and it fails due to: 'Other Packages' section should not be present, all packages should have corresponding documentation groups. The reason of that is a newly added `org.apache.ignite.springdata22`