Re: Lets add measure units for metrics

2019-11-07 Thread Andrey Gura
Stephen, All metrics will be local for node. Cluster wide metric is some aggregation which could and must be done by special tools not Ignite. We already have dozen cluster wide but meaningless metrics and a lot of code for aggregation. It just isn't our job. All cluster wide metrics will be remo

Re: Lets add measure units for metrics

2019-11-07 Thread Andrey Gura
> Yes, we can have measurement units in description, but external tool will be forced to parse textual representation of units. We do not know anything about that tools. What kind of units they support? What kind of actions can be done with measurement on the external tool side? We can only guess

Re: Lets add measure units for metrics

2019-11-06 Thread Stephen Darlington
Another thing that I would like to see in the metrics is the scope: is this metric cluster-wide or only for this node? Like the units of measure, this could be an extra field. Or it could be naming convention? (Currently many node-specific metrics have “local” in the name, but this is not entir

Re: Lets add measure units for metrics

2019-11-06 Thread Alexey Kuznetsov
Andrey, The main reason of separate field - is a simplicity of usage in tools. Yes, we can have measurement units in description, but external tool will be forced to parse textual representation of units. Description is a text that has no special format and how we can ask developers to not forget

Re: Lets add measure units for metrics

2019-11-06 Thread Andrey Gura
Units just can be added to a metric description. What is the purpose of dedicated field for it? We doesn't provide any API for work with measurement units and should not do it. Metrics interpretation is responsibility of external systems for metrics gathering. Enum with metrics measurement doesn't

Re: Lets add measure units for metrics

2019-11-06 Thread Nikolay Izhikov
Hello, Alexey. I'm +1. Let's do it. В Ср, 06/11/2019 в 16:37 +0700, Alexey Kuznetsov пишет: > Hi, All! > > I'm working on a tool for metrics monitoring. > And found that Metric interface [1] has a name and description, but has not > measurement units. > > When you are working on a tool that col

Lets add measure units for metrics

2019-11-06 Thread Alexey Kuznetsov
Hi, All! I'm working on a tool for metrics monitoring. And found that Metric interface [1] has a name and description, but has not measurement units. When you are working on a tool that collects all metrics and shows it in human readable format it is a very important piece of information. Becaus