Re: Any reason to keep ClientConfiguration final?

2020-08-25 Thread Michael Pollind
micronaut setups the configuration at compile time. so a lot of the configuration is through annotating classes. There are two main methods for this ConfigurationProperties/ConfigurationBuilder. ConfigurationBuilder maps properties to a factor and ConfigurationProperties maps properties onto a

Re: Any reason to keep ClientConfiguration final?

2020-08-24 Thread Igor Sapego
No objections from my side. What is the case? Some kind of new thin client? Best Regards, Igor On Mon, Aug 24, 2020 at 11:40 PM Pavel Tupitsyn wrote: > Denis, > > No objections to the removal of the "final" modifier from my side. > However, the use case sounds a bit weird to me, can you

Re: Any reason to keep ClientConfiguration final?

2020-08-24 Thread Pavel Tupitsyn
Denis, No objections to the removal of the "final" modifier from my side. However, the use case sounds a bit weird to me, can you please describe it in more detail? Thanks, Pavel On Mon, Aug 24, 2020 at 10:47 PM Denis Magda wrote: > @Pavel Tupitsyn , @Igor Sapego , > > Michael has been