Re: Code duplicates in ssh tests

2018-07-20 Thread Dmitry Pavlov
Ok, I agree here, that we can remove one test. Feel free to create an issue and PR if nobody else mind. Let us wait at least until Mon 23 Jul before merge. пт, 20 июл. 2018 г. в 17:57, Иван Федотов : > Hi, Dmitry. > > I thought about elements order, but if we go deeper in > ignite.cluster().stopN

Re: Code duplicates in ssh tests

2018-07-20 Thread Иван Федотов
Hi, Dmitry. I thought about elements order, but if we go deeper in ignite.cluster().stopNodes() method, we can see that in ClusterIgniteImpl [1] all nodes id will be collected in HashSet in forNodesIds method [2]. So I think that in this case it's not important what use initially, HashSet or Arr

Re: Code duplicates in ssh tests

2018-07-20 Thread Dmitry Pavlov
Hi Ivan, I can suppose that it is related to elements order. Is it reasonable to keep 2 tests with 1 common mehod? One test will call this method with HashSet, and other with ArrayList. Sincerely, Dmitriy Pavlov пт, 20 июл. 2018 г. в 15:01, Иван Федотов : > Hi, Igniters! > > I’m working on ssh