Re: Please help to do the code review for those newbie PR

Hi Alexey, yes, just as you said, if the node start with client mode cfg.setClientMode(true); Then the case will fail, I have implemented the method as you advised. please help to review the PR Thanks, kcheng On Tue, Sep 1, 2015 at 9:51 AM, Alexey Goncharuk

Re: Please help to do the code review for those newbie PR

Hi Ken, I was just in process of reviewing them :) Please give me couple more hours and I will provide feedback. -Val On Mon, Aug 31, 2015 at 6:47 PM, Ken Cheng wrote: > Hi Valentin Kulichenko* & *Alexey Kuznetsov > > Can you help to do the code review for the newbie

Re: Please help to do the code review for those newbie PR

Ken, I have also provided some feedback regarding the IGNTIE-1226 ticket (sorry it took a long time to respond to your previous email). 2015-08-31 18:48 GMT-07:00 Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Hi Ken, > > I was just in process of reviewing them :) Please give me couple

Re: Please help to do the code review for those newbie PR

Ken, I left a comment in https://github.com/apache/ignite/pull/44/. Please take a look. Thanks! -Val On Mon, Aug 31, 2015 at 6:51 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Ken, > > I have also provided some feedback regarding the IGNTIE-1226 ticket (sorry > it took a long