Re: Problem with reading incomplete payload - IGNITE-7153

2019-01-10 Thread Ilya Kasnacheev
Hello! I don't see why we can't. Just take it over, run tests, move to PA, etc. Regards, -- Ilya Kasnacheev чт, 3 янв. 2019 г. в 17:00, Dmitriy Pavlov : > Hi Igniters, > > I'm trying to reach the author of the fix because the ticket is still in In > Progress. > > Could you please advice me

Re: Problem with reading incomplete payload - IGNITE-7153

2019-01-03 Thread Dmitriy Pavlov
Hi Igniters, I'm trying to reach the author of the fix because the ticket is still in In Progress. Could you please advice me how to handle it (because fix seems to be useful)? Can we set Patch Available status by lazy consensus and review possibly incomplete fix?

Re: Problem with reading incomplete payload - IGNITE-7153

2018-11-02 Thread Michael Fong
Hi Yakov, Thanks so much for your analysis. Parser expects chunks to be complete and has all the data to read entire > message, but this is not guaranteed and single message can arrive in > several chunks. This is indeed the the assumption to my implementation. I have not come up a another

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-31 Thread Yakov Zhdanov
Hi Mike! Thanks for reproducer. Now I understand the problem. NIO worker reads chunks from the network and notifies the parser on data read. Parser expects chunks to be complete and has all the data to read entire message, but this is not guaranteed and single message can arrive in several

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-31 Thread Michael Fong
Hi, I have successfully emulated a the packets to Ignite via pure Socket connection per your request. Please let me know if this could help locate the root cause of the problem. Thank you. Regards. public void testSendingRawRedisSocket() throws Exception { Socket socket = new Socket();

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-30 Thread Michael Fong
Hi Yakov, Thanks for your reply. :) Please allow me to explain the whole situation and how to reproduce the problem: In the PR of IGNITE-7153, I added a test case under RedisProtocolConnectSelfTest, sending some binary data via Jedis client, large enough (> 8192 bytes) to reproduce the original

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-30 Thread Yakov Zhdanov
Michael, can you please share a reproducer? Is it possible to snapshot a packet that causes the error and just emulate packet send with manually opened socket bypassing Redis client lib? --Yakov

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-29 Thread Michael Fong
bump :) On Fri, Oct 26, 2018 at 4:00 PM Michael Fong wrote: > Hi, > > Thanks for your reply. I think current implementation (based on R2.6) does > exactly what you mentioned as of in GridNioServer >

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-26 Thread Michael Fong
Hi, Thanks for your reply. I think current implementation (based on R2.6) does exactly what you mentioned as of in GridNioServer . The problem is that in redis

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-25 Thread Jörn Franke
I have not checked the exact routine, but you need to reexecute read until it returns -1 or if known that all bytes that are expected have been read (if sockCh is based on some kind of input stream) > Am 26.10.2018 um 04:24 schrieb Michael Fong : > > Bump! > > Anyone who could help me solve

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-25 Thread Michael Fong
Bump! Anyone who could help me solve this random issue? Thanks! Regards, Michael On Wed, Oct 24, 2018 at 10:32 PM Michael Fong wrote: > Hi, all, > > > I was trying to fix IGNITE-7153 which relates to parsing incomplete REDIS > packet larger than 8192 bytes. However, I found a random