Re: Review Requested -- IGNITE-15077

2021-07-29 Thread Ilya Kasnacheev
Hello! We now have 2 schedulers under the hood, whereas the optimal number is zero. I would very like to see a commit where the whole ignite-schedule package is sunsetted. With prior discussion on dev list, of course. I don't see the value of having local scheduling as part of Apache Ignite at

Re: Review Requested -- IGNITE-15077

2021-07-29 Thread Andrey Mashenkov
Atri. I think Ilya means IgniteCombinedSchedulerProcessor that delegates calls to 2 different Scheduler implementations. And the logic may not be enough clear for a user. 1. You added a new mandatory dependency on Quartz. We are trying to avoid this as much as possible, because this may lead to

Re: Review Requested -- IGNITE-15077

2021-07-29 Thread Atri Sharma
Hi Ilya, Following up on this please. On Tue, 27 Jul 2021, 22:20 Atri Sharma, wrote: > Hi Ilya, > > > > Frankly speaking, I do not see the value of having an extra layer of > > indirection around *local* Quartz-based scheduler in Ignite. Can you > > elaborate? > > I didnt quite understand

Re: Review Requested -- IGNITE-15077

2021-07-27 Thread Atri Sharma
Hi Ilya, > Frankly speaking, I do not see the value of having an extra layer of > indirection around *local* Quartz-based scheduler in Ignite. Can you > elaborate? I didnt quite understand that. Are you referring to the IgniteCombinedSchedulerProcessor? > > Our guidelines also recommend having

Re: Review Requested -- IGNITE-15077

2021-07-27 Thread Ilya Kasnacheev
Hello! Frankly speaking, I do not see the value of having an extra layer of indirection around *local* Quartz-based scheduler in Ignite. Can you elaborate? Our guidelines also recommend having issue description to document the whys and hows, and not just issue title. Regards, -- Ilya