Re: Shutdown policy refactoring

2022-10-31 Thread Aleksandr Polovtsev
Thank you, Stan, for the detailed feedback. I totally agree with the "dimensions" stuff, I think that's what I tried to describe in the original proposal. I still think that we can get away with a single enum, because it at least covers the current use cases. In any case, it will be safe to add mo

Re: Shutdown policy refactoring

2022-10-30 Thread Stanislav Lukyanov
Hi Aleksandr, Thanks for driving this. Someone should put a stop to the shutdown behavior nonsense :) But let me complicate things a bit for you. I see multiple dimensions that are in play when node shutdown happens: - Running operations (Compute, SQL, Cache): interrupt or wait for completion

Re: Shutdown policy refactoring

2022-10-25 Thread Aleksandr Polovtsev
Guys, any more feedback? On Tue, Oct 18, 2022 at 12:42 PM Aleksandr Polovtsev < alexpolovt...@gmail.com> wrote: > My guess is that it reduces the node shutdown time. We may want to keep it > for compatibility purposes, because I'm afraid that changing the default > behaviour is not that easy. > >

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
My guess is that it reduces the node shutdown time. We may want to keep it for compatibility purposes, because I'm afraid that changing the default behaviour is not that easy. On Tue, Oct 18, 2022 at 12:32 PM Николай Ижиков wrote: > So why it’s default behavior? > And why we want keep it? > > >

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
So why it’s default behavior? And why we want keep it? > 18 окт. 2022 г., в 12:27, Aleksandr Polovtsev > написал(а): > > But this is the default behaviour right now, do you mean we should change > it? I'm ok with that if it will not break something > > On Tue, Oct 18, 2022 at 12:13 PM Николай

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
But this is the default behaviour right now, do you mean we should change it? I'm ok with that if it will not break something On Tue, Oct 18, 2022 at 12:13 PM Николай Ижиков wrote: > > I don't know what most people use in the real world, maybe more > experienced guys can clarify that. > > My que

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
> I don't know what most people use in the real world, maybe more experienced > guys can clarify that. My question is different. Why we may want to provide cancel=true? Is there any reason to support this in Ignite? > 18 окт. 2022 г., в 11:47, Aleksandr Polovtsev > написал(а): > > Thank you

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
Thank you for the response, Nikolay. As I can see, this is the default behaviour now (ShutdownPolicy = IMMEDIATE, cancel = true). I don't know what most people use in the real world, maybe more experienced guys can clarify that. On Tue, Oct 18, 2022 at 11:15 AM Николай Ижиков wrote: > Hello, > >

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
Hello, Why do we need «immediate»? Is there real-world scenarios for it? Can we do graceful or «save all possible data» shutdown always? > 18 окт. 2022 г., в 10:59, Aleksandr Polovtsev > написал(а): > > Hello, dear Igniters! > > I'd like to propose a refactoring of the current Shutdown Pol