Re: ignite-3682 - GridFunc: move all inner anonymous classes to separate top-level classes.

2017-04-14 Thread Andrey Gura
Vyacheslav, all three viewReadOnly methods have many usages. And yes, some methods/classes were removed from GridFunc during other tasks. On Wed, Apr 12, 2017 at 7:24 PM, Vyacheslav Daradur wrote: > Andrey, > > I see you've merged it before I fixed merge conflict and you

Re: ignite-3682 - GridFunc: move all inner anonymous classes to separate top-level classes.

2017-04-12 Thread Vyacheslav Daradur
Andrey, I see you've merged it before I fixed merge conflict and you fixed it yourself, thank you) There is one more unused method: public static Map viewReadOnly You can see it in my fixed version: https://github.com/apache/ignite/pull/1652/files

Re: ignite-3682 - GridFunc: move all inner anonymous classes to separate top-level classes.

2017-04-12 Thread Andrey Gura
Vyacheslav, thank you for contribution! Your changes are merged into master branch. On Mon, Mar 20, 2017 at 1:11 PM, Vyacheslav Daradur wrote: > I've received answers in the issue. > > Ready for review. > > 2017-03-16 10:14 GMT+03:00 Vyacheslav Daradur

Re: ignite-3682 - GridFunc: move all inner anonymous classes to separate top-level classes.

2017-03-20 Thread Vyacheslav Daradur
I've received answers in the issue. Ready for review. 2017-03-16 10:14 GMT+03:00 Vyacheslav Daradur : > Hello everyone. > > I have some questions about the issue https://issues.apache. > org/jira/browse/IGNITE-3682 > > 1) Can I do some minor refactoring of GridFunc class