Re: Thin Client examples for documentation

2018-01-12 Thread Denis Magda
> We need to make sure the spec is correct, so someone else (not me) has to > follow the spec, write code and see if it works. > It helps finding issues like missing 27 code, etc. Exactly, Pavel! We’re on the same page here. Thanks for the help and responsiveness. — Denis > On Jan 12, 2018, at

Re: Thin Client examples for documentation

2018-01-12 Thread Pavel Tupitsyn
Hi Prachi, I've forked your repo, my changes are there: https://github.com/ptupitsyn/ignite-examples/blob/fix/src/main/java/ignite/myexamples/thinclient/ThinClientExample2.java * getOrCreateCache fixed * 27: documentation updated, I've forgot about wrapped complex objects * Common readBinaryObjec

Re: Thin Client examples for documentation

2018-01-11 Thread Prachi Garg
Pavel, I don't see any attachment. Can you please resend. -P On Thu, Jan 11, 2018 at 7:36 AM, Pavel Tupitsyn wrote: > Hi Prachi, > > I've fixed cache creation method for you, see attachment. I did not fix > anything else. > Sorry, but this kind of code with hardcoded message lengths, operation

Re: Thin Client examples for documentation

2018-01-11 Thread Denis Magda
Please share a link. These tests still use Ignite predefined types as SqlQuery, SqlFields query and other existing Ignite APIs: https://github.com/apache/ignite/tree/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Client/Cache I’m looking for test that will 100% correspond to what Prachi

Re: Thin Client examples for documentation

2018-01-11 Thread Pavel Tupitsyn
Denis, Thin client protocol is fully covered by .NET Thin Client tests. Each and every operation is tested. On Thu, Jan 11, 2018 at 6:36 PM, Pavel Tupitsyn wrote: > Hi Prachi, > > I've fixed cache creation method for you, see attachment. I did not fix > anything else. > Sorry, but this kind of

Re: Thin Client examples for documentation

2018-01-11 Thread Pavel Tupitsyn
Hi Prachi, I've fixed cache creation method for you, see attachment. I did not fix anything else. Sorry, but this kind of code with hardcoded message lengths, operation codes, etc is very hard to work with. Hardcoded values may be useful for trivial operations so that users get an idea of the prot

Re: Thin Client examples for documentation

2018-01-10 Thread Denis Magda
Pavel, as a side note, The methods/operations Prachi is struggling with look pretty standard to me. Do you have tests for them in the code base? I mean *not* the tests you shared before where we use existing internal binary marshaller APIs but where we code every operation from scratch (what Pr

Thin Client examples for documentation

2018-01-10 Thread Prachi Garg
Pavel, I am having trouble creating examples for some of the thin protocol operations. I have uploaded my project on github - https://github.com/pgarg/ignite-examples/blob/master/src/main/java/ignite/myexamples/thinclient/ThinClientExample2.java Please look into the following methods and provide