Re: Unused argument in DirectMessageWriter

2017-03-17 Thread Александр Меньшиков
Valentin, thank you. Aleksey, yeah :-) 2017-03-16 15:51 GMT+03:00 ALEKSEY KUZNETSOV : > watch him, he is gonna remove all the messages he doesn't like :) > > чт, 16 мар. 2017 г. в 14:56, Valentin Kulichenko < > valentin.kuliche...@gmail.com>: > > > Hi, > > > > These classes are part of plugin fr

Re: Unused argument in DirectMessageWriter

2017-03-16 Thread ALEKSEY KUZNETSOV
watch him, he is gonna remove all the messages he doesn't like :) чт, 16 мар. 2017 г. в 14:56, Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Hi, > > These classes are part of plugin framework. Even though 'name' argument is > not used by Ignite implementations, it can be used by others.

Re: Unused argument in DirectMessageWriter

2017-03-16 Thread Valentin Kulichenko
Hi, These classes are part of plugin framework. Even though 'name' argument is not used by Ignite implementations, it can be used by others. Therefore it should not be removed. -Val On Thu, Mar 16, 2017 at 10:36 AM, Александр Меньшиков wrote: > Hello, everyone! > > I found some strange thing.

Unused argument in DirectMessageWriter

2017-03-16 Thread Александр Меньшиков
Hello, everyone! I found some strange thing. In 'MessageWriter' there are a lot of methods like 'write*(String name, * val)'. But in implementation 'DirectMessageWriter' argument 'name' isn't used in these methods. And there aren't other 'MessageWriter' implementations. Maybe we can remove 'name'