Hi. Igniters!
I create two PR [1,2] for two issues: IGNITE-9165 (close streams) [3] and
IGNITE-9160 (fix equals methods) [4]. Can you please review it? The changes
are quite small, tests are ok, flacky as usual.
[1] https://github.com/apache/ignite/pull/4481
[2] https://github.com/apache/ignite/p
presence of similar problems.
Found bugs added to issues.
In the future, it is planned to expand the list, so the issues were tagged
with the FindBugs tag for easy navigation. It is also necessary to check the
remaining modules.
[1]
http://apache-ignite-developers.2346864.n4.nabble.com/find-bugs-code
Hi Maxim, Evgeniy,
Thank you for researching and finding these issues.
Who could create tickets (probably, newbie) so newcomers can pick up and
fix it?
Sincerely,
Dmitriy Pavlov
ср, 1 авг. 2018 г. в 11:36, Maxim Muzafarov :
> Hello,
>
> I can be wrong, but looks like -
>
> `GridIoManager` not
Hello,
I can be wrong, but looks like -
`GridIoManager` not a bug, we are checking isEmpty here.
`GridCacheLockImpl` not a bug, variable is volatile.
Suppose, null-check not too critial for these classes, but can be done.
`GridTuple6` - must be fixed.
`GridClientJdkMarshaller` - should be fixe
hi, igniters.
I take a little time to analyze findbugs http://findbugs.sourceforge.net/
output from ignite-core module.
There is summary of suspicious messages:
GridIoManager
sync on conc map:
synchronized (map) {
rmv = map.remove(set.nodeId(), set);
}
---
GridCacheLockImpl
read
