Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-04-04 Thread Vyacheslav Daradur
Guys, any thoughts? I'm ready to improve quickly the solution according to yours notes to include this in the Ignite-2.0. 2017-03-31 12:30 GMT+03:00 Vyacheslav Daradur : > Hello everyone. > > I have prepared the raw evaluation (marshaller layer) of compression. > (GZIP implementation) > https://

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-31 Thread Vyacheslav Daradur
Hello everyone. I have prepared the raw evaluation (marshaller layer) of compression. (GZIP implementation) https://github.com/daradurvs/ignite-compression/tree/master/src/main/resources/result In plans for evaluation: 1. Deflater compressor implementation; 2. Snappy compressor implementation; 3.

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Denis Magda
Sergi, Vovan, As SQL and binary marshaller maintainers could you plan to review the contribution? — Denis > On Mar 29, 2017, at 4:44 PM, Vyacheslav Daradur wrote: > >> At which point does this step take place? Do we deserialize right when we >> receive the object over the wire? > When put it

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Vyacheslav Daradur
> At which point does this step take place? Do we deserialize right when we > receive the object over the wire? When put it in cache, after marshalling. Covered by properly configured existing tests. [1][2][3] > Forgive me if I don't know the internals, but does this happen when SQL > queries are

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Dmitriy Setrakyan
On Wed, Mar 29, 2017 at 11:57 AM, Vyacheslav Daradur wrote: > Queries works with BinaryObjectImpl. > > 1. In the full compression mode - compressed bytes sequence - will be > decompressed at initialization of BinaryObjectImpl. > At which point does this step take place? Do we deserialize right w

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Vyacheslav Daradur
Queries works with BinaryObjectImpl. 1. In the full compression mode - compressed bytes sequence - will be decompressed at initialization of BinaryObjectImpl. 2. With annotated fields compression - value of compressed fields will be decompress at deserializing on demand, for example when calls me

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Dmitriy Setrakyan
On Wed, Mar 29, 2017 at 11:44 AM, Vyacheslav Daradur wrote: > Solution implemented in core-level and works with binary-marshaller. > > If you about the cache queries - it works with compressed data. > Vyacheslav, can you please explain how the cache queries work with the compressed data?

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Vyacheslav Daradur
Solution implemented in core-level and works with binary-marshaller. If you about the cache queries - it works with compressed data. 2017-03-29 21:42 GMT+03:00 Dmitriy Setrakyan : > On Wed, Mar 29, 2017 at 10:56 AM, Denis Magda wrote: > > > Hello Vyacheslav, thanks for your efforts. > > > > Is

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Dmitriy Setrakyan
On Wed, Mar 29, 2017 at 10:56 AM, Denis Magda wrote: > Hello Vyacheslav, thanks for your efforts. > > Is there any special support for SQL? In the original discussion [1] > around this task the folks expressed several concerns about compression > usefulness w/o the ability to execute SQL queries

Re: ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Denis Magda
Hello Vyacheslav, thanks for your efforts. Is there any special support for SQL? In the original discussion [1] around this task the folks expressed several concerns about compression usefulness w/o the ability to execute SQL queries over compressed data. In general it makes sense to run the di

ignite-3592 is ready fo review (Provide some kind of pluggable compression SPI support)

2017-03-29 Thread Vyacheslav Daradur
Hello everyone. https://issues.apache.org/jira/browse/IGNITE-3592 is ready for review. ci.tests [1] look good. Upsource review was created.[2] Solution provides 2 way to use compression. 1. Full compression mode. Switches in the IgniteConfiguration#fullCompressionMode field. Full compression mean