Re: Atomic caches

[Yakov Zhdanov]

Dmitry, I think Anton meant AtomicsConfiguration, not atomic caches.
However, I would make sure we validate all conf parameters.

Anton, can you please share junit test that shows the problem?

Yakov Zhdanov

сб, 7 апр. 2018 г., 6:12 Dmitriy Setrakyan :

> I would say absolutely YES - we need to have configuration validation.
>
> Igniters, why was the validation skipped in atomic caches?
>
> D.
>
> On Fri, Apr 6, 2018 at 1:43 PM, akurbanov  wrote:
>
> > Hello Igniters,
> >
> > I want to address a question on AtomicConfiguration validation. I've
> tested
> > in ignite-1.8 branch that it is impossible to start two nodes with
> > different
> > AtomicConfiguration parameters e.g. different cache modes or numbers of
> > backups are provided.
> > JIRA link: https://issues.apache.org/jira/browse/IGNITE-2096
> >
> > In ignite-2.4 AtomicConfiguration validation is completely skipped on
> node
> > startup and this issue is non-reproducible. Node with alternative
> > configuration successfully joins, but this configuration is being
> > completely
> > ignored, all created atomics will reference the same initial
> configuration
> > and belong to the same cache "ignite-sys-atomic-cache@default-ds-group",
> > even if configuration is provided in constructor.
> >
> > Do we need any kind of validation for this configuration?
> > Would it be correct to use the same approach for atomic types instances
> > caching as used for IgniteQueue/IgniteSet, cache for each unique
> > configuration?
> >
> > Best regards,
> > Anton Kurbanov
> >
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi Nikolay,
I fixed the comments. Please check them and let me know.

Thanks,
Amir

On Thu, Apr 5, 2018 at 12:30 AM, Nikolay Izhikov 
wrote:

> Hello, Amir.
>
> Please, see my jira comment - https://issues.apache.org/
> jira/browse/IGNITE-3999?focusedCommentId=16426473=com.atlassian.jira.
> plugin.system.issuetabpanels:comment-tabpanel#comment-16426473
>
> В Ср, 04/04/2018 в 20:16 -0400, Amir Akhmedov пишет:
> > Hi Nikolay,
> >
> > Just a gentle reminder :)
> >
> > Thanks,
> > Amir
> >
> > On Fri, Mar 30, 2018 at 12:29 PM, Nikolay Izhikov 
> > wrote:
> >
> > > I will take a look at the next week.
> > >
> > > В Пт, 23/03/2018 в 09:50 +0700, Alexey Kuznetsov пишет:
> > > > Vladimir,
> > > >
> > > > As SQL expert, could you review this PR?
> > > >
> > > > In this PR QueryEntity.java was changed. And it may impact whole SQL
> > >
> > > engine.
> > > >
>