Re: method arguments code style

2018-05-08 Thread Dmitry Pavlov
Hi Vyacheslav, Can we proceed with plugin publishing? I have not seen any objections, so I propose to complete this task. Sincerely, Dmitriy Pavlov вт, 8 мая 2018 г. в 21:47, Vyacheslav Daradur : > Hi, Igniters! > > After the completion of publishing abbr-plugin [1][2] we

[GitHub] ignite pull request #3639: IGNITE-7608

2018-05-08 Thread SomeFire
Github user SomeFire closed the pull request at: https://github.com/apache/ignite/pull/3639 ---

Re: method arguments code style

2018-05-08 Thread Vyacheslav Daradur
Hi, Igniters! After the completion of publishing abbr-plugin [1][2] we will be able to automate checking of method arguments code style. It will be easy to check rules approved by the community during writing code. [1] https://issues.apache.org/jira/browse/IGNITE-5698 [2]

Re: Service grid redesign

2018-05-08 Thread Vyacheslav Daradur
Thanks, Denis! I assigned the task to myself. I going to start work next week. On Tue, May 8, 2018 at 7:50 PM, Denis Mekhanikov wrote: > Hi Vyacheslav! > > Thanks for the enthusiasm! > The first ticket to be implemented here is IGNITE-8361 >

Re: missing website info

2018-05-08 Thread Dmitriy Setrakyan
On Tue, May 8, 2018 at 6:23 PM, Denis Magda wrote: > Dmitriy, > > Presently this information is scattered and presented under sections named > differently. Agree with the format proposed by you. > https://issues.apache.org/jira/browse/IGNITE-8455 > > In addition, we should

need review for PR

2018-05-08 Thread Igor Rudyak
Hi guys, Appreciate if somebody can do a review for the PR: https://github.com/apache/ignite/pull/3940 Igor

Where is ICache.Removex() in .Net client?

2018-05-08 Thread Raymond Wilson
I have some code the removes elements from a cache, and I’d like to improve its performance. The help for ICache.Remove() states that the element removed will be returned to the call, and that if the element is not required, then Removex() should be used to avoid the overhead of returning the

Re: IGNITE-3999 review

2018-05-08 Thread Vladimir Ozerov
Hi, I provided my comments in the ticket. On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov wrote: > Hi Nikolay, Dmitry Pavlov, > Can you take a look at this PR or maybe you have an idea when it probably > can be reviewed? > > Thanks, > Amir > > On Wed, Apr 11, 2018 at

Re: Ticket review checklist

2018-05-08 Thread Александр Меньшиков
Vladimir, the 3.1 is a bit unclear for me. Which code coverage is acceptable? Now it sounds like two tests are enough (one for positive and one for negative cases). 2018-05-07 23:09 GMT+03:00 Dmitriy Setrakyan : > Is this list on the Wiki? > > On Mon, May 7, 2018 at 7:26

[GitHub] ignite pull request #3946: IGNITE-8434 .NET: Fix service proxies on .NET Cor...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3946 ---

Re: Ticket review checklist

2018-05-08 Thread Anton Vinogradov
Alex, It is not sounds like that, obviously. Tests should cover all negative and positive cases. You should add enough tests to cover all cases. Sometimes one test can cover more than one case, so two tests *CAN* partially check same things. In case some cases already covered you should not

[GitHub] ignite pull request #3957: IGNITE-8430 implemented getCurrentCoordinatorForm...

2018-05-08 Thread akalash
GitHub user akalash opened a pull request: https://github.com/apache/ignite/pull/3957 IGNITE-8430 implemented getCurrentCoordinatorFormatted method in Igni… …teMXBean You can merge this pull request into a Git repository by running: $ git pull

Re: Ticket review checklist

2018-05-08 Thread Andrey Kuznetsov
Anton, I agree, *MUST* for exception reasons and *SHOULD* for ways of resolution sound clearer. 2018-05-08 12:56 GMT+03:00 Anton Vinogradov : > Andrey, > > How about > 1.6) All exceptions thrown to a user *MUST* have explanation of workaround > and contain original error. > All

Re: Suggestion about Docker Swarm Services and Scaling Ignite automatically

2018-05-08 Thread Jonathan Schoreels
Hi Denis, It seems like one workaround would be to configure the URL to one of the manager node, and then the Docker API allows to loop over all the nodes net interfaces : https://github.com/bitsofinfo/docker-discovery-swarm-service#status. The problem is it needs to know which node is a manager

[jira] [Created] (IGNITE-8451) [ML] Refactor Labeled Dataset: remove unused methods and fields

2018-05-08 Thread Aleksey Zinoviev (JIRA)
Aleksey Zinoviev created IGNITE-8451: Summary: [ML] Refactor Labeled Dataset: remove unused methods and fields Key: IGNITE-8451 URL: https://issues.apache.org/jira/browse/IGNITE-8451 Project:

[GitHub] ignite pull request #3956: IGNITE-4150

2018-05-08 Thread devozerov
GitHub user devozerov opened a pull request: https://github.com/apache/ignite/pull/3956 IGNITE-4150 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4150 Alternatively you can review and apply these

[jira] [Created] (IGNITE-8450) [ML] Cleanup the ML package: remove unused vector/matrix classes

2018-05-08 Thread Aleksey Zinoviev (JIRA)
Aleksey Zinoviev created IGNITE-8450: Summary: [ML] Cleanup the ML package: remove unused vector/matrix classes Key: IGNITE-8450 URL: https://issues.apache.org/jira/browse/IGNITE-8450 Project:

[GitHub] ignite pull request #3952: IGNITE-8447: .Net support of DataStreamer#perThre...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3952 ---

Re: Ticket review checklist

2018-05-08 Thread Andrey Kuznetsov
Vladimir, checklist looks pleasant enough for me. I'd like to suggest one minor change. In 1.6 *MUST* seems to be too strict, *SHOULD* would be enough. It can be frustrating for API user if I explain how to fix NPEs in a trivial way, for example. 2018-05-08 11:34 GMT+03:00 Anton Vinogradov

Re: Ticket review checklist

2018-05-08 Thread Anton Vinogradov
Andrey, How about 1.6) All exceptions thrown to a user *MUST* have explanation of workaround and contain original error. All exceptions thrown to a user *SHOULD* have explanation how to resolve if possible. ? вт, 8 мая 2018 г. в 12:26, Andrey Kuznetsov : > Vladimir, checklist

[GitHub] ignite pull request #3958: IGNITE-8450: Cleanup old algebra

2018-05-08 Thread zaleslaw
GitHub user zaleslaw opened a pull request: https://github.com/apache/ignite/pull/3958 IGNITE-8450: Cleanup old algebra You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8450 Alternatively you can

Re: Node.js client update: rev. 2

2018-05-08 Thread Alexey Kosenchuk
Hi Igor, in the newer version (will be available soon) getValues() is changed to getValue() which gives sequential per-element access. The API spec and the setup/run instructions are available with every version. Thanks, -Alexey 08.05.2018 15:14, Igor Sapego пишет: Hi, Pavel, I took a

Re: Apache Ignite 2.5 release

2018-05-08 Thread Vladimir Ozerov
H2 version updated is moved to AI 2.6. There are several serious problems, main - spatial dependency replacement which is a breaking change. On Tue, May 8, 2018 at 10:17 AM, Pavel Tupitsyn wrote: > IGNITE-8434 merged to master, cherry-picked to ignite-2.5. > > Thank you,

[GitHub] ignite pull request #3959: IGNITE-8446 Ability to check and completely fill ...

2018-05-08 Thread anton-vinogradov
GitHub user anton-vinogradov opened a pull request: https://github.com/apache/ignite/pull/3959 IGNITE-8446 Ability to check and completely fill transactions on crea… …tion Signed-off-by: Anton Vinogradov You can merge this pull request into a Git

Re: IGNITE-6879

2018-05-08 Thread Dmitry Pavlov
Hi Roman, now TC passes for 1.0. In the same time new suite is not executed on TC. I've asked Peter Ivanov to assist in TC run set up for Spring Data 2.0. Sincerely, Dmitriy Pavlov пн, 7 мая 2018 г. в 18:23, Роман Меерсон : > Dmitry, I leave comment at issue. As i may

Re: Postpone Apache Ignite 2.5 release to fix baseline topology

2018-05-08 Thread Dmitriy Setrakyan
Completely support the decision to move any BLT behavior changes to 2.6. However, in 2.5 we need to add usability log messages, which I believe we already have. D. On Tue, May 8, 2018 at 2:15 PM, Andrey Gura wrote: > Igniters, > > I believe BLT is serious usability problem

Re: IGNITE-3999 review

2018-05-08 Thread Dmitriy Setrakyan
Igniters, let's make sure we add ticket description to the email subject in future, so the community will know what the ticket is about. Not everyone has time to look for the ticket, especially when the link is not even provided in the email. For example, the subject of this thread should have

RE: Apache Ignite 2.4+ Go language client

2018-05-08 Thread Aleksandr Sokolovskii
Hi Alexey, I spent some time and fully implemented OP_QUERY_SQL and OP_QUERY_SQL_CURSOR_GET_PAGE including unit tests. The OP_QUERY_SQL returns value as complex object (code=103) wrapped by array (code=27). But it’s not the end of the story. ))) Complex object is marshalled in different way

Re: memory-only mode for Ignite indexes

2018-05-08 Thread Dmitry Pavlov
Hi Igniters, I may repeat what was said early, but still: I prefer way of speeding up indexes proposed by Vladimir in addition to page replacement optimizations related to index pages. Also recently Ivan Rakov created issue intended to optimize findPageForReplacement method, it can also help

[jira] [Created] (IGNITE-8452) ML module compilation failure under Java 9

2018-05-08 Thread Peter Ivanov (JIRA)
Peter Ivanov created IGNITE-8452: Summary: ML module compilation failure under Java 9 Key: IGNITE-8452 URL: https://issues.apache.org/jira/browse/IGNITE-8452 Project: Ignite Issue Type:

Re: Postpone Apache Ignite 2.5 release to fix baseline topology

2018-05-08 Thread Andrey Gura
Igniters, I believe BLT is serious usability problem but rush isn't good idea because can lead to new bugs. As release manager I think that we should move BLT fix to Apache Ignite 2.6 release and focus on issues included to the AI 2.5 release scope. I also want inform you that code freeze is

[GitHub] ignite pull request #3947: IGNITE-8041: Add a GA Grid example that solves 'K...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3947 ---

[GitHub] ignite pull request #3957: IGNITE-8430 implemented getCurrentCoordinatorForm...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3957 ---

[GitHub] ignite pull request #3960: GG-13763 backport IGNITE-8390

2018-05-08 Thread ivandasch
GitHub user ivandasch opened a pull request: https://github.com/apache/ignite/pull/3960 GG-13763 backport IGNITE-8390 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-gg-13763 Alternatively you can

Re: Apache Ignite 2.5 release

2018-05-08 Thread Ivan Rakov
Andrey, Sorry to disturb you again. I have a follow up fix for IGNITE-8429 - https://issues.apache.org/jira/browse/IGNITE-8453. Please merge it to master and ignite-2.5. Best Regards, Ivan Rakov On 08.05.2018 15:29, Vladimir Ozerov wrote: H2 version updated is moved to AI 2.6. There are

[GitHub] ignite pull request #3961: IGNITE-8453 FileDecompressor may access HashMap w...

2018-05-08 Thread glukos
GitHub user glukos opened a pull request: https://github.com/apache/ignite/pull/3961 IGNITE-8453 FileDecompressor may access HashMap without proper synchr… …onizationcommit 7037022) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ignite pull request #3704: IGNITE-6879 and migration to spring-data 2.0.5.RE...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3704 ---

[GitHub] ignite pull request #3963: IGNITE-8443 Transaction hangs when some error occ...

2018-05-08 Thread alex-plekhanov
GitHub user alex-plekhanov opened a pull request: https://github.com/apache/ignite/pull/3963 IGNITE-8443 Transaction hangs when some error occurs during processing of GridNearLockRequest (TC run) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ignite pull request #3964: IGNITE-8443 Transaction hangs when some error occ...

2018-05-08 Thread alex-plekhanov
GitHub user alex-plekhanov opened a pull request: https://github.com/apache/ignite/pull/3964 IGNITE-8443 Transaction hangs when some error occurs during processig of GridNearLockRequest You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ignite pull request #3965: IGNITE-7912

2018-05-08 Thread DmitriyGovorukhin
GitHub user DmitriyGovorukhin opened a pull request: https://github.com/apache/ignite/pull/3965 IGNITE-7912 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7912 Alternatively you can review and

Re: IGNITE-6879: Support Spring Data 2.0

2018-05-08 Thread Dmitry Pavlov
Hi Roman, Igniters, I've merged these changes to master and it goes to 2.6. Roman, thank you for contribution and your reminders about review. Peter Ivanov, thank you for setting up tests. Alexey Kukushkin, Dmitriy Ryabov, thank you for review. Igniters, please note Spring Data suite may fail

Re: Apache Ignite 2.5 release: Can IGNITE-8041 be included?

2018-05-08 Thread Yury Babak
Turik, This pull request looks good to me. So I reviewed and merged this example into master and 2.5 branches. Regards, Yury -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[GitHub] ignite pull request #3962: IGNITE-8037 DynamicColumnsConcurrentTransactional...

2018-05-08 Thread tledkov-gridgain
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/3962 IGNITE-8037 DynamicColumnsConcurrentTransactionalPartitionedSelfTest#testClientReconnectWithNonDynamicCacheRestart is flaky You can merge this pull request into a Git repository

[jira] [Created] (IGNITE-8454) Hadoop module compilation failure under JDK9

2018-05-08 Thread Peter Ivanov (JIRA)
Peter Ivanov created IGNITE-8454: Summary: Hadoop module compilation failure under JDK9 Key: IGNITE-8454 URL: https://issues.apache.org/jira/browse/IGNITE-8454 Project: Ignite Issue Type:

Re: IGNITE-3999 review

2018-05-08 Thread Dmitry Pavlov
Hi Vladimir, thank you for stepping in. This case confirms the usefulness of the practice of discussing the problem at the devlist before implementation. вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov : > Hi, > > I provided my comments in the ticket. > > On Tue, May 8, 2018 at

[jira] [Created] (IGNITE-8453) FileDecompressor may access HashMap without proper synchronization

2018-05-08 Thread Ivan Rakov (JIRA)
Ivan Rakov created IGNITE-8453: -- Summary: FileDecompressor may access HashMap without proper synchronization Key: IGNITE-8453 URL: https://issues.apache.org/jira/browse/IGNITE-8453 Project: Ignite

Re: Migration guide

2018-05-08 Thread Denis Magda
Vladimir, Here is you can find a short summary on the planned migration: https://issues.apache.org/jira/browse/IGNITE-7595 This discussion goes with more details: http://apache-ignite-developers.2346864.n4.nabble.com/Move-documentation-from-readme-io-to-GitHub-pages-td16409.html -- Denis On

[GitHub] ignite pull request #3966: IGNITE-8452: ML module compilation failure under ...

2018-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3966 ---

[jira] [Created] (IGNITE-8457) Typo in MarshallerUtils.jdkMarshaller() method

2018-05-08 Thread Alexey Kuznetsov (JIRA)
Alexey Kuznetsov created IGNITE-8457: Summary: Typo in MarshallerUtils.jdkMarshaller() method Key: IGNITE-8457 URL: https://issues.apache.org/jira/browse/IGNITE-8457 Project: Ignite

[jira] [Created] (IGNITE-8458) AffinityAssigment absorbs a lot of java heap

2018-05-08 Thread Vladislav Pyatkov (JIRA)
Vladislav Pyatkov created IGNITE-8458: - Summary: AffinityAssigment absorbs a lot of java heap Key: IGNITE-8458 URL: https://issues.apache.org/jira/browse/IGNITE-8458 Project: Ignite

Re: IGNITE-3999 review

2018-05-08 Thread Dmitry Pavlov
Hi Amir, I've updated How To Contribute ( https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute ) section 'beginning work': (OPTIONAL) It is recommended to clarify the relevance and correctness of the ticket in the community before doing actual implementation. To do this, you can

[GitHub] ignite pull request #3966: IGNITE-8452: ML module compilation failure under ...

2018-05-08 Thread ybabak
GitHub user ybabak opened a pull request: https://github.com/apache/ignite/pull/3966 IGNITE-8452: ML module compilation failure under Java 9 fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8452

[jira] [Created] (IGNITE-8455) Cover main Ignite memory modes

2018-05-08 Thread Denis Magda (JIRA)
Denis Magda created IGNITE-8455: --- Summary: Cover main Ignite memory modes Key: IGNITE-8455 URL: https://issues.apache.org/jira/browse/IGNITE-8455 Project: Ignite Issue Type: Task

Re: IGNITE_HOME for persistence

2018-05-08 Thread Dmitry Pavlov
Hi Dmitriy, Igniters, I've created https://issues.apache.org/jira/browse/IGNITE-8456 I hope that someone in community can pick up this ticket. I've marked ticket as newbie. Sincerely, Dmitriy Pavlov ср, 14 мар. 2018 г. в 2:12, Dmitriy Setrakyan : > On Tue, Mar 13, 2018

Re: Optimize GridLongList serialization

2018-05-08 Thread Dmitry Pavlov
Hi Alexander, Would new implementation of GridLongList be able to read value serialized by old implementation? Is it possible old implementation would not be able to read value from new? Sincerely, Dmitriy Pavlov пн, 7 мая 2018 г. в 11:30, Александр Меньшиков : > Hi. > I

Re: Service grid redesign

2018-05-08 Thread Denis Mekhanikov
Hi Vyacheslav! Thanks for the enthusiasm! The first ticket to be implemented here is IGNITE-8361 . I think, until this one is resolved, other tasks can't be started. Please assign it to yourself, if you feel confident enough. Feel free to ask

Re: Apache Ignite 2.5 release

2018-05-08 Thread Andrey Gura
Thanks for fast update, Ivan. On Tue, May 8, 2018 at 5:59 PM, Ivan Rakov wrote: > Andrey, > > Sorry to disturb you again. I have a follow up fix for IGNITE-8429 - > https://issues.apache.org/jira/browse/IGNITE-8453. > Please merge it to master and ignite-2.5. > > Best

Re: missing website info

2018-05-08 Thread Denis Magda
Dmitriy, Presently this information is scattered and presented under sections named differently. Agree with the format proposed by you. https://issues.apache.org/jira/browse/IGNITE-8455 In addition, we should cover another mode which is indexes in RAM and data on disk to get a better technical

Re: method arguments code style

2018-05-08 Thread Dmitriy Govorukhin
Dmitriy, Сould you please update code style wiki page in accordance with the results of the discussion? On May 7 2018, at 11:00 am, Vladimir Ozerov wrote: > > Dmitry, > Agree, mixed style when some arguments share the same line and others don't > looks very bad. My

[jira] [Created] (IGNITE-8456) Print warning if IGNITE_HOME & WORK and persistentStoreDir is not set, but persistence enabled

2018-05-08 Thread Dmitriy Pavlov (JIRA)
Dmitriy Pavlov created IGNITE-8456: -- Summary: Print warning if IGNITE_HOME & WORK and persistentStoreDir is not set, but persistence enabled Key: IGNITE-8456 URL:

Re: IGNITE-3999 review

2018-05-08 Thread Amir Akhmedov
Hi All, It's definitely my bad, I had to synch up with community on ticket's relevance. Would be nice for future contributors to mention "do get updates on ticket's relevance for outdated tickets" in Ignite's "How to contribute" webpage. Thanks, Amir On Tue, May 8, 2018 at 8:39 AM, Dmitriy

Re: method arguments code style

2018-05-08 Thread Dmitry Pavlov
I thought that Vladimir will update. By the way, Denis M, I propose to grant access to the wiki to Dmitry G. WDYT? вт, 8 мая 2018 г. в 19:28, Dmitriy Govorukhin : > Dmitriy, > > Сould you please update code style wiki page in accordance with the > results of the

Re: Postpone Apache Ignite 2.5 release to fix baseline topology

2018-05-08 Thread Andrey Gura
Dmitry, additional BLT related logging is already added. I hope it will help users to understand BLT better. On Tue, May 8, 2018 at 3:36 PM, Dmitriy Setrakyan wrote: > Completely support the decision to move any BLT behavior changes to 2.6. > However, in 2.5 we need to

Re: method arguments code style

2018-05-08 Thread Dmitry Pavlov
Folks, I've messed with another topic, where Vladimir was going to update review check-list. Here I've updated Coding Guidelines: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-MethodArguments Please review changes, so we can consider it is final.

[jira] [Created] (IGNITE-8459) Searching checkpoint history for WAL rebalance is broken

2018-05-08 Thread Pavel Kovalenko (JIRA)
Pavel Kovalenko created IGNITE-8459: --- Summary: Searching checkpoint history for WAL rebalance is broken Key: IGNITE-8459 URL: https://issues.apache.org/jira/browse/IGNITE-8459 Project: Ignite