[GitHub] ignite pull request #3969: Ignite 8457

2018-05-10 Thread vveider
GitHub user vveider opened a pull request: https://github.com/apache/ignite/pull/3969 Ignite 8457 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8457 Alternatively you can review and apply these

[GitHub] ignite pull request #3969: Ignite 8457

2018-05-10 Thread vveider
Github user vveider closed the pull request at: https://github.com/apache/ignite/pull/3969 ---

[jira] [Created] (IGNITE-8465) Support compatibility in control.sh utility

2018-05-10 Thread Dmitry Sherstobitov (JIRA)
Dmitry Sherstobitov created IGNITE-8465: --- Summary: Support compatibility in control.sh utility Key: IGNITE-8465 URL: https://issues.apache.org/jira/browse/IGNITE-8465 Project: Ignite

[jira] [Created] (IGNITE-8461) Scala-2.10 modules compilation failure under JDK 9

2018-05-10 Thread Peter Ivanov (JIRA)
Peter Ivanov created IGNITE-8461: Summary: Scala-2.10 modules compilation failure under JDK 9 Key: IGNITE-8461 URL: https://issues.apache.org/jira/browse/IGNITE-8461 Project: Ignite Issue

[jira] [Created] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

2018-05-10 Thread Ivan Fedotov (JIRA)
Ivan Fedotov created IGNITE-8462: Summary: DataStreamerImpl.close(true) should throw exception Key: IGNITE-8462 URL: https://issues.apache.org/jira/browse/IGNITE-8462 Project: Ignite Issue

[jira] [Created] (IGNITE-8463) Node.js: setup TeamCity

2018-05-10 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-8463: --- Summary: Node.js: setup TeamCity Key: IGNITE-8463 URL: https://issues.apache.org/jira/browse/IGNITE-8463 Project: Ignite Issue Type: Task

[GitHub] ignite pull request #3970: IGNITE-8441 Java 9 (Stage II)

2018-05-10 Thread vveider
GitHub user vveider opened a pull request: https://github.com/apache/ignite/pull/3970 IGNITE-8441 Java 9 (Stage II) * updated some dependencies version You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #3971: IGNITE-8462

2018-05-10 Thread 1vanan
GitHub user 1vanan opened a pull request: https://github.com/apache/ignite/pull/3971 IGNITE-8462 You can merge this pull request into a Git repository by running: $ git pull https://github.com/1vanan/ignite IGNITE-8462 Alternatively you can review and apply these changes as

Re: Ticket review checklist

2018-05-10 Thread Vladimir Ozerov
Andrey, Anton, Alex Agree, *SHOULD* is more appropriate here. Please see latest version below. Does anyone want to add or change something? Let's wait for several days for more feedback and then publish and announce this list. Note that it would not be carved in stone and we will be able to

[GitHub] ignite pull request #3951: IGNITE-8422 Zookeeper discovery split-brain resol...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3951 ---

[GitHub] ignite pull request #3950: IGNITE-8437 Control utility fails to connect to c...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3950 ---

[GitHub] ignite pull request #3968: ignite-2.5.1-p1

2018-05-10 Thread DmitriyGovorukhin
GitHub user DmitriyGovorukhin opened a pull request: https://github.com/apache/ignite/pull/3968 ignite-2.5.1-p1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.5.1-p1 Alternatively you can review

Re: Apache Ignite 2.4+ Go language client

2018-05-10 Thread Igor Sapego
Aleksandr, I'm currently working on the improvement of the doc, so please, feel free to participate with review and proposals here - [1]. [1] -https://issues.apache.org/jira/browse/IGNITE-8039 Best Regards, Igor On Tue, May 8, 2018 at 3:47 PM, Aleksandr Sokolovskii wrote: >

Re: Ticket review checklist

2018-05-10 Thread Vladimir Ozerov
Dima, It will be on WIKI once community is in agreement on it's content. On Mon, May 7, 2018 at 11:09 PM, Dmitriy Setrakyan wrote: > Is this list on the Wiki? > > On Mon, May 7, 2018 at 7:26 AM, Vladimir Ozerov > wrote: > > > Igniters, > > > > This

[GitHub] ignite pull request #3636: IGNITE-7912 Manage unused WAL segments thru contr...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3636 ---

[jira] [Created] (IGNITE-8464) WALItreater broken (race on the switch to the next segment during iteration and concurrent archiving same segment)

2018-05-10 Thread Dmitriy Govorukhin (JIRA)
Dmitriy Govorukhin created IGNITE-8464: -- Summary: WALItreater broken (race on the switch to the next segment during iteration and concurrent archiving same segment) Key: IGNITE-8464 URL:

Re: need review for PR

2018-05-10 Thread Dmitry Pavlov
Hi Igor, I'll try to find a reviewer. We also need expert opinion about here https://issues.apache.org/jira/browse/IGNITE-6500 It is literally 1 line of code, but we need to be sure we can skip nulls. Could you please review? Sincerely, Dmitriy Pavlov ср, 9 мая 2018 г. в 8:01, Igor Rudyak

Re: Ticket review checklist

2018-05-10 Thread Vladimir Ozerov
Anton, Checklist is not about checking, but about expectations and trust. Implementor should know what is expected from his patch. And reviewer is not inspector. His goal is to agree with implementer that checklist requirements s addressed. Consider thin client protocol compatibility. Without

Re: Ticket review checklist

2018-05-10 Thread Dmitry Pavlov
Correct message should be added to original exception thrown at cache update. Re-thrown exception case is not counter-example for general approach. чт, 10 мая 2018 г. в 16:24, Anton Vinogradov : > >> U.error(log, "Unexpected exception during cache update", e); > >> I mean, we

[GitHub] ignite pull request #3974: Ignite 2.4.2 p11

2018-05-10 Thread ivandasch
GitHub user ivandasch opened a pull request: https://github.com/apache/ignite/pull/3974 Ignite 2.4.2 p11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.4.2-p11 Alternatively you can review and

Re: Ticket review checklist

2018-05-10 Thread Ilya Kasnacheev
I don't think I quite understand how exception explanations should work. Imagine we have the following exception: // At least RuntimeException can be thrown by the code above when GridCacheContext is cleaned and there is // an attempt to use cleaned resources. U.error(log, "Unexpected exception

Re: Using GraalVM instead of standard JVM

2018-05-10 Thread Dmitriy Setrakyan
Would be nice to have a TC run on Graal, just to have an understanding whether we support it or not. D. On Wed, May 9, 2018 at 4:28 PM, Denis Magda wrote: > The performance might become better just by replacing HotSpot with Graal, > but something suggests me that Ignite has

Re: Ticket review checklist

2018-05-10 Thread Ilya Kasnacheev
Dmitry, can you please perform an excercise of looking that piece of code up (org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache), telling us how an ideal message should look like in this case? Thanks, -- Ilya Kasnacheev 2018-05-10 16:15 GMT+03:00 Dmitry

Re: Ticket review checklist

2018-05-10 Thread Anton Vinogradov
>> U.error(log, "Unexpected exception during cache update", e); >> I mean, we genuinely don't know what happened here. Fully agree with Ilya. In some cases it's impossible to explain the reason. All we can is just to log the error. >> Error text `Unexpected exception during cache update` is

[jira] [Created] (IGNITE-8466) Control.sh transacitions utility may hang on case with loading

2018-05-10 Thread Dmitry Sherstobitov (JIRA)
Dmitry Sherstobitov created IGNITE-8466: --- Summary: Control.sh transacitions utility may hang on case with loading Key: IGNITE-8466 URL: https://issues.apache.org/jira/browse/IGNITE-8466

[GitHub] ignite pull request #3771: IGNITE-8167: Fix inconsistent last record pointer...

2018-05-10 Thread amelius0712
Github user amelius0712 closed the pull request at: https://github.com/apache/ignite/pull/3771 ---

Re: Ticket review checklist

2018-05-10 Thread Vladimir Ozerov
Ilya, We define that exception messages *SHOULD* have clear explanation on what is wrong. *SHOULD* mean that the rule should be followed unless there is a reason not to follow. In your case you refer to some unexpected behavior. I.e. an exceptional situation developer is not aware of. In this

Re: Ticket review checklist

2018-05-10 Thread Dmitry Pavlov
Hi Ilya, Error text `Unexpected exception during cache update` is brilliant example how product should not behave. So requiring contributors to explain reasons of failure would be good first step to come to situation that exception text is so clear that user will know what to do. It will

IGNITE-6430 (Done) CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime test fails periodically

2018-05-10 Thread Александр Меньшиков
Hi, I have fixed problem with the test CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. Please review and merge if okay. P.S. Aleksey Plekhanov already approved it (see Jira). JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 PR:

[GitHub] ignite pull request #3972: Ignite 8138 2

2018-05-10 Thread dspavlov
GitHub user dspavlov opened a pull request: https://github.com/apache/ignite/pull/3972 Ignite 8138 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8138-2 Alternatively you can review and apply

[GitHub] ignite pull request #3973: IGNITE-6055: SQL: Add String length constraint

2018-05-10 Thread nizhikov
GitHub user nizhikov opened a pull request: https://github.com/apache/ignite/pull/3973 IGNITE-6055: SQL: Add String length constraint You can merge this pull request into a Git repository by running: $ git pull https://github.com/nizhikov/ignite IGNITE-6055 Alternatively you

Re: Optimize GridLongList serialization

2018-05-10 Thread Александр Меньшиков
Hi Dmitry, It's 100% compatible. I just change one line for serializing only valuable part of the array -- just use another method of a writer. I think it's enough for now. We can return to a discussion about compact GridLongList in future when the 3.0 release will start coming. 2018-05-08

[GitHub] ignite pull request #3337: IGNITE-7343 Add guard to prevent concurrent usage...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3337 ---

[jira] [Created] (IGNITE-8460) Document JDBC thin driver DataSource

2018-05-10 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-8460: --- Summary: Document JDBC thin driver DataSource Key: IGNITE-8460 URL: https://issues.apache.org/jira/browse/IGNITE-8460 Project: Ignite Issue Type: Task

[jira] [Created] (IGNITE-8467) minSize filter for transactions utility control.sh doesn't work

2018-05-10 Thread Dmitry Sherstobitov (JIRA)
Dmitry Sherstobitov created IGNITE-8467: --- Summary: minSize filter for transactions utility control.sh doesn't work Key: IGNITE-8467 URL: https://issues.apache.org/jira/browse/IGNITE-8467

Re: Using GraalVM instead of standard JVM

2018-05-10 Thread Dmitry Pavlov
Hi Peter, It seems it is one more argument to implement selectable VM for existing run-all chain instead of creating one more. Would it be easy to add one more option once JDK 9 run is ready? Sincerely, Dmitriy Pavlov чт, 10 мая 2018 г. в 15:58, Dmitriy Setrakyan : >

New committer: Ivan Rakov

2018-05-10 Thread Denis Magda
The Project Management Committee (PMC) for Apache Ignite has invited Ivan Rakov to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should enable

[GitHub] ignite pull request #3868: IGNITE-7968 IgniteAtomicSequence.incrementAndGet ...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3868 ---

[GitHub] ignite pull request #3975: IGNITE-8422 Improve tests

2018-05-10 Thread Jokser
GitHub user Jokser opened a pull request: https://github.com/apache/ignite/pull/3975 IGNITE-8422 Improve tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8422 Alternatively you can review and

Re: NodeJS client: scripts for Ignite nodes start/stop, TeamCity integration

2018-05-10 Thread Petr Ivanov
Igniters, I will take it from here — corresponding task [1] is filed and works will start soon. [1] https://issues.apache.org/jira/browse/IGNITE-8463 > On 10 May 2018, at 13:06, Igor Sapego wrote: > > There are no any special scripts, as far as I know, so it's >

[GitHub] ignite pull request #3487: IGNITE-7535: Implement CHARSET option in COPY ......

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3487 ---

[jira] [Created] (IGNITE-8468) Adding and searching UUIDs in index tree produces a lot of garbage

2018-05-10 Thread Andrew Mashenkov (JIRA)
Andrew Mashenkov created IGNITE-8468: Summary: Adding and searching UUIDs in index tree produces a lot of garbage Key: IGNITE-8468 URL: https://issues.apache.org/jira/browse/IGNITE-8468 Project:

Re: Where is ICache.Removex() in .Net client?

2018-05-10 Thread Pavel Tupitsyn
Hi, The doc is misleading, method "bool Remove(TK key)" does not return removed element, just the flag indicating whether removal happened or not. On Wed, May 9, 2018 at 4:06 AM, Raymond Wilson wrote: > I have some code the removes elements from a cache, and I’d

[GitHub] ignite pull request #3976: IGNITE-8456: Print warning if IGNITE_HOME & WORK ...

2018-05-10 Thread SomeFire
GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/3976 IGNITE-8456: Print warning if IGNITE_HOME & WORK and persistentStoreD… …ir is not set, but persistence enabled You can merge this pull request into a Git repository by running: $ git

Re: Replace Cron4J with Quartz for ignite-schedule module.

2018-05-10 Thread Dmitry Pavlov
Hi Anton, Thank you for joining and review. I hope all proposals will be applied. Sincerely, Dmitriy Pavlov пт, 4 мая 2018 г. в 16:04, Anton Vinogradov : > Folks, > > How can it be at PATCH AVAILABLE since *none* of my latest comments (made > Feb 8) are resolved at Upsource? >

Re: New committer: Ivan Rakov

2018-05-10 Thread Dmitry Pavlov
Hi Ivan, please accept my sincere congratulations! Best Regards, Dmitriy Pavlov чт, 10 мая 2018 г. в 19:09, Denis Magda : > The Project Management Committee (PMC) for Apache Ignite > has invited Ivan Rakov to become a committer and we are pleased > to announce that he has

Re: IGNITE-640: multimap initial implementation

2018-05-10 Thread Dmitry Pavlov
Hi Amir, This is a very necessary contribution, the patch defenetely will not be ignored. Igniters, Who can make a review from the committers? Sincerely, Dmitriy Pavlov вт, 8 мая 2018 г. в 5:52, Amir Akhmedov : > Hi Igniters, > > Can someone take a look at this PR

[GitHub] ignite pull request #3977: IGNITE-8468: Optimization for UUID fields.

2018-05-10 Thread AMashenkov
GitHub user AMashenkov opened a pull request: https://github.com/apache/ignite/pull/3977 IGNITE-8468: Optimization for UUID fields. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8468

Re: Apache Ignite 2.5 release

2018-05-10 Thread Andrey Gura
Igniters, Almost all issues for Apache Ignite 2.5 release are fixed. Issues that are still in Open state will be moved to 2.6 release. Code freeze for ignite-2.5 branch is planed for tomorrow. Thanks! On Tue, May 8, 2018 at 7:09 PM, Andrey Gura wrote: > Thanks for fast

[jira] [Created] (IGNITE-8469) Non-heap memroy leak for calling cluster activation multi times

2018-05-10 Thread Maxim Muzafarov (JIRA)
Maxim Muzafarov created IGNITE-8469: --- Summary: Non-heap memroy leak for calling cluster activation multi times Key: IGNITE-8469 URL: https://issues.apache.org/jira/browse/IGNITE-8469 Project:

Re: New committer: Ivan Rakov

2018-05-10 Thread Pavel Kovalenko
Hi Ivan, Congratulations, you deserved it! 2018-05-10 19:08 GMT+03:00 Denis Magda : > The Project Management Committee (PMC) for Apache Ignite > has invited Ivan Rakov to become a committer and we are pleased > to announce that he has accepted. > > Being a committer enables

[GitHub] ignite pull request #3978: IGNITE-7777 Node.js client: full API & implementa...

2018-05-10 Thread ekaterina-nbl
GitHub user ekaterina-nbl opened a pull request: https://github.com/apache/ignite/pull/3978 IGNITE- Node.js client: full API & implementation You can merge this pull request into a Git repository by running: $ git pull https://github.com/nobitlost/ignite ignite-

NodeJS thin client: full API

2018-05-10 Thread Alexey Kosenchuk
Folks, The next version is ready - in the pull request [1] or directly in the repo [2]. The version includes: - full API - full implementation - examples - tests (cover the full API but might need to be updated/extended) - docs The details are in the readme [3] Regards, -Alexey [1]

RE: Possible bug in PutAll() in Ignite 2.4, .Net client

2018-05-10 Thread Raymond Wilson
I have tried replacing the PutAll() with two Put()s, like this: cache.Put(key1, new byte[100]); cache.Put(key2, new byte[100]); The first Put throws this exception: *Name* *Value* *Type* ▶ $exception {Apache.Ignite.Core.Cache.CacheException: class

Possible bug in PutAll() in Ignite 2.4, .Net client

2018-05-10 Thread Raymond Wilson
I have run into an issue using an AffinityFunction with a Guid in the key. The complete reproducer is included below as an XUnit unit test. I do know about the [AffinityKeyMapped] attribute, but I want to have different behaviour for these keys depending on context (sometimes I want them

RE: Possible bug in PutAll() in Ignite 2.4, .Net client

2018-05-10 Thread Raymond Wilson
I have previously used the same logic using a long instead of a Guid without this issue. *From:* Raymond Wilson [mailto:raymond_wil...@trimble.com] *Sent:* Friday, May 11, 2018 2:36 PM *To:* 'dev@ignite.apache.org' *Subject:* RE: Possible bug in PutAll() in Ignite 2.4,

RE: Possible bug in PutAll() in Ignite 2.4, .Net client

2018-05-10 Thread Raymond Wilson
Aha! After more investigation I found GetHashCode() can return a negative value, leading to a negative partition number result from GetPartition, and the resulting array index exception many calls lower in the stack. Changing GetPartition to the following corrects the issue public

One more round for PR review

2018-05-10 Thread Igor Rudyak
Hi guys, I addressed all the comments and need one more round of review for the PR: https://github.com/apache/ignite/pull/3940 Igor