[GitHub] ignite pull request #4330: IGNITE-8828

2018-07-08 Thread ilantukh
GitHub user ilantukh opened a pull request: https://github.com/apache/ignite/pull/4330 IGNITE-8828 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8828 Alternatively you can review and apply these

Re: IgniteConfiguration, toString(), @GridToStringInclude

2018-07-08 Thread Dmitriy Setrakyan
In that case I would recommend that it is a separate category that can be easily turned off. Also, if there are 1000 caches, then I am certain that they share most of the properties and only a few configuration properties differ. Moreover, it is very likely that most of them belong to the same

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-08 Thread kcheng.mvp
Dear igniters, does anyone can help do the code review? As this ticket is created by myself, I need someone else to help me do the code review. Thanks, kcmvp -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Ability to check and completely fill transactions on creation

2018-07-08 Thread Dmitriy Setrakyan
Anton, how do you plan to rollback the transaction from a remote filter? Are you planning to call setRollbackOnly()? Calling rollback() or commit() from any filter or listener should not be allowed. D. On Tue, Jul 3, 2018 at 1:55 AM, Anton Vinogradov wrote: > Dmitriy, Yakov, > > I've finalized

Re: IgniteConfiguration, toString(), @GridToStringInclude

2018-07-08 Thread Ilya Kasnacheev
Hello! The configuration is usually already present in some other file (in XML or Java form). People who report problems or userlist often fail to provide such file, and they will also definitely forget to provide that other separate file with printed configuation. Log file is our best shot since