Re: Configure list and order of SSL cipher suites

2018-05-03 Thread Denis Magda
Ilya, Thanks for picking up this belated task. The solution you found seems ideal to me. I would go for it. BTW, not sure we need an IEP for this improvement. -- Denis On Thu, May 3, 2018 at 7:54 AM, Ilya Kasnacheev wrote: > A follow up on

[GitHub] ignite pull request #3848: IGNITE-8088 Exchange await.

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3848 ---

[jira] [Created] (IGNITE-8433) Upgrade zookeper version

2018-05-03 Thread Evgenii Zhuravlev (JIRA)
Evgenii Zhuravlev created IGNITE-8433: - Summary: Upgrade zookeper version Key: IGNITE-8433 URL: https://issues.apache.org/jira/browse/IGNITE-8433 Project: Ignite Issue Type: Improvement

Re: Orphaned, duplicate, and main-class tests!

2018-05-03 Thread Ilya Kasnacheev
Hello Dmitry, igniters! Still, the policy of removal of unused tests is not clear to me. We have roughly three groups of such tests: - Odd ancient main class tests. I think we can remove those. - JVM features/quirks tests (some are main class, some are JUnit tests. Reside in package jvmtest.

[GitHub] ignite pull request #3943: IGNITE-8424 Add directory sorting and skip duplic...

2018-05-03 Thread ivandasch
GitHub user ivandasch opened a pull request: https://github.com/apache/ignite/pull/3943 IGNITE-8424 Add directory sorting and skip duplicated config file in … …order to consistently start nodes. You can merge this pull request into a Git repository by running: $

[GitHub] ignite pull request #3937: IGNITE-8412 Issues with cache names in GridComman...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3937 ---

Re: Apache Ignite 2.5 release

2018-05-03 Thread Dmitry Pavlov
Hi Andrey, Igniters, I propose to include https://issues.apache.org/jira/browse/IGNITE-8347 fix to 2.5. It is quite isolated. Memory leak can be reproduced if node in embedded mode is restarted under the same process (thread is alive and cleanup is not performed). Sincerely, Dmitriy Pavlov сб,

[GitHub] ignite pull request #3891: Ignite 8347 1

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3891 ---

Configure list and order of SSL cipher suites

2018-05-03 Thread Ilya Kasnacheev
A follow up on https://issues.apache.org/jira/browse/IGNITE-6167 Some users want to specify a list of ciphers to use in their controlled environment, limiting to a select few ciphers with ordering. I have tried to implement the work-around it myself, and found that amount of code and copy-paste

[jira] [Created] (IGNITE-8432) GridSqlQueryParser.java throws null pointer if there is a mismatch between the column name casing

2018-05-03 Thread Courtney (JIRA)
Courtney created IGNITE-8432: Summary: GridSqlQueryParser.java throws null pointer if there is a mismatch between the column name casing Key: IGNITE-8432 URL: https://issues.apache.org/jira/browse/IGNITE-8432

[GitHub] ignite pull request #3929: IGNITE-8405 Update partition owners during exchan...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3929 ---

[GitHub] ignite pull request #3796: IGNITE-8226 Logs minor improvement.

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3796 ---

[GitHub] ignite pull request #3889: IGNITE-8347 Memory leaks on restart Ignite node w...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3889 ---

[jira] [Created] (IGNITE-8431) createTcpClient crash when starting two local nodes with different IP, but same ports

2018-05-03 Thread Max Shonichev (JIRA)
Max Shonichev created IGNITE-8431: - Summary: createTcpClient crash when starting two local nodes with different IP, but same ports Key: IGNITE-8431 URL: https://issues.apache.org/jira/browse/IGNITE-8431

Re: method arguments code style

2018-05-03 Thread Vladimir Ozerov
My opinion is that we should allow both styles and not enforce any of them. I hardly can say that this public double getCost( Session ses, int[] masks, TableFilter[] filters, int filter, SortOrder sortOrder, HashSet cols ) { return

[GitHub] ignite pull request #3942: Ignite 8337

2018-05-03 Thread oleg-ostanin
GitHub user oleg-ostanin opened a pull request: https://github.com/apache/ignite/pull/3942 Ignite 8337 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8337 Alternatively you can review and apply

[jira] [Created] (IGNITE-8430) gety

2018-05-03 Thread Max Shonichev (JIRA)
Max Shonichev created IGNITE-8430: - Summary: gety Key: IGNITE-8430 URL: https://issues.apache.org/jira/browse/IGNITE-8430 Project: Ignite Issue Type: New Feature Reporter: Max

Re: method arguments code style

2018-05-03 Thread Eduard Shangareev
Alexey, +1. I personally also follow this style. On Thu, May 3, 2018 at 12:45 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Actually, I've been following the suggested code style for quite a while. > I'm ok to add this to coding guidelines, however, I think we should allow > the

Re: method arguments code style

2018-05-03 Thread Alexey Goncharuk
Actually, I've been following the suggested code style for quite a while. I'm ok to add this to coding guidelines, however, I think we should allow the old style when the method signature (without throws clause) fits the line. Thoughts? 2018-05-03 12:09 GMT+03:00 Dmitry Pavlov

[GitHub] ignite pull request #3442: IGNITE-6699 Optimize client-side data streamer pe...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3442 ---

[GitHub] ignite pull request #3903: IGNITE-8310: CPP compilation and tests with boost...

2018-05-03 Thread nizhikov
Github user nizhikov closed the pull request at: https://github.com/apache/ignite/pull/3903 ---

Re: method arguments code style

2018-05-03 Thread Dmitry Pavlov
Hi Dmitriy, I like your proposal, so +1 from me. I think it would make code more readable and easy to understand. Sincerely, Dmitriy Pavlov чт, 3 мая 2018 г. в 11:31, Dmitriy Govorukhin : > Hi folks, > > I read >

[jira] [Created] (IGNITE-8429) Unexpected error during incorrect WAL segment decompression, causes node termination.

2018-05-03 Thread Ivan Daschinskiy (JIRA)
Ivan Daschinskiy created IGNITE-8429: Summary: Unexpected error during incorrect WAL segment decompression, causes node termination. Key: IGNITE-8429 URL: https://issues.apache.org/jira/browse/IGNITE-8429

method arguments code style

2018-05-03 Thread Dmitriy Govorukhin
Hi folks, I read https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines, but did not find anything about code style for method arguments. In many places in the code, I see different code style, this creates difficulties for reading. It seems to me an example below is rather