[MTCGA]: new failures in builds [2151099] needs to be handled

[dpavlov . tasks]

Hi Igniters,

 I've detected some new issue on TeamCity to be handled. You are more than 
welcomed to help.

 If your changes can lead to this failure(s): We're grateful that you were a 
volunteer to make the contribution to this project, but things change and you 
may no longer be able to finalize your contribution.
 Could you respond to this email and indicate if you wish to continue and fix 
test failures or step down and some committer may revert you commit. 

 *New test failure in master 
CacheAsyncOperationsFailoverAtomicTest.testAsyncFailover 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=4804871380159333917=%3Cdefault%3E=testDetails

 *New test failure in master 
CacheAsyncOperationsFailoverTxTest.testAsyncFailover 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-4385696082979577105=%3Cdefault%3E=testDetails
 Changes may lead to failure were done by 
 - spiderru5597 
http://ci.ignite.apache.org/viewModification.html?modId=836137=false

 - Here's a reminder of what contributors were agreed to do 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute 
 - Should you have any questions please contact dev@ignite.apache.org 

Best Regards,
Apache Ignite TeamCity Bot 
https://github.com/apache/ignite-teamcity-bot
Notification generated at 07:15:57 24-10-2018 

Re: Pre-touch for Ignite off-heap memory

[Denis Magda]

Alex,

Correct me if I'm wrong, but even if an OS runs out of physical memory (X
GB in total) an Ignite node process still can request the X GB from virtual
memory. Yes, virtual memory can involve swapping and disk to satisfy your
request but this shouldn't be a reason of the OOM. Shouldn't OOM happen if
you're trying to allocate beyond the virtual memory capacity (beyond X GB)?

Denis

On Tue, Oct 23, 2018 at 12:08 PM Gerus  wrote:

> Hi *Igniters*,
> Some time ago I've raised a suggestion for product improvement
> https://issues.apache.org/jira/browse/IGNITE-9112
>   .  It's all about
> off-heap memory allocation. Current implementation can have some
> improvements for failure critical systems. Ignite can have OOM in runtime,
> because RAM can be used by OS, if it will not be pre-booked by operation
> system and this proposal is to address that. Common case is offheap and
> thats why memory segment cannot be managed by JVM that has +AlwaysPreTouch
> option
> Obviously this implementation will make startup longer and thats why it is
> proposed to use configuration flag to manage this feature
> I think, it will be useful to have this option. Are you supporting this?
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>

Re: Continuous query deployment

[Valentin Kulichenko]

Guys,

Correct me if I am wrong, but to my knowledge peer class loading doesn't
*really* work for CQs regardless of autoUnsubscribe flag. The issue is that
filter is distributed via discovery messages when new node joins, but
discovery uses JDK marshaller that is not aware of p2p loading. So classes
are remotely loaded only on initial query execution, but not for the new
nodes that join after it's already deployed.

If that's the case, we should just find a right way of dynamic class
loading that always works. Deployment SPI seems to be a good candidate,
just like for services.

-Val

On Mon, Oct 22, 2018 at 1:46 AM Denis Mekhanikov 
wrote:

> Ilya,
>
> Disabling P2P class loading for CQ with *autoUnsubscribe=false* is a
> minimum, that should be done.
> But it will only solves one of the existing problems.
> It's still unclear, how to undeploy such queries.
> Continuous queries with *autoUnsubscribe=true* have different semantic with
> the ones with *autoUnsubscribe=false*.
>
> The first of them is designed to deliver cache events to the subscriber.
> They can't exist without the subscriber node, so they are automatically
> undeployed, when the subscriber leaves.
> I don't see any problems in using  P2P class loading for them.
>
> The second one is needed to deploy a set of listeners, that are collocated
> to data.
> In this case the subscriber is not needed, so we don't undeploy the query,
> when the subscriber leaves.
> But we still have a dependency on the subscriber, since only him can
> undeploy the query or redeploy it with different parameters.
> Such queries should have a name or Id, that other nodes will use to get a
> handle of them.
> And P2P class loading is not applicable here, since the query may outlive
> the initiator.
>
> Val,
>
> We didn't start working on service hot redeployment yet.
> We tentatively agreed, that Deployment SPI it a good candidate as a tool
> for this task.
>
> Denis
>
> чт, 18 окт. 2018 г. в 18:44, Valentin Kulichenko <
> valentin.kuliche...@gmail.com>:
>
> > Denis,
> >
> > I agree that p2p loading is not the best choice for CQs. Do you know if
> > we've already done anything in that area for the Service Grid? Are we
> > using/going to use Deployment SPI there as well? Either way, I think it
> > would make sense if services and CQs should end up using the same
> mechanism
> > for dynamic loading.
> >
> > -Val
> >
> > On Thu, Oct 18, 2018 at 8:36 AM Ilya Kasnacheev <
> ilya.kasnach...@gmail.com
> > >
> > wrote:
> >
> > > Hello!
> > >
> > > Is it possible to simply disable P2P class loading for remote filter of
> > > continuous queries with autoUnsubscribe = true?
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > чт, 18 окт. 2018 г. в 18:31, Denis Mekhanikov :
> > >
> > > > Igniters,
> > > >
> > > > I'm concerned with our continuous query API and deployment procedure.
> > > >
> > > > Continuous queries have remote filters, that can be deployed over
> peer
> > > > class loading mechanism (this functionality is currently broken
> though:
> > > > IGNITE-3653 ,
> > > > IGNITE-9181
> > > > ).
> > > > In usual cases P2P class loading makes sense, but problems begin
> when a
> > > > node, that deployed the CQ, leaves cluster. By default the CQ is
> > > undeployed
> > > > in this case. But ContinuousQuery has *autoUnsubscribe*
> > > > <
> > > >
> > >
> >
> https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cache/query/ContinuousQuery.html#setAutoUnsubscribe-boolean-
> > > > >
> > > > property. If set to true, it lets a continuous query stay in cluster,
> > > when
> > > > initiator leaves.
> > > > So, you may end up in a situation, when a continuous query remote
> > filter
> > > is
> > > > deployed in a cluster, but the node, that the class was loaded from,
> is
> > > > already gone.
> > > > New nodes won't have where to load the remote filter class from in
> this
> > > > case. Also existing nodes may have problems, since class loading of
> > > > dependencies of the loaded class happens lazily (and cannot happen
> > > > eagerly), so they also need the initiator node.
> > > >
> > > > The *autoUnsubscribe* property helps to deploy continuous queries,
> that
> > > > listen to cache updates and react to them in the remote filters. This
> > is
> > > > pretty convenient, since it allows cache updates be processed
> locally,
> > > > right where updates happen, without sending data over network. Such
> > > > continuous query may not even have a local listener, so initiator
> node
> > > may
> > > > deploy the query and leave.
> > > >
> > > > *BUT*
> > > >
> > > >- The deployed CQ becomes impossible to undeploy. It stays in the
> > > >cluster till the end of times.
> > > >- This case looks like a miss-use of the remote filters. They
> should
> > > >*filter*, but not *listen* and *react*. Remote filter should be a
> > > >stateless 

Re: [DISCUSSION] Spark Data Frame through Thin Client

[Valentin Kulichenko]

Nikolay,

Please see my comments below. Actually, I haven't made most of the
assumptions that you mentioned, and I generally agree with you. What I
don't agree with is that replacing thick client with thin client is a way
to fix usability issues. Thin client is not going to be issue-free either,
but will potentially compromise the performance, as well as functionality
(like streaming, as Stephen mentioned). My suggestion is to look at
usability issues and try to fix them without getting rid of thick client.

-Val

On Sun, Oct 21, 2018 at 1:08 AM Nikolay Izhikov  wrote:

> Valentin.
>
> Seems, You made several suggestions, which is not always true, from my
> point of view:
>
> 1. "We have access to Spark cluster installation to perform deployment
> steps" - this is not true in cloud or enterprise environment.
>

Can you please elaborate on this? What is the difference between thin and
thick client from this point of view? I understand that the latter would
generally be more complicated, but how would one use thin client without
deploying a JAR?


>
> 2. "Spark cluster is used only for Ignite integration".
> From what I know computational resources for big Spark cluster is divided
> by many business divisions.
> And it is not convenient to perform some deployment steps on this cluster.
>

Same as #1. Regardless how we use the Spark cluster, we need to deploy a
JAR in case of thin client, no?


>
> 3. "When Ignite + Spark are used in real production it's OK to have
> reasonable deployment overhead"
> What about developer who want to play with this integration?
> And want to do it quickly to see how it works in real life examples.
> Can we do his life much easier?
>

We can and we should :) I'm not arguing there are usability issues with
thick client. I'm just suggesting to fix those issues first, before we jump
reworking the implementation.


>
> > First of all, they will exist with thin client either.
>
> Spark have an ability to deploy jars on worker and add it to application
> tasks classpath.
> For 2.6 we must deploy 11 additional jars to start using Ignite.
> Please, see my example on the bottom of documentation page [1]
>
> Does cache-api-1.0.0.jar and h2-1.4.195.jar seems like obvious
> dependencies for Ignite integration for you?
> And for our users? :)
>

No, this is not obvious. Absolutely, this is a usability issue and we
should think how to make user's life easier.


>
> Actually, list of dependencies will be changed in 2.7 - new version of
> jcache, new version of h2
> So user should change it in code or perform additional deployment steps.
>
> It overkill for me.
>
> On the other hand - thin client requires only 1 jar.
> Moreover, thin client protocol have the backward compatibility.
> So thin client will perform correctly when Ignite cluster will be updated
> from 2.6 to 2.7.
> So, with Spark integration via thin client we will be able to update
> Ignite cluster and Spark integration separately.
> For now, we should do it in one big step.
>
> What do you think?
>
> [1] https://apacheignite-fs.readme.io/docs/installation-deployment
>
> В Сб, 20/10/2018 в 18:33 -0700, Valentin Kulichenko пишет:
> > Guys,
> >
> > From my experience, Ignite and Spark clusters typically run in the same
> > environment, which makes client node a more preferable option. Mainly,
> > because of performance. BTW, I doubt partition-awareness on thin client
> > will help either, because in dataframes we only run SQL queries and I
> > believe thin client will execute them through a proxy anyway. But correct
> > me if I’m wrong.
> >
> > Either way, it sounds like we just have usability issues with
> Ignite/Spark
> > integration. Why don’t we concentrate on fixing them then? For example,
> #3
> > can be fixed by loading XML content on master and then distributing it to
> > workers, instead of loading on every worker independently. Then there are
> > certain procedures like deploying JARs, etc. First of all, they will
> exist
> > with thin client either. Second of all, I’m sure there are ways to
> simplify
> > this procedures and make integration easier. My opinion is that working
> on
> > such improvements is going to add more value than another implementation
> > based on thin client.
> >
> > -Val
> >
> > On Sat, Oct 20, 2018 at 4:03 PM Denis Magda  wrote:
> >
> > > Hello Nikolay,
> > >
> > > Your proposal sounds reasonable. However, I would suggest us to wait
> while
> > > partition-awareness is supported for Java thin client first. With that
> > > feature, the client can connect to any node directly while presently
> all
> > > the communication goes through a proxy (a node the client is connected
> to).
> > > All of that is bad for performance.
> > >
> > >
> > > Vladimir, how hard would it be to support the partition-awareness for
> Java
> > > client? Probably, Nikolay can take over.
> > >
> > > --
> > > Denis
> > >
> > >
> > > On Sat, Oct 20, 2018 at 2:09 PM Nikolay Izhikov 
> > > wrote:
> > >
> > > > Hello, Igniters.
> 

[GitHub] ignite pull request #4735: Cache 2 stab experiment

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4735


---

Pre-touch for Ignite off-heap memory

[Gerus]

Hi *Igniters*,
Some time ago I've raised a suggestion for product improvement
https://issues.apache.org/jira/browse/IGNITE-9112
  .  It's all about
off-heap memory allocation. Current implementation can have some
improvements for failure critical systems. Ignite can have OOM in runtime,
because RAM can be used by OS, if it will not be pre-booked by operation
system and this proposal is to address that. Common case is offheap and
thats why memory segment cannot be managed by JVM that has +AlwaysPreTouch
option
Obviously this implementation will make startup longer and thats why it is
proposed to use configuration flag to manage this feature
I think, it will be useful to have this option. Are you supporting this?



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: [DISCUSSION] TDE. Phase-2. Master key rotation.

[Nikolay Izhikov]

Hello, Anton.

Thank you for your very usefull feedback!

I accept your proposals.
Seems it makes this feature more robust and clear.

Will update design in confluence in a couple of hours.

В Вт, 23/10/2018 в 19:18 +0300, Anton Vinogradov пишет:
> Nikolay,
> 
> I have some comments.
> 
> 1) Master key setup and removal is a responsibility of system administrator.
> No matter how he will set a new master key or remove an old.
> The only need it to have both keys, new and old, installed before starting
> the rotation process.
> 
> 2) Master Key rotation is a process of cache's keys re-encryption.
> 
> So, we should send a message contains a new master key id only.
> We also have to check that "Master Key rotation" allowed to the user by
> checking it has SecurityPermission#ADMIN_OPS permission.
> 
> During this message handling, we have to re-encrypt keys and to set new
> master key id.
> 
> 3) We should provide recovery mode for nodes unexpectedly leaved cluster
> during "Master Key rotation" process.
> We have to have a special "node start" command allows to change node's
> master key before joining the cluster.
> 
> пн, 22 окт. 2018 г. в 22:39, Nikolay Izhikov :
> 
> > Hello, Igniters.
> > 
> > As you may know, we successfully implement TDE. Phase-1 feature. [1]
> > This improvement allows users to use an encrypted cache.
> > 
> > To make TDE production ready I propose to extend it with two things:
> > 
> > * Master key rotation.
> > * Cache key rotation.
> > 
> > Such features required by many security standards such as PCI DSS [2] and
> > GDPR [3]
> > 
> > I think it would be easier to discuss, implement and review both features
> > separately.
> > So my plan is the following:
> > 
> > * TDE. Phase-2 - Master key rotation [4]
> > * TDE. Phase-3 - Cache key rotation. [5]
> > 
> > I prepared designs for both parts.
> > I want to specifically discuss Phase-2 design.
> > Phase-3 design state is [EARLY DRAFT].
> > I propose to use Phase-3 design as a reference to make sure we have a
> > consistent view of all aspects of TDE
> > and can be implemented without significant changes in earlier parts.
> > 
> > Below, my design.
> > Following changes will be made in confluence [4].
> > Please, share your feedback.
> > 
> > *TDE. PHASE-2. MASTER KEY ROTATION*
> > Key rotation required in case of it compromising or at the end of
> > crypto period(key validity period).
> > 
> > Goal:
> > To implement the ability to rotate master encryption key.
> > 
> > New processes:
> > 1. Master key rotation.
> > 2. Removal of a master key.
> > 
> > New administrator commands:
> > 1. Master keys view: node -> master key hash
> > 2. Cache group keys view: node -> group name -> encryption key
> > hash
> > 
> > MASTER KEY ROTATION:
> > Process start:
> > Administrator initiates key rotation via  some kind of
> > user interface(CLI, Visor, Web Console, JMX, etc).
> > 
> > Process description:
> > Message is sent by discovery.
> > A Message should contain:
> > * Master cache key encrypted with the current
> > master key.
> > 
> > When server node processed message following actions are
> > executed:
> > * Blocks creation of encrypted cache key.
> > * Encrypt cache group keys with new master key.
> > * Unblock creation of encrypted cache key.
> > 
> > New joining node should also change the current master key
> > with the new one.
> > 
> > Process completion:
> > The administrator initiates process completion via the
> > interface by using “master key removal” command.
> > Design assumes an administrator will check that all nodes
> > successfully change master key and all required nodes are alive.
> > 
> > MASTER KEY REMOVAL:
> > Process start:
> > Administrator initiates process via some kind of user
> > interface(CLI, Visor, WebConsole, JMX, etc),
> > 
> > Process description:
> > Message is sent by discovery.
> > Message should contain:
> > * New master key hash.
> > When a server node processed message following actions are
> > executed:
> > Received master key hash compared with known master key
> > hash.
> > Previous master key removed using configured
> > EncryptionSPI.
> > 
> > NEW COMMANDS:
> > Master key hashes.
> > Input: nothing
> > Output: List of Tuples3
> > * Node ID
> > * Current key hash
> > * Previous key hash or null.
> > Cache key hashes.
> > Input: cache id.
> > Output: List of Tuples3
> > * Node ID
> > 

[jira] [Created] (IGNITE-9981) Web Console: We need to update the counters on the tables.

[Vica Abramova (JIRA)]

Vica Abramova created IGNITE-9981:
-

 Summary: Web Console: We need to update the counters on the tables.
 Key: IGNITE-9981
 URL: https://issues.apache.org/jira/browse/IGNITE-9981
 Project: Ignite
  Issue Type: Improvement
  Components: UI, wizards
Reporter: Vica Abramova
Assignee: Alexey Kuznetsov
 Attachments: Renew Table.png





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [DISCUSSION] TDE. Phase-2. Master key rotation.

[Anton Vinogradov]

Nikolay,

I have some comments.

1) Master key setup and removal is a responsibility of system administrator.
No matter how he will set a new master key or remove an old.
The only need it to have both keys, new and old, installed before starting
the rotation process.

2) Master Key rotation is a process of cache's keys re-encryption.

So, we should send a message contains a new master key id only.
We also have to check that "Master Key rotation" allowed to the user by
checking it has SecurityPermission#ADMIN_OPS permission.

During this message handling, we have to re-encrypt keys and to set new
master key id.

3) We should provide recovery mode for nodes unexpectedly leaved cluster
during "Master Key rotation" process.
We have to have a special "node start" command allows to change node's
master key before joining the cluster.

пн, 22 окт. 2018 г. в 22:39, Nikolay Izhikov :

> Hello, Igniters.
>
> As you may know, we successfully implement TDE. Phase-1 feature. [1]
> This improvement allows users to use an encrypted cache.
>
> To make TDE production ready I propose to extend it with two things:
>
> * Master key rotation.
> * Cache key rotation.
>
> Such features required by many security standards such as PCI DSS [2] and
> GDPR [3]
>
> I think it would be easier to discuss, implement and review both features
> separately.
> So my plan is the following:
>
> * TDE. Phase-2 - Master key rotation [4]
> * TDE. Phase-3 - Cache key rotation. [5]
>
> I prepared designs for both parts.
> I want to specifically discuss Phase-2 design.
> Phase-3 design state is [EARLY DRAFT].
> I propose to use Phase-3 design as a reference to make sure we have a
> consistent view of all aspects of TDE
> and can be implemented without significant changes in earlier parts.
>
> Below, my design.
> Following changes will be made in confluence [4].
> Please, share your feedback.
>
> *TDE. PHASE-2. MASTER KEY ROTATION*
> Key rotation required in case of it compromising or at the end of
> crypto period(key validity period).
>
> Goal:
> To implement the ability to rotate master encryption key.
>
> New processes:
> 1. Master key rotation.
> 2. Removal of a master key.
>
> New administrator commands:
> 1. Master keys view: node -> master key hash
> 2. Cache group keys view: node -> group name -> encryption key
> hash
>
> MASTER KEY ROTATION:
> Process start:
> Administrator initiates key rotation via  some kind of
> user interface(CLI, Visor, Web Console, JMX, etc).
>
> Process description:
> Message is sent by discovery.
> A Message should contain:
> * Master cache key encrypted with the current
> master key.
>
> When server node processed message following actions are
> executed:
> * Blocks creation of encrypted cache key.
> * Encrypt cache group keys with new master key.
> * Unblock creation of encrypted cache key.
>
> New joining node should also change the current master key
> with the new one.
>
> Process completion:
> The administrator initiates process completion via the
> interface by using “master key removal” command.
> Design assumes an administrator will check that all nodes
> successfully change master key and all required nodes are alive.
>
> MASTER KEY REMOVAL:
> Process start:
> Administrator initiates process via some kind of user
> interface(CLI, Visor, WebConsole, JMX, etc),
>
> Process description:
> Message is sent by discovery.
> Message should contain:
> * New master key hash.
> When a server node processed message following actions are
> executed:
> Received master key hash compared with known master key
> hash.
> Previous master key removed using configured
> EncryptionSPI.
>
> NEW COMMANDS:
> Master key hashes.
> Input: nothing
> Output: List of Tuples3
> * Node ID
> * Current key hash
> * Previous key hash or null.
> Cache key hashes.
> Input: cache id.
> Output: List of Tuples3
> * Node ID
> * Current key hash
> * Previous key hash or null.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-8260
> [2] https://www.pcisecuritystandards.org/documents/PCI_DSS_v3-2-1.pdf
> [3] https://gdpr-info.eu/
> [4]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652381
> [5]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652384
>

Re: Code inspection

[Nikolay Izhikov]

Hello, Maxim.

+1 from me.

I vote to enable static inspections for the Ignite codebase.
Thank you for that contributions!

В Вт, 23/10/2018 в 19:09 +0300, Maxim Muzafarov пишет:
> Igniters,
> 
> I've fixed some issues according to the inspections.xml configuration:
>  - `Missorted modifiers`;
>  - `'size() == 0' replaceable with 'isEmpty()'`;
>  - `Add missing @Override annotation`;
> These one have `In progress` state:
>  - `Fix unused imports`;
>  - `Remove unnecessary @SuppressWarnings annotation`;
> 
> The list of issues related to the current Code Inspections changes can be
> found [1]
> with using label `inspections`. So, to move forward and not lose current
> changes I
> propose to:
>  - Create the new configuration idea\ignite_inspections_teamcity.xml (I
> will file a new issue for it);
>  - Tune `Inspections: Core` Suite to use this configuration profile (It
> will run with each PR);
>  - In the case with fixing a new inspection rule enable it this inspection
> configuration.
> 
> This will allow us to move forward in small steps and at some point of time
> in future we will switch
> this ignite_inspections_teamcity.xml with the
> default ignite_inspections.xml.
> 
> Thoughts?
> Pert Ivanov, will you help to tune `Inspections: Core` suite?
> 
> [1]
> https://issues.apache.org/jira/browse/IGNITE-9923?jql=project%20%3D%20Ignite%20AND%20labels%20%3D%20inspections
> 
> On Sat, 25 Aug 2018 at 00:54 Dmitriy Pavlov  wrote:
> 
> > IntelliJ Idea shows missing @Override annotation on my installation. Not
> > sure it comes from our inspection or not.
> > 
> > Anyway, count on me.
> > 
> > пт, 24 авг. 2018 г. в 9:25, Maxim Muzafarov :
> > 
> > > Folks,
> > > 
> > > I think we can make a small step further with Ignite Inspections.
> > > 
> > > I've created these tickets [1], [2] for myself according to previously
> > > added
> > > `idea/ignite_inspections.xml` and I plan to complete them.
> > > 
> > > Who will help me with review and merge?
> > > 
> > > [1] https://issues.apache.org/jira/browse/IGNITE-9311 - Add missing
> > > @Override annotation
> > > [2] https://issues.apache.org/jira/browse/IGNITE-9312 - Remove
> > 
> > unnecessary
> > > @SuppressWarnings annotation
> > > 
> > > On Thu, 16 Aug 2018 at 19:53 Dmitriy Pavlov 
> > 
> > wrote:
> > > 
> > > > Hi Pavel,
> > > > 
> > > > Thank you for noticing and bringing it here. I've fixed TC failure.
> > > > 
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > > 
> > > > чт, 16 авг. 2018 г. в 0:10, Pavel Pereslegin :
> > > > 
> > > > > Hello Igniters.
> > > > > 
> > > > > It seems that "idea/ignite_inspections.xml" should be excluded from
> > > > > "check-licenses" maven profile, because "_Licenses Headers_"
> > > > > configuration always fails now [1] on TeamCity.
> > > > > 
> > > > > [1]
> > > > > 
> > 
> > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_LicensesHeaders=buildTypeHistoryList_IgniteTests24Java8=%3Cdefault%3E
> > > > > ср, 15 авг. 2018 г. в 20:49, Dmitriy Pavlov :
> > > > > > 
> > > > > > I've updated wiki page
> > > > > > 
> > 
> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-C.CodeInspection
> > > > > > with
> > > > > > reference to settings.xml placement in the project.
> > > > > > 
> > > > > > It is only advice, so I hope you don't mind having this reference.
> > > > > > 
> > > > > > ср, 15 авг. 2018 г. в 16:45, Dmitriy Pavlov  > > 
> > > :
> > > > > > 
> > > > > > > Hi Maxim,
> > > > > > > 
> > > > > > > Thank you for stepping in. I've committed the first version here
> > > > > > > 'idea/ignite_inspections.xml'. We can move it to project default
> > > > 
> > > > later
> > > > > when
> > > > > > > all inspection problems are fixed.
> > > > > > > Commit:
> > > > > > > 
> > > > > > > 
> > 
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3e0f04edf7cc0aa1631fbd1b9af1e9b87b697eb1
> > > > > > > 
> > > > > > > 
> > > > > > > Igniters,
> > > > > > > 
> > > > > > > you can enable this profile using the following steps:
> > 
> > Inspections
> > > > > > > (icon)->Configure inspections->(settings button)->Import
> > > > > 
> > > > > Profile->select
> > > > > > > file and import.
> > > > > > > 
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > > 
> > > > > > > вт, 14 авг. 2018 г. в 16:31, Maxim Muzafarov  > > 
> > > :
> > > > > > > 
> > > > > > > > Dmitry and other Igniters,
> > > > > > > > 
> > > > > > > > Previously you has suggested to commit `Code Inspections` into
> > > > 
> > > > Ignite
> > > > > > > > codebase.
> > > > > > > > It makes sense for me. I think it's the easiest way to share
> > 
> > this
> > > > > profile
> > > > > > > > among community
> > > > > > > > members and this inspection can be set as for the project level.
> > > > > > > > So, I suggest:
> > > > > > > > 
> > > > > > > > 1) According to Jetbrains documentation [1] the inspection
> > 
> > profile
> > > > > can be
> > > > > > > > placed to
> > > > > > > > 

[GitHub] ignite pull request #4869: IGNITE-9282 Add Gaussian Naive Bayes Classifier

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4869


---

Re: Code inspection

[Maxim Muzafarov]

Igniters,

I've fixed some issues according to the inspections.xml configuration:
 - `Missorted modifiers`;
 - `'size() == 0' replaceable with 'isEmpty()'`;
 - `Add missing @Override annotation`;
These one have `In progress` state:
 - `Fix unused imports`;
 - `Remove unnecessary @SuppressWarnings annotation`;

The list of issues related to the current Code Inspections changes can be
found [1]
with using label `inspections`. So, to move forward and not lose current
changes I
propose to:
 - Create the new configuration idea\ignite_inspections_teamcity.xml (I
will file a new issue for it);
 - Tune `Inspections: Core` Suite to use this configuration profile (It
will run with each PR);
 - In the case with fixing a new inspection rule enable it this inspection
configuration.

This will allow us to move forward in small steps and at some point of time
in future we will switch
this ignite_inspections_teamcity.xml with the
default ignite_inspections.xml.

Thoughts?
Pert Ivanov, will you help to tune `Inspections: Core` suite?

[1]
https://issues.apache.org/jira/browse/IGNITE-9923?jql=project%20%3D%20Ignite%20AND%20labels%20%3D%20inspections

On Sat, 25 Aug 2018 at 00:54 Dmitriy Pavlov  wrote:

> IntelliJ Idea shows missing @Override annotation on my installation. Not
> sure it comes from our inspection or not.
>
> Anyway, count on me.
>
> пт, 24 авг. 2018 г. в 9:25, Maxim Muzafarov :
>
> > Folks,
> >
> > I think we can make a small step further with Ignite Inspections.
> >
> > I've created these tickets [1], [2] for myself according to previously
> > added
> > `idea/ignite_inspections.xml` and I plan to complete them.
> >
> > Who will help me with review and merge?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-9311 - Add missing
> > @Override annotation
> > [2] https://issues.apache.org/jira/browse/IGNITE-9312 - Remove
> unnecessary
> > @SuppressWarnings annotation
> >
> > On Thu, 16 Aug 2018 at 19:53 Dmitriy Pavlov 
> wrote:
> >
> > > Hi Pavel,
> > >
> > > Thank you for noticing and bringing it here. I've fixed TC failure.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > чт, 16 авг. 2018 г. в 0:10, Pavel Pereslegin :
> > >
> > > > Hello Igniters.
> > > >
> > > > It seems that "idea/ignite_inspections.xml" should be excluded from
> > > > "check-licenses" maven profile, because "_Licenses Headers_"
> > > > configuration always fails now [1] on TeamCity.
> > > >
> > > > [1]
> > > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_LicensesHeaders=buildTypeHistoryList_IgniteTests24Java8=%3Cdefault%3E
> > > > ср, 15 авг. 2018 г. в 20:49, Dmitriy Pavlov :
> > > > >
> > > > > I've updated wiki page
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-C.CodeInspection
> > > > > with
> > > > > reference to settings.xml placement in the project.
> > > > >
> > > > > It is only advice, so I hope you don't mind having this reference.
> > > > >
> > > > > ср, 15 авг. 2018 г. в 16:45, Dmitriy Pavlov  >:
> > > > >
> > > > > > Hi Maxim,
> > > > > >
> > > > > > Thank you for stepping in. I've committed the first version here
> > > > > > 'idea/ignite_inspections.xml'. We can move it to project default
> > > later
> > > > when
> > > > > > all inspection problems are fixed.
> > > > > > Commit:
> > > > > >
> > > > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3e0f04edf7cc0aa1631fbd1b9af1e9b87b697eb1
> > > > > >
> > > > > >
> > > > > > Igniters,
> > > > > >
> > > > > > you can enable this profile using the following steps:
> Inspections
> > > > > > (icon)->Configure inspections->(settings button)->Import
> > > > Profile->select
> > > > > > file and import.
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > вт, 14 авг. 2018 г. в 16:31, Maxim Muzafarov  >:
> > > > > >
> > > > > >> Dmitry and other Igniters,
> > > > > >>
> > > > > >> Previously you has suggested to commit `Code Inspections` into
> > > Ignite
> > > > > >> codebase.
> > > > > >> It makes sense for me. I think it's the easiest way to share
> this
> > > > profile
> > > > > >> among community
> > > > > >> members and this inspection can be set as for the project level.
> > > > > >> So, I suggest:
> > > > > >>
> > > > > >> 1) According to Jetbrains documentation [1] the inspection
> profile
> > > > can be
> > > > > >> placed to
> > > > > >> `/.idea/inspectionProfiles` with name
> > `Project_Default.xml`
> > > > > >> (hope most of us using IDEA for development)
> > > > > >> This allows enable this profile automatically on per project
> level
> > > and
> > > > > >> will
> > > > > >> simplify
> > > > > >> development process according to rules accepted by our
> community.
> > > > > >>
> > > > > >> 2) I can file tickets and do some of them to fix inspection
> > failures
> > > > which
> > > > > >> Alexey mentioned
> > > > > >> earlier. Hope other members of community will help me with it.
> > 

[jira] [Created] (IGNITE-9980) Modify ./control.sh --cache idle_verify --dump to print only persistante cache or add flag --persistentOnly

[ARomantsov (JIRA)]

ARomantsov created IGNITE-9980:
--

 Summary: Modify ./control.sh --cache idle_verify --dump to print 
only persistante cache or add flag --persistentOnly
 Key: IGNITE-9980
 URL: https://issues.apache.org/jira/browse/IGNITE-9980
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.6
Reporter: ARomantsov


It will be cool , if control.sh --cache idle_verify can show 
persistent/not-persistent/both caches and it will be impliments due utility flag



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9979) [ML] Implement Naive Bayes classifier over Discrete Disctribution

[Alexey Platonov (JIRA)]

Alexey Platonov created IGNITE-9979:
---

 Summary: [ML] Implement Naive Bayes classifier over Discrete 
Disctribution
 Key: IGNITE-9979
 URL: https://issues.apache.org/jira/browse/IGNITE-9979
 Project: Ignite
  Issue Type: Sub-task
  Components: ml
Reporter: Alexey Platonov
 Fix For: 2.8


There is need to create Naive Bayes classifier over simple Discrete 
Distribution for non-continuous features in dataset. As naive implementation it 
may be set of histograms of feature values for each feature in dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9978) [ML] Implement Compound Naive Bayes classifier

[Alexey Platonov (JIRA)]

Alexey Platonov created IGNITE-9978:
---

 Summary: [ML] Implement Compound Naive Bayes classifier
 Key: IGNITE-9978
 URL: https://issues.apache.org/jira/browse/IGNITE-9978
 Project: Ignite
  Issue Type: Task
  Components: ml
Reporter: Alexey Platonov
 Fix For: 2.8


We need to create compound Naive Bayes classifier as model composition of 
several Naive Bayes classifiers where each classifier represents subset of 
features of one type. For example such model may contain Naive Bayes model over 
Gauss Distribution for all continuous features and Naive Bayes model over 
Discrete Distribution for enum-like features.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [MTCGA]: new failures in builds [2123440] needs to be handled

[Alexey Goncharuk]

All,

We had to revert the commit because the fix appeared to be more complex
than we expected. Tests should be ok now.

вт, 23 окт. 2018 г. в 11:20, Alexey Goncharuk :

> Hi all,
>
> We are working on the fix, it should be merged to master asap.
>
> вт, 23 окт. 2018 г. в 11:18, Maxim Muzafarov :
>
>> Hello,
>>
>> Are there any updates?
>> The build constantly fails with `Execution timeout` in the master branch
>> since October 20.
>>
>> The problem commit supposed to be related to the [2] issue and I think the
>> probable `IgniteSqlSplitterSelfTest#testPushDown` test fails with
>> excpetion:
>>
>> class org.apache.ignite.binary.BinaryObjectException: Failed to register
>> class.
>> at
>>
>> org.apache.ignite.internal.binary.BinaryContext.registerUserClassName(BinaryContext.java:1249)
>> at
>>
>> org.apache.ignite.internal.binary.BinaryContext.registerUserClassDescriptor(BinaryContext.java:798)
>> at
>>
>> org.apache.ignite.internal.binary.BinaryContext.registerClassDescriptor(BinaryContext.java:775)
>>
>> and the whole suite hungs.
>>
>> [1]
>>
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=buildTypeStatusDiv_IgniteTests24Java8=%3Cdefault%3E
>> [2] https://issues.apache.org/jira/browse/IGNITE-5795
>>
>> On Sun, 21 Oct 2018 at 08:30 Павлухин Иван  wrote:
>>
>> > Hi Anton,
>> >
>> > I ran a problematic build against my contribution [1] and it seems to
>> pass
>> > fine. Then I ran the build against your PR branch and it hanged [2].
>> > There is nothing surprising that it fired only in master because the
>> build
>> > was added to RunAll after your PR runs.
>> > Could you please take a look?
>> >
>> > [1] https://ci.ignite.apache.org/viewLog.html?buildId=2127238;
>> > [2]
>> >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=2127232=buildResultsDiv=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries
>> >
>> > сб, 20 окт. 2018 г. в 10:30, :
>> >
>> > > Hi Igniters,
>> > >
>> > >  I've detected some new issue on TeamCity to be handled. You are more
>> > than
>> > > welcomed to help.
>> > >
>> > >  If your changes can lead to this failure(s): We're grateful that you
>> > were
>> > > a volunteer to make the contribution to this project, but things
>> change
>> > and
>> > > you may no longer be able to finalize your contribution.
>> > >  Could you respond to this email and indicate if you wish to continue
>> and
>> > > fix test failures or step down and some committer may revert you
>> commit.
>> > >
>> > >  *New Critical Failure in master Queries (Binary Objects Simple
>> > > Mapper)
>> > >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=%3Cdefault%3E=buildTypeStatusDiv
>> > >  Changes may lead to failure were done by
>> > >  - kaa.dev
>> > >
>> >
>> http://ci.ignite.apache.org/viewModification.html?modId=835798=false
>> > >  - vololo100
>> > >
>> >
>> http://ci.ignite.apache.org/viewModification.html?modId=835794=false
>> > >
>> > >  - Here's a reminder of what contributors were agreed to do
>> > > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>> > >  - Should you have any questions please contact
>> > > dev@ignite.apache.org
>> > >
>> > > Best Regards,
>> > > Apache Ignite TeamCity Bot
>> > > https://github.com/apache/ignite-teamcity-bot
>> > > Notification generated at 10:30:43 20-10-2018
>> > >
>> >
>> >
>> > --
>> > Best regards,
>> > Ivan Pavlukhin
>> >
>> --
>> --
>> Maxim Muzafarov
>>
>

[jira] [Created] (IGNITE-9977) Design & implement integration Ignite with SSL/TLS Certification Authority Center

[Yuriy Sergeev (JIRA)]

Yuriy Sergeev created IGNITE-9977:
-

 Summary: Design & implement integration Ignite with SSL/TLS 
Certification Authority Center
 Key: IGNITE-9977
 URL: https://issues.apache.org/jira/browse/IGNITE-9977
 Project: Ignite
  Issue Type: Task
  Components: security
Reporter: Yuriy Sergeev






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #4521: GG-13254 Snapshots: Only Full snapshot should be ...

[a-polyakov]

Github user a-polyakov closed the pull request at:

https://github.com/apache/ignite/pull/4521


---

Re: NodeJS thin client: full API

[Stepan Pilshchikov]

Alexey,

I'm trying to get Enum from cache which placed by different thin client and
find that i can't get it, only exception

And more when im trying to get Enum which is placed by nodejs client i also
can't do it, have same exception

code and output -
https://gist.github.com/pilshchikov/ca9fda160e310f62dd4d1d6dbb2f904c

Can you please help me to investigate it, maybe something im doing wrong,
because its look like a bug



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: PHP thin client

[Stepan Pilschikov]

And more,

If im use  ->setValueType(ObjectType::ENUM) during $cache->get(1);
it throwing exception that client can't convert BINARY_ENUM to ENUM

вт, 23 окт. 2018 г. в 15:57, Stepan Pilschikov :

> Thanks, finally fixes are merged
>
> I have new question
>
> I'm trying to put Enum object and get it back, but catch exception that
> enum is null
>
> code with output -
> https://gist.github.com/pilshchikov/b89c6e25f29da88ac03caa42231a02bc
>
> Also can't find Enum data type test in sources
>
> I trying to use Enum in a right way? If answer is Yes, can you please
> check this for yourself?
> I think its a bug
>
> вс, 21 окт. 2018 г. в 9:36, Pavel Petroshenko :
>
>> Hi Stepan,
>>
>> I submitted a patch and updated JIRA with some comments. Can you please
>> give it a try?
>>
>> Thanks,
>> P.
>>
>>
>> On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov <
>> pilshchikov@gmail.com> wrote:
>>
>>> Alexey,
>>>
>>> Hi
>>>
>>> I'm trying to use PHP client for some times and discover one problem with
>>> DATA and TIMESTAMP data types
>>> I'ts appear when you trying to use DATA or TIMESTAMP as cache key
>>>
>>> All description in ticket:
>>> https://issues.apache.org/jira/browse/IGNITE-9951
>>>
>>> Can you help with that, please?
>>>
>>> чт, 11 окт. 2018 г. в 16:02, Igor Sapego :
>>>
>>> > Alexey,
>>> >
>>> > Since PHP thin client is now in master, can you please add it to our
>>> > "Thin clients features" wiki page, so we can track the feature parity
>>> > of our clients?
>>> >
>>> > [1] -
>>> >
>>> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>>> >
>>> > Best Regards,
>>> > Igor
>>> >
>>> >
>>> > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov 
>>> > wrote:
>>> >
>>> > > I am not sure there is an answer. This is just how we handled it
>>> before.
>>> > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
>>> > > several hours ago.
>>> > >
>>> > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego 
>>> wrote:
>>> > >
>>> > >> Vyacheslav,
>>> > >>
>>> > >> In this case, we should do the same with all existing doxygen
>>> > >> files, not only this one (see files with .dxg extension)
>>> > >>
>>> > >> Vova, Pavel,
>>> > >>
>>> > >> Were there historically any reasons to exclude doxygen files
>>> > >> from check instead of adding a license header?
>>> > >>
>>> > >> Best Regards,
>>> > >> Igor
>>> > >>
>>> > >>
>>> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <
>>> daradu...@gmail.com
>>> > >
>>> > >> wrote:
>>> > >>
>>> > >>> Great work guys, thanks!
>>> > >>>
>>> > >>> I've noticed TC fails in the build plan "Licenses Headers" which
>>> Igor
>>> > >>> have fixed already by excluding Doxyfile from checking.
>>> > >>>
>>> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another
>>> > >>> way by adding the license header to Doxyfile.
>>> > >>>
>>> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>> > >>>
>>> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>>> > >>> [2] https://github.com/apache/ignite/pull/4938/files
>>> > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>>> > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego 
>>> wrote:
>>> > >>> >
>>> > >>> > As the seem to be everything OK with the code and tests and
>>> > >>> > no one had any comment for quite some time, I've merged the
>>> > >>> > PHP to Ignite's master.
>>> > >>> >
>>> > >>> > Great job, guys!
>>> > >>> >
>>> > >>> >
>>> > >>> > Best Regards,
>>> > >>> > Igor
>>> > >>> >
>>> > >>> >
>>> > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg 
>>> > >>> wrote:
>>> > >>> >
>>> > >>> > > Hi Stephan, Alexey
>>> > >>> > >
>>> > >>> > > That's exactly what readme.io contains - installation
>>> > instructions,
>>> > >>> > > configuration, and examples for key-value, sql, etc. for thin
>>> > >>> clients. For
>>> > >>> > > example, see these documentation pages for Node.js (currently
>>> > hidden
>>> > >>> in the
>>> > >>> > > latest version of the doc) :
>>> > >>> > >
>>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>>> > >>> > >
>>> > >>> > >
>>> > >>>
>>> >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>>> > >>> > >
>>> > >>>
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>>> > >>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>>> > >>> > >
>>> > >>>
>>> >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>>> > >>> > >
>>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>>> > >>> > >
>>> > >>> > > This how Python and PHP thin clients will also be documented on
>>> > >>> readme.io
>>> > >>> > >
>>> > >>> > > -Prachi
>>> > >>> > >
>>> > >>> > >
>>> > >>> > >
>>> > >>> > >
>>> > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>>> > >>> > > pilshchikov@gmail.com> wrote:
>>> > >>> > >
>>> > >>> > > > > You know, I'm confused with all this documentation 

Re: PHP thin client

[Stepan Pilschikov]

Thanks, finally fixes are merged

I have new question

I'm trying to put Enum object and get it back, but catch exception that
enum is null

code with output -
https://gist.github.com/pilshchikov/b89c6e25f29da88ac03caa42231a02bc

Also can't find Enum data type test in sources

I trying to use Enum in a right way? If answer is Yes, can you please check
this for yourself?
I think its a bug

вс, 21 окт. 2018 г. в 9:36, Pavel Petroshenko :

> Hi Stepan,
>
> I submitted a patch and updated JIRA with some comments. Can you please
> give it a try?
>
> Thanks,
> P.
>
>
> On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov <
> pilshchikov@gmail.com> wrote:
>
>> Alexey,
>>
>> Hi
>>
>> I'm trying to use PHP client for some times and discover one problem with
>> DATA and TIMESTAMP data types
>> I'ts appear when you trying to use DATA or TIMESTAMP as cache key
>>
>> All description in ticket:
>> https://issues.apache.org/jira/browse/IGNITE-9951
>>
>> Can you help with that, please?
>>
>> чт, 11 окт. 2018 г. в 16:02, Igor Sapego :
>>
>> > Alexey,
>> >
>> > Since PHP thin client is now in master, can you please add it to our
>> > "Thin clients features" wiki page, so we can track the feature parity
>> > of our clients?
>> >
>> > [1] -
>> >
>> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>> >
>> > Best Regards,
>> > Igor
>> >
>> >
>> > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov 
>> > wrote:
>> >
>> > > I am not sure there is an answer. This is just how we handled it
>> before.
>> > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
>> > > several hours ago.
>> > >
>> > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego 
>> wrote:
>> > >
>> > >> Vyacheslav,
>> > >>
>> > >> In this case, we should do the same with all existing doxygen
>> > >> files, not only this one (see files with .dxg extension)
>> > >>
>> > >> Vova, Pavel,
>> > >>
>> > >> Were there historically any reasons to exclude doxygen files
>> > >> from check instead of adding a license header?
>> > >>
>> > >> Best Regards,
>> > >> Igor
>> > >>
>> > >>
>> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <
>> daradu...@gmail.com
>> > >
>> > >> wrote:
>> > >>
>> > >>> Great work guys, thanks!
>> > >>>
>> > >>> I've noticed TC fails in the build plan "Licenses Headers" which
>> Igor
>> > >>> have fixed already by excluding Doxyfile from checking.
>> > >>>
>> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another
>> > >>> way by adding the license header to Doxyfile.
>> > >>>
>> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>> > >>>
>> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>> > >>> [2] https://github.com/apache/ignite/pull/4938/files
>> > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>> > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego 
>> wrote:
>> > >>> >
>> > >>> > As the seem to be everything OK with the code and tests and
>> > >>> > no one had any comment for quite some time, I've merged the
>> > >>> > PHP to Ignite's master.
>> > >>> >
>> > >>> > Great job, guys!
>> > >>> >
>> > >>> >
>> > >>> > Best Regards,
>> > >>> > Igor
>> > >>> >
>> > >>> >
>> > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg 
>> > >>> wrote:
>> > >>> >
>> > >>> > > Hi Stephan, Alexey
>> > >>> > >
>> > >>> > > That's exactly what readme.io contains - installation
>> > instructions,
>> > >>> > > configuration, and examples for key-value, sql, etc. for thin
>> > >>> clients. For
>> > >>> > > example, see these documentation pages for Node.js (currently
>> > hidden
>> > >>> in the
>> > >>> > > latest version of the doc) :
>> > >>> > >
>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>> > >>> > >
>> > >>> > >
>> > >>>
>> >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>> > >>> > >
>> > >>>
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>> > >>> > >
>> > >>>
>> >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>> > >>> > >
>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>> > >>> > >
>> > >>> > > This how Python and PHP thin clients will also be documented on
>> > >>> readme.io
>> > >>> > >
>> > >>> > > -Prachi
>> > >>> > >
>> > >>> > >
>> > >>> > >
>> > >>> > >
>> > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>> > >>> > > pilshchikov@gmail.com> wrote:
>> > >>> > >
>> > >>> > > > > You know, I'm confused with all this documentation stuff...
>> > >>> > > > > For nodejs client all docs were moved from the repo to
>> > readme.io
>> > >>> but
>> > >>> > > > the
>> > >>> > > > > readme.md keeps the installation instructions (duplicated
>> with
>> > >>> > > > > readme.io). Probably, that's ok.
>> > >>> > > > > Will add similar short readme.md to the PHP PR.
>> > >>> > > >
>> > >>> > > > Its good
>> > >>> > > 

[GitHub] ignite pull request #5058: IGNITE-8867

[artemmalykh]

GitHub user artemmalykh opened a pull request:

https://github.com/apache/ignite/pull/5058

IGNITE-8867



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8867

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5058


commit 7a51c29b24b2cff8e3095d0aa98819637f469c9e
Author: Artem Malykh 
Date:   2018-10-04T17:08:17Z

IGNITE-8867: First draft.

commit 2363fa781363f9d5fc1f4f9447cc4eebd0564d6e
Author: Artem Malykh 
Date:   2018-10-09T16:59:53Z

Tests

commit e6a47fcbd37e99cb861f5e5cf46b6887936b0063
Author: Artem Malykh 
Date:   2018-10-10T14:45:07Z

WIP

commit 53c80adad1f3ec3298ab370a656899305eb4e98a
Author: Artem Malykh 
Date:   2018-10-13T14:03:27Z

WIP

commit aef7879400b5a06ab1cabb0d4de07c1d71ad3778
Author: Artem Malykh 
Date:   2018-10-15T14:43:45Z

WIP

commit b08297a6abc630391a6388e46f552bc03835dec4
Author: Artem Malykh 
Date:   2018-10-16T15:16:57Z

WIP

commit 0d646a4183ba591b2a9fd5146d7bfc6a21ab57ea
Author: Artem Malykh 
Date:   2018-10-17T12:02:24Z

WIP

commit 6c2fe313e89ddc3209ad284240b8ae6813448aca
Author: Artem Malykh 
Date:   2018-10-22T13:04:03Z

WIP

commit 5cbf973623f5c29cf7b430cd6b0ff9c4022e38bd
Author: Artem Malykh 
Date:   2018-10-22T13:09:48Z

Merge branch 'master-apache' into ignite-8867

commit 8447e75a254c6e7793bf668ca587903ca85e6300
Author: Artem Malykh 
Date:   2018-10-23T11:08:54Z

WIP




---

[GitHub] ignite pull request #4857: IGNITE-9632 implementation

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4857


---

[GitHub] ignite pull request #5057: IGNITE-9928

[gvvinblade]

GitHub user gvvinblade opened a pull request:

https://github.com/apache/ignite/pull/5057

IGNITE-9928



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9928

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5057


commit 3c1bd42aa09f6be3422c270e66ff0b3bbc3599d3
Author: Igor Seliverstov 
Date:   2018-10-23T12:05:29Z

pending

commit 995edf46556bf14c736d0b8c551d9f04eefca995
Author: Igor Seliverstov 
Date:   2018-10-23T12:05:37Z

Merge branch 'master' into ignite-9928




---

[GitHub] ignite pull request #5018: IGNITE-9663: Data node failure can cause TX hangi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/5018


---

Re: Apache Ignite 2.7. Last Mile

[Nikolay Izhikov]

Hello, Dmitriy.

I'm OK with including this patch to 2.7.

Can you ensure it completely fix the issue?
I left comment in ticket.

https://issues.apache.org/jira/browse/IGNITE-9854?focusedCommentId=16660516=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16660516


В Вт, 23/10/2018 в 13:10 +0300, Dmitriy Govorukhin пишет:
> Nikolay,
> 
> I have an issue which I want to include in 2.7 release,
> https://issues.apache.org/jira/browse/IGNITE-9854
> It is a very small fix but very important, it protects us from NPE in some
> race scenario.
> Changes already in master, but the issue still not resolve, need your
> approval for cherry-picking changes to ignite-2.7.
> 
> On Tue, Oct 23, 2018 at 10:51 AM Vladimir Ozerov 
> wrote:
> 
> > Igniters,
> > 
> > There are still tickets in the scope as we continue finding new issues
> > during QA. I propose the following plan: if there are still opened issues
> > by Friday, then shift vote date for 1 week, to 2nd November. This is needed
> > to ensure that product quality is sufficient. But if the backlog is empty
> > by Friday, we can go ahead with vote.
> > 
> > Thoughts?
> > 
> > On Tue, Oct 23, 2018 at 10:41 AM Nikolay Izhikov 
> > wrote:
> > 
> > > Hello, Igniters.
> > > 
> > > We have 7 tickets mapped to 2.7 today.
> > > 
> > > Igov Seliverstov  - IGNITE-9892 - MVCC: Exchange hangs on mvcc
> > 
> > coordinator
> > > fail
> > > Igor Seliverstov  - IGNITE-9911 -
> > > 
> > 
> > CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx
> > > periodically hangs
> > > Roman Kondakov- IGNITE-9928 - MVCC TX: Bug in SQL query mapping.
> > > Roman Kondakov- IGNITE-9663 - MVCC: Data node failure can cause TX
> > > hanging.
> > > Vladimir Ozerov   - IGNITE-9960 - SQL: Revert and reopen lazy flag
> > > optimization (IGNITE-9171)
> > > Pavel Petroshenko - IGNITE-9951 - thin php: Date data type cut nanos
> > > Peter Ivanov  - IGNITE-9953 - Dropping hadoop accelerator downloads
> > > 
> > > 
> > > В Вс, 21/10/2018 в 11:23 +0300, Nikolay Izhikov пишет:
> > > > Hell, Denis.
> > > > 
> > > > I just filter all 2.7 tickets without documentation.
> > > > 
> > > > 
> > > > 
> > 
> > https://issues.apache.org/jira/browse/IGNITE-9932?jql=(project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.7%27)%20AND%20status%20NOT%20IN%20(Resolved%2C%20Closed)%20and%20(component%20is%20null%20or%20component%20NOT%20IN%20(documentation)))%20ORDER%20BY%20%20priority%20%20%20%20%20%20%20%20%20%20%20%20%20%20
> > > > 
> > > > I've added this view to the release page.
> > > > See sesction "Unresolved tickets(without documentation)".
> > > > 
> > > > В Сб, 20/10/2018 в 16:04 -0700, Denis Magda пишет:
> > > > > Nikolay,
> > > > > 
> > > > > Where do you track those 8 blockers? Can't find them on this wiki
> > 
> > page:
> > > > > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7
> > > > > 
> > > > > --
> > > > > Denis
> > > > > 
> > > > > On Sat, Oct 20, 2018 at 11:31 AM Nikolay Izhikov <
> > 
> > nizhi...@apache.org>
> > > > > wrote:
> > > > > 
> > > > > > Hello, Denis.
> > > > > > 
> > > > > > As a first time release manager I'm trying to rely on Ignite
> > 
> > veterans
> > > > > > opinion.
> > > > > > Guys told me that we must fix all blockers and only after it make
> > 
> > the
> > > > > > release.
> > > > > > 
> > > > > > Let's fix them all.
> > > > > > What do you think?
> > > > > > 
> > > > > > > When are we sending a release candidate for vote?
> > > > > > 
> > > > > > When all blocker bugs will be fixed.
> > > > > > Currently, we have *8*.
> > > > > > 
> > > > > > В Пт, 19/10/2018 в 13:50 -0700, Denis Magda пишет:
> > > > > > > Guys, as a side observer of the current release, this all looks
> > > 
> > > like a
> > > > > > > never ending story :)
> > > > > > > 
> > > > > > > When are we sending a release candidate for vote?
> > > > > > > 
> > > > > > > --
> > > > > > > Denis
> > > > > > > 
> > > > > > > On Fri, Oct 19, 2018 at 4:39 AM Nikolay Izhikov <
> > > 
> > > nizhi...@apache.org>
> > > > > > 
> > > > > > wrote:
> > > > > > > 
> > > > > > > > Hello, Igniters.
> > > > > > > > 
> > > > > > > > We have 6 tickets for 2.7
> > > > > > > > 
> > > > > > > > Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928
> > > > > > > > Igor Seliverstov - IGNITE-9911
> > > > > > > > Ivan Pavlukhin - IGNITE-5935, IGNITE-9944
> > > > > > > > 
> > > > > > > > В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет:
> > > > > > > > > I have got one more potential 2.7 blocker [1] with
> > > 
> > > straightforward
> > > > > > 
> > > > > > fix. I
> > > > > > > > > beleive it will not break any production use case, but it
> > > 
> > > leads to
> > > > > > 
> > > > > > test
> > > > > > > > > suite hang, thus affecting other urgent issues.
> > > > > > > > > 
> > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9932
> > > > > > > > > 
> > > > > > > > > чт, 18 окт. 2018 г. в 14:59, Ivan 

[GitHub] ignite pull request #5056: IGNITE-9976

[xtern]

GitHub user xtern opened a pull request:

https://github.com/apache/ignite/pull/5056

IGNITE-9976



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xtern/ignite IGNITE-9976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5056


commit c24984e0bdb53cc3c4d9814a8efaa93132de056d
Author: pereslegin-pa 
Date:   2018-10-23T11:54:27Z

IGNITE-9976 Flaky failure fix.




---

[jira] [Created] (IGNITE-9976) [Test Failed] BinaryMetadataUpdatesFlowTest.testFlowNoConflicts flaky fails on TC.

[Pavel Pereslegin (JIRA)]

Pavel Pereslegin created IGNITE-9976:


 Summary: [Test Failed] 
BinaryMetadataUpdatesFlowTest.testFlowNoConflicts flaky fails on TC.
 Key: IGNITE-9976
 URL: https://issues.apache.org/jira/browse/IGNITE-9976
 Project: Ignite
  Issue Type: Bug
Reporter: Pavel Pereslegin
Assignee: Pavel Pereslegin


Test {{BinaryMetadataUpdatesFlowTest.testFlowNoConflicts}} fails sometimes on 
master branch.
Example of recent failure:
https://ci.ignite.apache.org/viewLog.html?buildId=2136137=buildResultsDiv=IgniteTests24Java8_BinaryObjects#testNameId-3561618975502992496
Typical output:
{noformat}
[2018-10-20 16:26:55,321][ERROR][main][root] Test failed.
junit.framework.AssertionFailedError: There are less than expected entries, 
data loss occurred; expected:<5000> but was:<4108>
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.failNotEquals(Assert.java:329)
at junit.framework.Assert.assertEquals(Assert.java:78)
at junit.framework.Assert.assertEquals(Assert.java:234)
at junit.framework.TestCase.assertEquals(TestCase.java:401)
at 
org.apache.ignite.internal.processors.cache.binary.BinaryMetadataUpdatesFlowTest.testFlowNoConflicts(BinaryMetadataUpdatesFlowTest.java:309)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:176)
at 
org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2176)
at 
org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:142)
at 
org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2091)
at java.lang.Thread.run(Thread.java:748)
{noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9974) Drop Hadoop assemblies

[Peter Ivanov (JIRA)]

Peter Ivanov created IGNITE-9974:


 Summary: Drop Hadoop assemblies
 Key: IGNITE-9974
 URL: https://issues.apache.org/jira/browse/IGNITE-9974
 Project: Ignite
  Issue Type: Improvement
Affects Versions: 2.7
Reporter: Peter Ivanov
Assignee: Peter Ivanov
 Fix For: 2.8


After dropping Hadoop binaries from release delivery (see IGNITE-9953) it is 
required to drop assemblies and corresponding files / profiles if exist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9975) Possible data loss during starting of the nodes with empty pds

[Andrey Aleksandrov (JIRA)]

Andrey Aleksandrov created IGNITE-9975:
--

 Summary: Possible data loss during starting of the nodes with 
empty pds
 Key: IGNITE-9975
 URL: https://issues.apache.org/jira/browse/IGNITE-9975
 Project: Ignite
  Issue Type: Bug
  Components: persistence
Affects Versions: 2.4
Reporter: Andrey Aleksandrov
Assignee: Alexey Stelmak
 Fix For: 2.7
 Attachments: reproducer.java

Case: 

1)Start 3 data nodes and activate the cluster with cache with 1 backup and 
PartitionLossPolicy.READ_ONLY_SAFE.
2)Start client and add the data to your cache. Stop the client
3)Stop DN2 and clear it pds and val
4)Start DN2. Rebalance will start.
5)During rebalance stop DN3.
6)Start DN3.

At this moment some partitions from DN2 marked as LOST and cache size will be 
less than expected.

7) Run resetLostPartitions(caches).

Now all partitions on DN2 marked as OWNING but cache size is still less than 
expected.

Workaround:

after step 6 do:

7)force rebalance using deactivate/activate methods.
8)wait for completion of rebalance

Now cache size is expected but some partitions from DN2 marked as LOST

9)Run resetLostPartitions(caches).

Now cache size is OK and all partitions from DN2 marked as OWNING.

However, looks like without force rebalance we have data loss here.




 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9973) MVCC: Tx recovery with continuous query.

[Roman Kondakov (JIRA)]

Roman Kondakov created IGNITE-9973:
--

 Summary: MVCC: Tx recovery with continuous query.
 Key: IGNITE-9973
 URL: https://issues.apache.org/jira/browse/IGNITE-9973
 Project: Ignite
  Issue Type: Task
  Components: mvcc
Reporter: Roman Kondakov
 Fix For: 2.7


We need to implement continuous query flow in case of mvcc tx recovery 
procedure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Abbreviation code-style requirement.

[Dmitriy Pavlov]

Hi Ivan

if by conflict we mean arguing and fighting it is definitely should be
avoided, it never helps the community.

But if we mean different opinions on details (variable namings, method
structure, etc), such different views are unavoidable and I find it is
perfectly ok that people with different background have different views.
The paramount thing here if we can solve such conflicts with a positive
outcome for all community and for the codebase.

The good friend of mine reminded me some time ago that we all have a common
goal here: make the community bigger and this project better. If we always
remember that we are connected by a common interest but we admit each
contributor may have different preferences in coding and probably different
opinion. We may build up consensus sharing our arguments if it is really
needed, or these different opinions/priorities/preferences may co-exist.

In a particular case, if reviewer's concerns are not major, another
reviewer can agree with your proposal. So it should be always considered
case-by-case, there is no silver bullet here.

Sincerely,
Dmitriy Pavlov

вт, 23 окт. 2018 г., 11:32 Maxim Muzafarov :

> Igniters,
>
> I think it's easy to disable the code style abbreviation plugin option by
> switching off
> the checkbox on - File | Settings | Inspections | Apache Ignite | Incorrect
> Java abbreviation usage.
>
> +1 to make abbreviation not mandatory, but I'd like to keep it for common
> variable names like `context = ctx`.
>
> On Mon, 22 Oct 2018 at 14:05 Павлухин Иван  wrote:
>
> > Hi all,
> >
> > I also think that abbreviations should not be mandatory (point 3).
> > But what I am worrying about is a conflict resolution between a patch
> > submitter and a reviewer.
> > How to come to an agreement when one side is strictly for and another
> side
> > is strictly against
> > using abbreviations in some concrete case?
> >
> > вс, 21 окт. 2018 г. в 11:34, Dmitriy Pavlov :
> >
> > > +1 for proposal 3.
> > >
> > > 1. I'm not sure we need to revisit all abbreviations as a lot of people
> > get
> > > used to it.
> > > 2. I'm not sure multiword is always need to be fully named, sometimes
> it
> > > may be ok to abbreviate.
> > > 3. But I agree with abbreviations should not be mandatory.
> > >
> > > Abbreviated and short names like i,j,cp and etc. are good for simple
> > > methods and code blocks; for a fast demonstration of some idea, but for
> > > complex enterprise level software it can hide meaning instead of
> clearly
> > > showing it.
> > >
> > > As a next step, I would like to propose to contribute an option to
> > disable
> > > abbreviation requirements for some cases in ignite-abbrev-plugin.
> > >
> > > сб, 20 окт. 2018 г. в 10:47, Zhenya :
> > >
> > > > +1 for all proposals.
> > > >
> > >
> >
> >
> > --
> > Best regards,
> > Ivan Pavlukhin
> >
> --
> --
> Maxim Muzafarov
>

[GitHub] ignite pull request #5043: IGNITE-9951: thin php: Date data type cut nanos

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/5043


---

[jira] [Created] (IGNITE-9972) Deleted entries remain in local partition internal map

[Anton Kurbanov (JIRA)]

Anton Kurbanov created IGNITE-9972:
--

 Summary: Deleted entries remain in local partition internal map
 Key: IGNITE-9972
 URL: https://issues.apache.org/jira/browse/IGNITE-9972
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.6
Reporter: Anton Kurbanov






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227300712
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/ObserverTask.java
 ##
 @@ -75,18 +93,23 @@ protected String runObserverTask() {
 int notFinishedBuilds = 0;
 Set ticketsNotified = new HashSet<>();
 
+Queue builds = buildsQueue();
+
+if (!tcHelper.isServerAuthorized())
+return "Server authorization required.";
+
 for (BuildsInfo info : builds) {
 checkedBuilds += info.buildsCount();
 
-IAnalyticsEnabledTeamcity teamcity = 
srvProvider.server(info.srvId, info.prov);
+IAnalyticsEnabledTeamcity teamcity = tcHelper.server(info.srvId, 
tcHelper.getServerAuthorizerCreds());
 
 if (!info.isFinished(teamcity)) {
 notFinishedBuilds += info.buildsCount() - 
info.finishedBuildsCount();
 
 continue;
 }
 
-String jiraRes = jiraIntegration.notifyJira(info.srvId, info.prov, 
info.buildTypeId,
+String jiraRes = jiraIntegration.notifyJira(info.srvId, 
tcHelper.getServerAuthorizerCreds(), info.buildTypeId,
 
 Review comment:
   Extract `tcHelper.getServerAuthorizerCreds()` to variable `creds`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227304277
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
 ##
 @@ -154,7 +162,9 @@ private String observeJira(
 
 buildObserverProvider.get().observe(srvId, prov, ticketFullName, 
builds);
 
-return "JIRA ticket IGNITE-" + ticketFullName + " will be notified 
after the tests are completed.";
+return tcHelper.isServerAuthorized() ? "JIRA ticket IGNITE-" + 
ticketFullName +
 
 Review comment:
   Use `if` statement instead of long ternary operator. It is more readable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227305508
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
 ##
 @@ -154,7 +162,9 @@ private String observeJira(
 
 buildObserverProvider.get().observe(srvId, prov, ticketFullName, 
builds);
 
-return "JIRA ticket IGNITE-" + ticketFullName + " will be notified 
after the tests are completed.";
+return tcHelper.isServerAuthorized() ? "JIRA ticket IGNITE-" + 
ticketFullName +
+" will be notified after the tests are completed." :
+"Perform server authentication to allow JIRA ticket be notified.";
 
 Review comment:
   May be something like "Ask server administrator to authorize the Bot to 
enable JIRA notifications."?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227298976
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/ObserverTask.java
 ##
 @@ -75,18 +93,23 @@ protected String runObserverTask() {
 int notFinishedBuilds = 0;
 Set ticketsNotified = new HashSet<>();
 
+Queue builds = buildsQueue();
+
+if (!tcHelper.isServerAuthorized())
 
 Review comment:
   Move authorization check prior variable declarations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227305678
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
 ##
 @@ -65,6 +66,13 @@
 
 @Inject Provider observer;
 
+@Inject ITcHelper tcHelper;
 
 Review comment:
   Missed javadoc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent queue for visas added

[GitBox]

SomeFire commented on a change in pull request #39: IGNITE-9901 Persistent 
queue for visas added
URL: https://github.com/apache/ignite-teamcity-bot/pull/39#discussion_r227302027
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/ObserverTask.java
 ##
 @@ -17,17 +17,21 @@
 
 package org.apache.ignite.ci.observer;
 
+import java.util.Collection;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.Queue;
 import java.util.Set;
 import java.util.TimerTask;
-import java.util.concurrent.ConcurrentLinkedQueue;
 import javax.inject.Inject;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteQueue;
 
 Review comment:
   Unused import.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Apache Ignite 2.7. Last Mile

[Dmitriy Govorukhin]

Nikolay,

I have an issue which I want to include in 2.7 release,
https://issues.apache.org/jira/browse/IGNITE-9854
It is a very small fix but very important, it protects us from NPE in some
race scenario.
Changes already in master, but the issue still not resolve, need your
approval for cherry-picking changes to ignite-2.7.

On Tue, Oct 23, 2018 at 10:51 AM Vladimir Ozerov 
wrote:

> Igniters,
>
> There are still tickets in the scope as we continue finding new issues
> during QA. I propose the following plan: if there are still opened issues
> by Friday, then shift vote date for 1 week, to 2nd November. This is needed
> to ensure that product quality is sufficient. But if the backlog is empty
> by Friday, we can go ahead with vote.
>
> Thoughts?
>
> On Tue, Oct 23, 2018 at 10:41 AM Nikolay Izhikov 
> wrote:
>
> > Hello, Igniters.
> >
> > We have 7 tickets mapped to 2.7 today.
> >
> > Igov Seliverstov  - IGNITE-9892 - MVCC: Exchange hangs on mvcc
> coordinator
> > fail
> > Igor Seliverstov  - IGNITE-9911 -
> >
> CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx
> > periodically hangs
> > Roman Kondakov- IGNITE-9928 - MVCC TX: Bug in SQL query mapping.
> > Roman Kondakov- IGNITE-9663 - MVCC: Data node failure can cause TX
> > hanging.
> > Vladimir Ozerov   - IGNITE-9960 - SQL: Revert and reopen lazy flag
> > optimization (IGNITE-9171)
> > Pavel Petroshenko - IGNITE-9951 - thin php: Date data type cut nanos
> > Peter Ivanov  - IGNITE-9953 - Dropping hadoop accelerator downloads
> >
> >
> > В Вс, 21/10/2018 в 11:23 +0300, Nikolay Izhikov пишет:
> > > Hell, Denis.
> > >
> > > I just filter all 2.7 tickets without documentation.
> > >
> > >
> > >
> >
> https://issues.apache.org/jira/browse/IGNITE-9932?jql=(project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.7%27)%20AND%20status%20NOT%20IN%20(Resolved%2C%20Closed)%20and%20(component%20is%20null%20or%20component%20NOT%20IN%20(documentation)))%20ORDER%20BY%20%20priority%20%20%20%20%20%20%20%20%20%20%20%20%20%20
> > >
> > > I've added this view to the release page.
> > > See sesction "Unresolved tickets(without documentation)".
> > >
> > > В Сб, 20/10/2018 в 16:04 -0700, Denis Magda пишет:
> > > > Nikolay,
> > > >
> > > > Where do you track those 8 blockers? Can't find them on this wiki
> page:
> > > > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On Sat, Oct 20, 2018 at 11:31 AM Nikolay Izhikov <
> nizhi...@apache.org>
> > > > wrote:
> > > >
> > > > > Hello, Denis.
> > > > >
> > > > > As a first time release manager I'm trying to rely on Ignite
> veterans
> > > > > opinion.
> > > > > Guys told me that we must fix all blockers and only after it make
> the
> > > > > release.
> > > > >
> > > > > Let's fix them all.
> > > > > What do you think?
> > > > >
> > > > > > When are we sending a release candidate for vote?
> > > > >
> > > > > When all blocker bugs will be fixed.
> > > > > Currently, we have *8*.
> > > > >
> > > > > В Пт, 19/10/2018 в 13:50 -0700, Denis Magda пишет:
> > > > > > Guys, as a side observer of the current release, this all looks
> > like a
> > > > > > never ending story :)
> > > > > >
> > > > > > When are we sending a release candidate for vote?
> > > > > >
> > > > > > --
> > > > > > Denis
> > > > > >
> > > > > > On Fri, Oct 19, 2018 at 4:39 AM Nikolay Izhikov <
> > nizhi...@apache.org>
> > > > >
> > > > > wrote:
> > > > > >
> > > > > > > Hello, Igniters.
> > > > > > >
> > > > > > > We have 6 tickets for 2.7
> > > > > > >
> > > > > > > Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928
> > > > > > > Igor Seliverstov - IGNITE-9911
> > > > > > > Ivan Pavlukhin - IGNITE-5935, IGNITE-9944
> > > > > > >
> > > > > > > В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет:
> > > > > > > > I have got one more potential 2.7 blocker [1] with
> > straightforward
> > > > >
> > > > > fix. I
> > > > > > > > beleive it will not break any production use case, but it
> > leads to
> > > > >
> > > > > test
> > > > > > > > suite hang, thus affecting other urgent issues.
> > > > > > > >
> > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9932
> > > > > > > >
> > > > > > > > чт, 18 окт. 2018 г. в 14:59, Ivan Daschinsky <
> > ivanda...@gmail.com>:
> > > > > > > >
> > > > > > > > > Hi! Is it possible to merge IGNITE-9854? Fix is pretty
> > simple, but
> > > > > > >
> > > > > > > quite
> > > > > > > > > important.
> > > > > > > > >
> > > > > > > > > ср, 17 окт. 2018 г. в 17:49, Andrey Gura  >:
> > > > > > > > >
> > > > > > > > > > JFYI
> > > > > > > > > >
> > > > > > > > > > IGNITE-9737 and IGNITE-9710 are merged to release branch.
> > > > > > > > > > On Wed, Oct 17, 2018 at 5:41 PM Pavel Tupitsyn <
> > > > >
> > > > > ptupit...@apache.org
> > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > Thank you. Fix has been merged to master and
> > cherry-picked to
> > > > > > > > >
> > > > 

[GitHub] ignite pull request #5055: IGNITE-9884 Some tests are incorrectly muted

[oignatenko]

GitHub user oignatenko opened a pull request:

https://github.com/apache/ignite/pull/5055

IGNITE-9884 Some tests are incorrectly muted



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5055


commit 1eeca908a8076a8317947dac8a46845964d1d7ea
Author: Oleg Ignatenko 
Date:   2018-08-23T13:13:28Z

IGNITE-9348 ML examples improvements
- wip (logging improved)
-- verified with diffs overview, executing the examples and studying 
execution logs

commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f
Author: Oleg Ignatenko 
Date:   2018-08-23T14:45:57Z

Revert "IGNITE-9348 ML examples improvements"

This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea.

commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674
Author: Oleg Ignatenko 
Date:   2018-08-23T14:57:34Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9642b233b5701bdad47ebea163079160227c582a
Author: Oleg Ignatenko 
Date:   2018-08-28T14:01:11Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4
Author: Oleg Ignatenko 
Date:   2018-08-28T15:13:02Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit d2caba67b156674f051f50faebeafe0871bf0914
Author: Oleg Ignatenko 
Date:   2018-08-29T13:14:07Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 16775dff51d71ea68b4a3dea98be552130c493ed
Author: Oleg Ignatenko 
Date:   2018-08-30T09:00:56Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit aedb59929974fe205b949225c1a338c68c60cfc8
Author: Oleg Ignatenko 
Date:   2018-08-30T09:42:38Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 39c6482fcdca506aa33011ed21c98060b4a8c68b
Author: Oleg Ignatenko 
Date:   2018-08-30T11:28:05Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 33b32a2760a6559c78283b927e3191180d8ed9e1
Author: Oleg Ignatenko 
Date:   2018-08-30T12:31:16Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0
Author: Oleg Ignatenko 
Date:   2018-08-30T14:06:34Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3
Author: Oleg Ignatenko 
Date:   2018-08-30T16:41:51Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit aacac88db519187413b0fc5ff9d0e55b8f8cff22
Author: Oleg Ignatenko 
Date:   2018-08-31T10:12:32Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 897f920dde46022849b13f9fb86dba8e54119a56
Author: Oleg Ignatenko 
Date:   2018-08-31T13:57:14Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 114c79e54c1b316006ccc3ff22d20d902f9313df
Author: Oleg Ignatenko 
Date:   2018-08-31T17:39:16Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit fd6b659bb8be1992618ce4ce91f568a0988b3afa
Author: Oleg Ignatenko 
Date:   2018-09-02T06:11:42Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944
Author: Oleg Ignatenko 
Date:   2018-09-03T10:27:35Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf
Author: Oleg Ignatenko 
Date:   2018-09-04T09:49:44Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5
Author: Oleg Ignatenko 
Date:   2018-09-05T10:50:28Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2
Author: Oleg Ignatenko 
Date:   2018-09-05T11:45:58Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 480ed78869277d7e32f725ab71bec9621f1ac03a
Author: Oleg Ignatenko 
Date:   2018-09-06T07:52:55Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit c99762498f617c0e98ea3062a43c0b30092166ef
Author: Oleg Ignatenko 
Date:   2018-09-06T14:45:04Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 2e17175225c72f747d370b5fee96f8be69d6d2cb
Author: Oleg Ignatenko 
Date:   2018-09-06T17:33:54Z

Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f
Author: Oleg Ignatenko 
Date:   2018-09-07T13:38:51Z

Merge branch 'master' of https://github.com/apache/ignite 

[GitHub] ignite pull request #5036: IGNITE-9884 Some tests are incorrectly muted

[oignatenko]

Github user oignatenko closed the pull request at:

https://github.com/apache/ignite/pull/5036


---

[jira] [Created] (IGNITE-9971) MLPTrainer example failures

[Sergey Kozlov (JIRA)]

Sergey Kozlov created IGNITE-9971:
-

 Summary: MLPTrainer example failures
 Key: IGNITE-9971
 URL: https://issues.apache.org/jira/browse/IGNITE-9971
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.5
Reporter: Sergey Kozlov


The example run output looks like non-clear:
{noformat}
>>> Ignite grid started.
окт 23, 2018 12:42:51 PM com.github.fommil.netlib.BLAS 
WARNING: Failed to load implementation from: 
com.github.fommil.netlib.NativeSystemBLAS
окт 23, 2018 12:42:51 PM com.github.fommil.netlib.BLAS 
WARNING: Failed to load implementation from: 
com.github.fommil.netlib.NativeRefBLAS

>>> Fail percentage: 0.0%.

>>> Distributed multilayer perceptron example completed.
{noformat}

Also second run of the example with running server node {{ExampleNodeStartup}} 
fails:

{noformat}
>>> Ignite grid started.
Exception in thread "MLPTrainerExample-#51" 
org.apache.ignite.cache.CacheExistsException: Failed to start cache (a cache 
with the same name is already started): TRAINING_SET
at 
org.apache.ignite.internal.processors.cache.GridCacheProcessor.prepareCacheChangeRequest(GridCacheProcessor.java:4431)
at 
org.apache.ignite.internal.processors.cache.GridCacheProcessor.dynamicStartCache(GridCacheProcessor.java:2973)
at 
org.apache.ignite.internal.processors.cache.GridCacheProcessor.dynamicStartCache(GridCacheProcessor.java:2912)
at 
org.apache.ignite.internal.IgniteKernal.createCache(IgniteKernal.java:2761)
at 
org.apache.ignite.examples.ml.nn.MLPTrainerExample.lambda$main$0(MLPTrainerExample.java:71)
at java.lang.Thread.run(Thread.java:745)
[12:46:14] Ignite node stopped OK [uptime=00:00:00.033]

{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #4893: IGNITE-8879 Correct restoring of metastorage and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4893


---

[GitHub] ignite pull request #5035: IGNITE-9911

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/5035


---

[jira] [Created] (IGNITE-9970) Add ability to set nodeId for VisorIdleVerifyDumpTask executed from ./control.sh --host HOST --cache idle_verify

[Pavel Voronkin (JIRA)]

Pavel Voronkin created IGNITE-9970:
--

 Summary: Add ability to set nodeId for VisorIdleVerifyDumpTask 
executed from ./control.sh --host HOST --cache idle_verify
 Key: IGNITE-9970
 URL: https://issues.apache.org/jira/browse/IGNITE-9970
 Project: Ignite
  Issue Type: Improvement
Reporter: Pavel Voronkin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added

[GitBox]

SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver 
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r227284241
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/hist/BuildRef.java
 ##
 @@ -181,4 +181,8 @@ public boolean isQueued() {
 public boolean isRunning() {
 return STATE_RUNNING.equals(state());
 }
+
+public boolean isUnknown() {
+return STATUS_UNKNOWN.equals(state());
 
 Review comment:
   State can't be unknown, it can be queued, running or finished. But status 
can be unknown when build is cancelled.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Abbreviation code-style requirement.

[Maxim Muzafarov]

Igniters,

I think it's easy to disable the code style abbreviation plugin option by
switching off
the checkbox on - File | Settings | Inspections | Apache Ignite | Incorrect
Java abbreviation usage.

+1 to make abbreviation not mandatory, but I'd like to keep it for common
variable names like `context = ctx`.

On Mon, 22 Oct 2018 at 14:05 Павлухин Иван  wrote:

> Hi all,
>
> I also think that abbreviations should not be mandatory (point 3).
> But what I am worrying about is a conflict resolution between a patch
> submitter and a reviewer.
> How to come to an agreement when one side is strictly for and another side
> is strictly against
> using abbreviations in some concrete case?
>
> вс, 21 окт. 2018 г. в 11:34, Dmitriy Pavlov :
>
> > +1 for proposal 3.
> >
> > 1. I'm not sure we need to revisit all abbreviations as a lot of people
> get
> > used to it.
> > 2. I'm not sure multiword is always need to be fully named, sometimes it
> > may be ok to abbreviate.
> > 3. But I agree with abbreviations should not be mandatory.
> >
> > Abbreviated and short names like i,j,cp and etc. are good for simple
> > methods and code blocks; for a fast demonstration of some idea, but for
> > complex enterprise level software it can hide meaning instead of clearly
> > showing it.
> >
> > As a next step, I would like to propose to contribute an option to
> disable
> > abbreviation requirements for some cases in ignite-abbrev-plugin.
> >
> > сб, 20 окт. 2018 г. в 10:47, Zhenya :
> >
> > > +1 for all proposals.
> > >
> >
>
>
> --
> Best regards,
> Ivan Pavlukhin
>
-- 
--
Maxim Muzafarov

Re: [MTCGA]: new failures in builds [2142325] needs to be handled

[Alexey Goncharuk]

This can be ignored. I removed the test because it measured performance and
we should run performance tests in a verified environment.

вт, 23 окт. 2018 г. в 5:16, :

> Hi Igniters,
>
>  I've detected some new issue on TeamCity to be handled. You are more than
> welcomed to help.
>
>  If your changes can lead to this failure(s): We're grateful that you were
> a volunteer to make the contribution to this project, but things change and
> you may no longer be able to finalize your contribution.
>  Could you respond to this email and indicate if you wish to continue and
> fix test failures or step down and some committer may revert you commit.
>
>  *Recently contributed test failed in master
> CacheStartInParallelTest.testParallelizationAcceleratesStartOfCaches2
> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-7547494506920381112=%3Cdefault%3E=testDetails
>  Changes may lead to failure were done by
>  - vololo100
> http://ci.ignite.apache.org/viewModification.html?modId=835983=false
>  - dmitry.melnichuk
> http://ci.ignite.apache.org/viewModification.html?modId=835941=false
>  - vpyatkov
> http://ci.ignite.apache.org/viewModification.html?modId=835937=false
>  - kaa.dev
> http://ci.ignite.apache.org/viewModification.html?modId=835901=false
>  - alexey.goncharuk
> http://ci.ignite.apache.org/viewModification.html?modId=835898=false
>  - andrey.mashenkov
> http://ci.ignite.apache.org/viewModification.html?modId=835896=false
>  - stanlukyanov
> http://ci.ignite.apache.org/viewModification.html?modId=835887=false
>  - bessonov.ip
> http://ci.ignite.apache.org/viewModification.html?modId=835884=false
>  - nsamelchev
> http://ci.ignite.apache.org/viewModification.html?modId=835881=false
>  - nsamelchev
> http://ci.ignite.apache.org/viewModification.html?modId=835875=false
>  - nsamelchev
> http://ci.ignite.apache.org/viewModification.html?modId=835873=false
>
>  - Here's a reminder of what contributors were agreed to do
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>  - Should you have any questions please contact
> dev@ignite.apache.org
>
> Best Regards,
> Apache Ignite TeamCity Bot
> https://github.com/apache/ignite-teamcity-bot
> Notification generated at 05:15:59 23-10-2018
>

Re: [MTCGA]: new failures in builds [2123440] needs to be handled

[Alexey Goncharuk]

Hi all,

We are working on the fix, it should be merged to master asap.

вт, 23 окт. 2018 г. в 11:18, Maxim Muzafarov :

> Hello,
>
> Are there any updates?
> The build constantly fails with `Execution timeout` in the master branch
> since October 20.
>
> The problem commit supposed to be related to the [2] issue and I think the
> probable `IgniteSqlSplitterSelfTest#testPushDown` test fails with
> excpetion:
>
> class org.apache.ignite.binary.BinaryObjectException: Failed to register
> class.
> at
>
> org.apache.ignite.internal.binary.BinaryContext.registerUserClassName(BinaryContext.java:1249)
> at
>
> org.apache.ignite.internal.binary.BinaryContext.registerUserClassDescriptor(BinaryContext.java:798)
> at
>
> org.apache.ignite.internal.binary.BinaryContext.registerClassDescriptor(BinaryContext.java:775)
>
> and the whole suite hungs.
>
> [1]
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=buildTypeStatusDiv_IgniteTests24Java8=%3Cdefault%3E
> [2] https://issues.apache.org/jira/browse/IGNITE-5795
>
> On Sun, 21 Oct 2018 at 08:30 Павлухин Иван  wrote:
>
> > Hi Anton,
> >
> > I ran a problematic build against my contribution [1] and it seems to
> pass
> > fine. Then I ran the build against your PR branch and it hanged [2].
> > There is nothing surprising that it fired only in master because the
> build
> > was added to RunAll after your PR runs.
> > Could you please take a look?
> >
> > [1] https://ci.ignite.apache.org/viewLog.html?buildId=2127238;
> > [2]
> >
> >
> https://ci.ignite.apache.org/viewLog.html?buildId=2127232=buildResultsDiv=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries
> >
> > сб, 20 окт. 2018 г. в 10:30, :
> >
> > > Hi Igniters,
> > >
> > >  I've detected some new issue on TeamCity to be handled. You are more
> > than
> > > welcomed to help.
> > >
> > >  If your changes can lead to this failure(s): We're grateful that you
> > were
> > > a volunteer to make the contribution to this project, but things change
> > and
> > > you may no longer be able to finalize your contribution.
> > >  Could you respond to this email and indicate if you wish to continue
> and
> > > fix test failures or step down and some committer may revert you
> commit.
> > >
> > >  *New Critical Failure in master Queries (Binary Objects Simple
> > > Mapper)
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=%3Cdefault%3E=buildTypeStatusDiv
> > >  Changes may lead to failure were done by
> > >  - kaa.dev
> > >
> >
> http://ci.ignite.apache.org/viewModification.html?modId=835798=false
> > >  - vololo100
> > >
> >
> http://ci.ignite.apache.org/viewModification.html?modId=835794=false
> > >
> > >  - Here's a reminder of what contributors were agreed to do
> > > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> > >  - Should you have any questions please contact
> > > dev@ignite.apache.org
> > >
> > > Best Regards,
> > > Apache Ignite TeamCity Bot
> > > https://github.com/apache/ignite-teamcity-bot
> > > Notification generated at 10:30:43 20-10-2018
> > >
> >
> >
> > --
> > Best regards,
> > Ivan Pavlukhin
> >
> --
> --
> Maxim Muzafarov
>

[GitHub] ignite pull request #4911: IGNITE-9719 Extra rebalanceThreadPoolSize check o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4911


---

Re: [MTCGA]: new failures in builds [2123440] needs to be handled

[Maxim Muzafarov]

Hello,

Are there any updates?
The build constantly fails with `Execution timeout` in the master branch
since October 20.

The problem commit supposed to be related to the [2] issue and I think the
probable `IgniteSqlSplitterSelfTest#testPushDown` test fails with excpetion:

class org.apache.ignite.binary.BinaryObjectException: Failed to register
class.
at
org.apache.ignite.internal.binary.BinaryContext.registerUserClassName(BinaryContext.java:1249)
at
org.apache.ignite.internal.binary.BinaryContext.registerUserClassDescriptor(BinaryContext.java:798)
at
org.apache.ignite.internal.binary.BinaryContext.registerClassDescriptor(BinaryContext.java:775)

and the whole suite hungs.

[1]
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=buildTypeStatusDiv_IgniteTests24Java8=%3Cdefault%3E
[2] https://issues.apache.org/jira/browse/IGNITE-5795

On Sun, 21 Oct 2018 at 08:30 Павлухин Иван  wrote:

> Hi Anton,
>
> I ran a problematic build against my contribution [1] and it seems to pass
> fine. Then I ran the build against your PR branch and it hanged [2].
> There is nothing surprising that it fired only in master because the build
> was added to RunAll after your PR runs.
> Could you please take a look?
>
> [1] https://ci.ignite.apache.org/viewLog.html?buildId=2127238;
> [2]
>
> https://ci.ignite.apache.org/viewLog.html?buildId=2127232=buildResultsDiv=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries
>
> сб, 20 окт. 2018 г. в 10:30, :
>
> > Hi Igniters,
> >
> >  I've detected some new issue on TeamCity to be handled. You are more
> than
> > welcomed to help.
> >
> >  If your changes can lead to this failure(s): We're grateful that you
> were
> > a volunteer to make the contribution to this project, but things change
> and
> > you may no longer be able to finalize your contribution.
> >  Could you respond to this email and indicate if you wish to continue and
> > fix test failures or step down and some committer may revert you commit.
> >
> >  *New Critical Failure in master Queries (Binary Objects Simple
> > Mapper)
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BinaryObjectsSimpleMapperQueries=%3Cdefault%3E=buildTypeStatusDiv
> >  Changes may lead to failure were done by
> >  - kaa.dev
> >
> http://ci.ignite.apache.org/viewModification.html?modId=835798=false
> >  - vololo100
> >
> http://ci.ignite.apache.org/viewModification.html?modId=835794=false
> >
> >  - Here's a reminder of what contributors were agreed to do
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >  - Should you have any questions please contact
> > dev@ignite.apache.org
> >
> > Best Regards,
> > Apache Ignite TeamCity Bot
> > https://github.com/apache/ignite-teamcity-bot
> > Notification generated at 10:30:43 20-10-2018
> >
>
>
> --
> Best regards,
> Ivan Pavlukhin
>
-- 
--
Maxim Muzafarov

Re: Apache Ignite 2.7. Last Mile

[Vladimir Ozerov]

Igniters,

There are still tickets in the scope as we continue finding new issues
during QA. I propose the following plan: if there are still opened issues
by Friday, then shift vote date for 1 week, to 2nd November. This is needed
to ensure that product quality is sufficient. But if the backlog is empty
by Friday, we can go ahead with vote.

Thoughts?

On Tue, Oct 23, 2018 at 10:41 AM Nikolay Izhikov 
wrote:

> Hello, Igniters.
>
> We have 7 tickets mapped to 2.7 today.
>
> Igov Seliverstov  - IGNITE-9892 - MVCC: Exchange hangs on mvcc coordinator
> fail
> Igor Seliverstov  - IGNITE-9911 -
> CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx
> periodically hangs
> Roman Kondakov- IGNITE-9928 - MVCC TX: Bug in SQL query mapping.
> Roman Kondakov- IGNITE-9663 - MVCC: Data node failure can cause TX
> hanging.
> Vladimir Ozerov   - IGNITE-9960 - SQL: Revert and reopen lazy flag
> optimization (IGNITE-9171)
> Pavel Petroshenko - IGNITE-9951 - thin php: Date data type cut nanos
> Peter Ivanov  - IGNITE-9953 - Dropping hadoop accelerator downloads
>
>
> В Вс, 21/10/2018 в 11:23 +0300, Nikolay Izhikov пишет:
> > Hell, Denis.
> >
> > I just filter all 2.7 tickets without documentation.
> >
> >
> >
> https://issues.apache.org/jira/browse/IGNITE-9932?jql=(project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.7%27)%20AND%20status%20NOT%20IN%20(Resolved%2C%20Closed)%20and%20(component%20is%20null%20or%20component%20NOT%20IN%20(documentation)))%20ORDER%20BY%20%20priority%20%20%20%20%20%20%20%20%20%20%20%20%20%20
> >
> > I've added this view to the release page.
> > See sesction "Unresolved tickets(without documentation)".
> >
> > В Сб, 20/10/2018 в 16:04 -0700, Denis Magda пишет:
> > > Nikolay,
> > >
> > > Where do you track those 8 blockers? Can't find them on this wiki page:
> > > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7
> > >
> > > --
> > > Denis
> > >
> > > On Sat, Oct 20, 2018 at 11:31 AM Nikolay Izhikov 
> > > wrote:
> > >
> > > > Hello, Denis.
> > > >
> > > > As a first time release manager I'm trying to rely on Ignite veterans
> > > > opinion.
> > > > Guys told me that we must fix all blockers and only after it make the
> > > > release.
> > > >
> > > > Let's fix them all.
> > > > What do you think?
> > > >
> > > > > When are we sending a release candidate for vote?
> > > >
> > > > When all blocker bugs will be fixed.
> > > > Currently, we have *8*.
> > > >
> > > > В Пт, 19/10/2018 в 13:50 -0700, Denis Magda пишет:
> > > > > Guys, as a side observer of the current release, this all looks
> like a
> > > > > never ending story :)
> > > > >
> > > > > When are we sending a release candidate for vote?
> > > > >
> > > > > --
> > > > > Denis
> > > > >
> > > > > On Fri, Oct 19, 2018 at 4:39 AM Nikolay Izhikov <
> nizhi...@apache.org>
> > > >
> > > > wrote:
> > > > >
> > > > > > Hello, Igniters.
> > > > > >
> > > > > > We have 6 tickets for 2.7
> > > > > >
> > > > > > Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928
> > > > > > Igor Seliverstov - IGNITE-9911
> > > > > > Ivan Pavlukhin - IGNITE-5935, IGNITE-9944
> > > > > >
> > > > > > В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет:
> > > > > > > I have got one more potential 2.7 blocker [1] with
> straightforward
> > > >
> > > > fix. I
> > > > > > > beleive it will not break any production use case, but it
> leads to
> > > >
> > > > test
> > > > > > > suite hang, thus affecting other urgent issues.
> > > > > > >
> > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9932
> > > > > > >
> > > > > > > чт, 18 окт. 2018 г. в 14:59, Ivan Daschinsky <
> ivanda...@gmail.com>:
> > > > > > >
> > > > > > > > Hi! Is it possible to merge IGNITE-9854? Fix is pretty
> simple, but
> > > > > >
> > > > > > quite
> > > > > > > > important.
> > > > > > > >
> > > > > > > > ср, 17 окт. 2018 г. в 17:49, Andrey Gura :
> > > > > > > >
> > > > > > > > > JFYI
> > > > > > > > >
> > > > > > > > > IGNITE-9737 and IGNITE-9710 are merged to release branch.
> > > > > > > > > On Wed, Oct 17, 2018 at 5:41 PM Pavel Tupitsyn <
> > > >
> > > > ptupit...@apache.org
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > Thank you. Fix has been merged to master and
> cherry-picked to
> > > > > > > >
> > > > > > > > ignite-2.7.
> > > > > > > > > >
> > > > > > > > > > On Wed, Oct 17, 2018 at 1:26 PM Nikolay Izhikov <
> > > > > >
> > > > > > nizhi...@apache.org>
> > > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Pavel.
> > > > > > > > > > >
> > > > > > > > > > > Ok, I agree to include this ticket into 2.7
> > > > > > > > > > > Let's do it.
> > > > > > > > > > >
> > > > > > > > > > > В Ср, 17/10/2018 в 13:20 +0300, Pavel Tupitsyn пишет:
> > > > > > > > > > > > Nikolay,
> > > > > > > > > > > >
> > > > > > > > > > > > It completely breaks a major feature under certain
> > > >
> > > > conditions.
> > > > > >
> > > > > > I
> > > > > > > > >
> > 

Re: Apache Ignite 2.7. Last Mile

[Nikolay Izhikov]

Hello, Igniters.

We have 7 tickets mapped to 2.7 today.

Igov Seliverstov  - IGNITE-9892 - MVCC: Exchange hangs on mvcc coordinator fail
Igor Seliverstov  - IGNITE-9911 - 
CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx 
periodically hangs
Roman Kondakov- IGNITE-9928 - MVCC TX: Bug in SQL query mapping.
Roman Kondakov- IGNITE-9663 - MVCC: Data node failure can cause TX hanging.
Vladimir Ozerov   - IGNITE-9960 - SQL: Revert and reopen lazy flag optimization 
(IGNITE-9171)
Pavel Petroshenko - IGNITE-9951 - thin php: Date data type cut nanos
Peter Ivanov  - IGNITE-9953 - Dropping hadoop accelerator downloads


В Вс, 21/10/2018 в 11:23 +0300, Nikolay Izhikov пишет:
> Hell, Denis.
> 
> I just filter all 2.7 tickets without documentation.
> 
> 
> https://issues.apache.org/jira/browse/IGNITE-9932?jql=(project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.7%27)%20AND%20status%20NOT%20IN%20(Resolved%2C%20Closed)%20and%20(component%20is%20null%20or%20component%20NOT%20IN%20(documentation)))%20ORDER%20BY%20%20priority%20%20%20%20%20%20%20%20%20%20%20%20%20%20
> 
> I've added this view to the release page.
> See sesction "Unresolved tickets(without documentation)".
> 
> В Сб, 20/10/2018 в 16:04 -0700, Denis Magda пишет:
> > Nikolay,
> > 
> > Where do you track those 8 blockers? Can't find them on this wiki page:
> > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7
> > 
> > --
> > Denis
> > 
> > On Sat, Oct 20, 2018 at 11:31 AM Nikolay Izhikov 
> > wrote:
> > 
> > > Hello, Denis.
> > > 
> > > As a first time release manager I'm trying to rely on Ignite veterans
> > > opinion.
> > > Guys told me that we must fix all blockers and only after it make the
> > > release.
> > > 
> > > Let's fix them all.
> > > What do you think?
> > > 
> > > > When are we sending a release candidate for vote?
> > > 
> > > When all blocker bugs will be fixed.
> > > Currently, we have *8*.
> > > 
> > > В Пт, 19/10/2018 в 13:50 -0700, Denis Magda пишет:
> > > > Guys, as a side observer of the current release, this all looks like a
> > > > never ending story :)
> > > > 
> > > > When are we sending a release candidate for vote?
> > > > 
> > > > --
> > > > Denis
> > > > 
> > > > On Fri, Oct 19, 2018 at 4:39 AM Nikolay Izhikov 
> > > 
> > > wrote:
> > > > 
> > > > > Hello, Igniters.
> > > > > 
> > > > > We have 6 tickets for 2.7
> > > > > 
> > > > > Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928
> > > > > Igor Seliverstov - IGNITE-9911
> > > > > Ivan Pavlukhin - IGNITE-5935, IGNITE-9944
> > > > > 
> > > > > В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет:
> > > > > > I have got one more potential 2.7 blocker [1] with straightforward
> > > 
> > > fix. I
> > > > > > beleive it will not break any production use case, but it leads to
> > > 
> > > test
> > > > > > suite hang, thus affecting other urgent issues.
> > > > > > 
> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9932
> > > > > > 
> > > > > > чт, 18 окт. 2018 г. в 14:59, Ivan Daschinsky :
> > > > > > 
> > > > > > > Hi! Is it possible to merge IGNITE-9854? Fix is pretty simple, but
> > > > > 
> > > > > quite
> > > > > > > important.
> > > > > > > 
> > > > > > > ср, 17 окт. 2018 г. в 17:49, Andrey Gura :
> > > > > > > 
> > > > > > > > JFYI
> > > > > > > > 
> > > > > > > > IGNITE-9737 and IGNITE-9710 are merged to release branch.
> > > > > > > > On Wed, Oct 17, 2018 at 5:41 PM Pavel Tupitsyn <
> > > 
> > > ptupit...@apache.org
> > > > > > > > wrote:
> > > > > > > > > 
> > > > > > > > > Thank you. Fix has been merged to master and cherry-picked to
> > > > > > > 
> > > > > > > ignite-2.7.
> > > > > > > > > 
> > > > > > > > > On Wed, Oct 17, 2018 at 1:26 PM Nikolay Izhikov <
> > > > > 
> > > > > nizhi...@apache.org>
> > > > > > > > 
> > > > > > > > wrote:
> > > > > > > > > 
> > > > > > > > > > Pavel.
> > > > > > > > > > 
> > > > > > > > > > Ok, I agree to include this ticket into 2.7
> > > > > > > > > > Let's do it.
> > > > > > > > > > 
> > > > > > > > > > В Ср, 17/10/2018 в 13:20 +0300, Pavel Tupitsyn пишет:
> > > > > > > > > > > Nikolay,
> > > > > > > > > > > 
> > > > > > > > > > > It completely breaks a major feature under certain
> > > 
> > > conditions.
> > > > > 
> > > > > I
> > > > > > > > 
> > > > > > > > would
> > > > > > > > > > > consider it a blocker.
> > > > > > > > > > > 
> > > > > > > > > > > On Wed, Oct 17, 2018 at 1:00 PM Nikolay Izhikov <
> > > > > > > 
> > > > > > > nizhi...@apache.org
> > > > > > > > > 
> > > > > > > > > > wrote:
> > > > > > > > > > > 
> > > > > > > > > > > > Hello, Pavel.
> > > > > > > > > > > > 
> > > > > > > > > > > > Is it a blocker?
> > > > > > > > > > > > 
> > > > > > > > > > > > В Ср, 17/10/2018 в 12:58 +0300, Pavel Tupitsyn пишет:
> > > > > > > > > > > > > Hi Igniters,
> > > > > > > > > > > > > 
> > > > > > > > > > > > > I'd like to include IGNITE-9877 in 2.7, can we do 
> > > > > > > > > > > > > that?
> > > > > > > > > > > > 

[GitHub] ignite pull request #5045: IGNITE-9960

[devozerov]

Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/5045


---

[jira] [Created] (IGNITE-9968) Able to filter backup cache events

[Roman Bastanov (JIRA)]

Roman Bastanov created IGNITE-9968:
--

 Summary: Able to filter backup cache events
 Key: IGNITE-9968
 URL: https://issues.apache.org/jira/browse/IGNITE-9968
 Project: Ignite
  Issue Type: Improvement
  Components: cache
Reporter: Roman Bastanov






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)