Re: IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Hi Anton,

I checked your last comments in the ticket and left some responses. Please
check them and let me know

Thanks,
Amir

P.S. do you mind to have a chat/call through gitter/Skype to discuss the
details? Sometimes 5 minutes of chat can be more productive than long
running email chains. Please, do not hesitate to directly email me if you
mind to have a chat/call.

On Wed, Jun 27, 2018 at 11:26 AM Anton Vinogradov  wrote:

> Sure,
> Hope it will be tomorrow
>
> ср, 27 июн. 2018 г. в 18:11, Amir Akhmedov :
>
> > Anton V,
> > I put some comments into jira ticket. Can you please take a look once you
> > have a chance?
> >
> > Thanks,
> > Amir
> >
> > On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov  wrote:
> >
> > > Amir,
> > >
> > > Everything is fine, I'll check changes this week.
> > >
> > > вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov :
> > >
> > > > Anton,
> > > > I created a news PR [1]. Since it includes the same changes I did not
> > run
> > > > TC tests on it. Please let me know if you think otherwise.
> > > >
> > > > [1]  https://github.com/apache/ignite/pull/4207
> > > >
> > > > Thanks,
> > > > Amir
> > > >
> > > >
> > > > On Wed, Jun 13, 2018 at 8:38 AM Anton Vinogradov 
> > wrote:
> > > >
> > > > > Amir,
> > > > >
> > > > > Thanks for attempt.
> > > > > As far as I can see you have all changes at this commit:
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a
> > > > >
> > > > > You can simply apply it to local branch based on master by patch
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/ignite/commit/cd0e50e05d3860788378ebf1a29dc0525460872a.patch
> > > > >
> > > > > In case you use IDEA, just apply patch from clipboard, and that's
> > will
> > > be
> > > > > you PR.
> > > > >
> > > > > BTW, next time you can use easiest way to squash your changes -
> just
> > to
> > > > > pull all changes from existing PR with squash
> > > > > > git pull https://github.com/apache/ignite.git pull/XXX/head
> > --squash
> > > > >
> > > > >
> > > > >
> > > > > вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov  >:
> > > > >
> > > > > > Dmitry P., Anton V.,
> > > > > > I made some changes and updated the ticket. Also as was asked I
> > tried
> > > > to
> > > > > > squash the commits into one but looks like I screwed up
> everything
> > > and
> > > > > the
> > > > > > PR now looks completely terrible. Since I'm not an advanced git
> > user,
> > > > > could
> > > > > > you please check the PR and let me know if anything could be done
> > > > there?
> > > > > If
> > > > > > not I will try to create a new PR.
> > > > > >
> > > > > > Thanks,
> > > > > > Amir
> > > > > >
> > > > > > On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov <
> > > dpavlov@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Amir,
> > > > > > >
> > > > > > > As far as I know, several Igniters provided some feedback in
> > > ticket.
> > > > > Are
> > > > > > > you agree?
> > > > > > >
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > >
> > > > > > > чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > > > > > >
> > > > > > > > Hi Amir,
> > > > > > > >
> > > > > > > > This is a very necessary contribution, the patch defenetely
> > will
> > > > not
> > > > > be
> > > > > > > > ignored.
> > > > > > > >
> > > > > > > > Igniters,
> > > > > > > >
> > > > > > > > Who can make a review from the commi

Relevance of IGNITE-6409

[Amir Akhmedov]

Hi Igniters,

I want to work on IGNITE-6409 (SQL: bypass H2 during index update) and want
to ask about it's status. Is it still relevant ticket to work on?

Vladimir Ozerov, as a reporter, can you please give your feedback please?

Thanks,
Amir

Review for IGNITE-8880: Add setIgnite() in SpringCacheManager and SpringTransactionManager

[Amir Akhmedov]

Igniters,

Please review my changes. That's a simple change, a setter method was added.

Thanks,
Amir

Re: IgniteSet implementation: changes required

[Amir Akhmedov]

Yes, you are right.

Thanks,
Amir


On Wed, Jun 27, 2018 at 1:15 PM Denis Magda  wrote:

> Got you. If it's about redundant data duplication in onheap region then no
> any concerns from my side.
>
> Anyway, considering that the data structure will be interacting with the
> page memory directly then its entries can be stored in Ignite persistence
> automatically (if the latter is on). Does it mean that the data structure
> will be fully recovered after a restart and its entries can be pulled from
> disk on demand?
>
> --
> Denis
>
>
> On Tue, Jun 26, 2018 at 1:49 PM Amir Akhmedov 
> wrote:
>
> > I also think it will better to remove setDataMap support cause
> > 1. It's making extra pressure on GC by keeping entries on heap
> > 2. It has difficult logic to support with lots of nuances
> > 3. To maintain setDataMap today GridCacheMapEntry calls
> > cctx.dataStructures().onEntryUpdated() on each entry mutation. I think
> it's
> > unnecessary cohesion.
> > 4. For the case with single Ignite cache for all collocated
> datastructure,
> > an iterator creation will not be much slower than current implementation
> > since we can run affinity call on the node where all entries reside.
> Also,
> > we can create a better affinity mapper to fairly distribute
> datastructures
> > across a cluster rather than mapping by datastructure's name.
> >
> > Thanks,
> > Amir
> >
> >
> > On Tue, Jun 26, 2018 at 8:10 AM Anton Vinogradov  wrote:
> >
> > > Denis,
> > >
> > > I think that better case is to remove onheap optimisation/duplication.
> > > This brings no drop to frequently used operations (put/remove), but
> even
> > > will make it slightly faster.
> > >
> > > The only one question we have here is "is it possible to restore onheap
> > map
> > > in easy way?".
> > > Seems that answer is no, so, I vote for setDataMap removal.
> > >
> > > вт, 26 июн. 2018 г. в 15:00, Denis Magda :
> > >
> > > > Anton,
> > > >
> > > > Will it be possible to reuse such a functionality for the rest of
> data
> > > > structures? I would invest our time in this if all data structures
> > would
> > > be
> > > > able to work with Ignite persistence this way.
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On Tue, Jun 26, 2018 at 1:53 AM Anton Vinogradov 
> > wrote:
> > > >
> > > > > >> Why don't we read data straight from the persistence layer
> warming
> > > RAM
> > > > > up
> > > > > >> in the background?
> > > > > Because it's not a trivial task to finish such loading on unstable
> > > > > topology.
> > > > > That's possible, ofcourse, but solution and complexity will be
> almost
> > > > > equals to WAL enable/disable.
> > > > >
> > > > > пн, 25 июн. 2018 г. в 22:13, Denis Magda :
> > > > >
> > > > > > Folks,
> > > > > >
> > > > > > Why don't we read data straight from the persistence layer
> warming
> > > RAM
> > > > up
> > > > > > in the background? (like we do for SQL and other APIs). If it's a
> > > > > question
> > > > > > of time, then I would suggest us not to hurry up and do it in a
> > right
> > > > > way.
> > > > > >
> > > > > > --
> > > > > > Denis
> > > > > >
> > > > > > On Mon, Jun 25, 2018 at 6:20 AM Anton Vinogradov 
> > > > wrote:
> > > > > >
> > > > > > > +1 to removal in case there is no easy, fast and consistent way
> > to
> > > > > > restore
> > > > > > > setDataMap on node restart.
> > > > > > > I see that we'll gain some performance drop on size() or
> keys(),
> > > but
> > > > > > these
> > > > > > > methods are rarely used.
> > > > > > >
> > > > > > > пн, 25 июн. 2018 г. в 16:07, Pavel Pereslegin <
> xxt...@gmail.com
> > >:
> > > > > > >
> > > > > > > > Hello, Igniters.
> > > > > > > >
> > > > > > > > I tried to implement IgniteSet data recovery when persistence
> > > > enabled
> > > > > > > > [1] using

Re: IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Anton V,
I put some comments into jira ticket. Can you please take a look once you
have a chance?

Thanks,
Amir

On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov  wrote:

> Amir,
>
> Everything is fine, I'll check changes this week.
>
> вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov :
>
> > Anton,
> > I created a news PR [1]. Since it includes the same changes I did not run
> > TC tests on it. Please let me know if you think otherwise.
> >
> > [1]  https://github.com/apache/ignite/pull/4207
> >
> > Thanks,
> > Amir
> >
> >
> > On Wed, Jun 13, 2018 at 8:38 AM Anton Vinogradov  wrote:
> >
> > > Amir,
> > >
> > > Thanks for attempt.
> > > As far as I can see you have all changes at this commit:
> > >
> > >
> >
> https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a
> > >
> > > You can simply apply it to local branch based on master by patch
> > >
> > >
> >
> https://github.com/apache/ignite/commit/cd0e50e05d3860788378ebf1a29dc0525460872a.patch
> > >
> > > In case you use IDEA, just apply patch from clipboard, and that's will
> be
> > > you PR.
> > >
> > > BTW, next time you can use easiest way to squash your changes - just to
> > > pull all changes from existing PR with squash
> > > > git pull https://github.com/apache/ignite.git pull/XXX/head --squash
> > >
> > >
> > >
> > > вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov :
> > >
> > > > Dmitry P., Anton V.,
> > > > I made some changes and updated the ticket. Also as was asked I tried
> > to
> > > > squash the commits into one but looks like I screwed up everything
> and
> > > the
> > > > PR now looks completely terrible. Since I'm not an advanced git user,
> > > could
> > > > you please check the PR and let me know if anything could be done
> > there?
> > > If
> > > > not I will try to create a new PR.
> > > >
> > > > Thanks,
> > > > Amir
> > > >
> > > > On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov <
> dpavlov@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi Amir,
> > > > >
> > > > > As far as I know, several Igniters provided some feedback in
> ticket.
> > > Are
> > > > > you agree?
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov :
> > > > >
> > > > > > Hi Amir,
> > > > > >
> > > > > > This is a very necessary contribution, the patch defenetely will
> > not
> > > be
> > > > > > ignored.
> > > > > >
> > > > > > Igniters,
> > > > > >
> > > > > > Who can make a review from the committers?
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > вт, 8 мая 2018 г. в 5:52, Amir Akhmedov  >:
> > > > > >
> > > > > >> Hi Igniters,
> > > > > >>
> > > > > >> Can someone take a look at this PR please?
> > > > > >>
> > > > > >> Thanks,
> > > > > >> Amir
> > > > > >>
> > > > > >> On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn <
> > > ptupit...@apache.org
> > > > >
> > > > > >> wrote:
> > > > > >>
> > > > > >> > Hi Amir,
> > > > > >> >
> > > > > >> > I have filed [1] for multimap in .NET, it will be done later.
> > > > > >> > In order to fix IgniteParityTest failures, please add the
> > > following
> > > > to
> > > > > >> > MissingMembers array there:
> > > > > >> >
> > > > > >> > "multimap" // IGNITE-8425
> > > > > >> >
> > > > > >> > Thanks,
> > > > > >> > Pavel
> > > > > >> >
> > > > > >> >
> > > > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-8425
> > > > > >> >
> > > > > >> > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <
> > > > > >> amir.akhme...@gmail.com>
> > > > > >> > wrote:
> > > > > >> >
> > > > > >> > > Hi Igniters,
> > > > > >> > >
> > > > > >> > > I raised a pull request [1] for Ignite multimap [2]. TC run
> > [3]
> > > > > seems
> > > > > >> ok
> > > > > >> > to
> > > > > >> > > me, some tests are failed though. Can someone review it
> please
> > > and
> > > > > >> let me
> > > > > >> > > know?
> > > > > >> > >
> > > > > >> > > Thanks,
> > > > > >> > > Amir
> > > > > >> > >
> > > > > >> > > [1] https://github.com/apache/ignite/pull/3926
> > > > > >> > > [2] https://issues.apache.org/jira/browse/IGNITE-640
> > > > > >> > > [3]
> > > > > >> > >
> https://ci.ignite.apache.org/viewLog.html?buildId=1255210
> > > > > >> > > b=buildResultsDiv=IgniteTests24Java8_RunAll
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>

[jira] [Created] (IGNITE-8880) Add setIgnite() in SpringCacheManager and SpringTransactionManager

[Amir Akhmedov (JIRA)]

Amir Akhmedov created IGNITE-8880:
-

 Summary: Add setIgnite() in SpringCacheManager and 
SpringTransactionManager
 Key: IGNITE-8880
 URL: https://issues.apache.org/jira/browse/IGNITE-8880
 Project: Ignite
  Issue Type: Improvement
  Components: spring
Reporter: Amir Akhmedov
 Fix For: 2.7


Neet to add setIgnite() in SpringCacheManager and SpringTransactionManager to 
make explicit injection of Ignite instance.

For more details refer: 
https://issues.apache.org/jira/browse/IGNITE-8740?focusedCommentId=16520894=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16520894



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: IgniteSet implementation: changes required

[Amir Akhmedov]

I also think it will better to remove setDataMap support cause
1. It's making extra pressure on GC by keeping entries on heap
2. It has difficult logic to support with lots of nuances
3. To maintain setDataMap today GridCacheMapEntry calls
cctx.dataStructures().onEntryUpdated() on each entry mutation. I think it's
unnecessary cohesion.
4. For the case with single Ignite cache for all collocated datastructure,
an iterator creation will not be much slower than current implementation
since we can run affinity call on the node where all entries reside. Also,
we can create a better affinity mapper to fairly distribute datastructures
across a cluster rather than mapping by datastructure's name.

Thanks,
Amir


On Tue, Jun 26, 2018 at 8:10 AM Anton Vinogradov  wrote:

> Denis,
>
> I think that better case is to remove onheap optimisation/duplication.
> This brings no drop to frequently used operations (put/remove), but even
> will make it slightly faster.
>
> The only one question we have here is "is it possible to restore onheap map
> in easy way?".
> Seems that answer is no, so, I vote for setDataMap removal.
>
> вт, 26 июн. 2018 г. в 15:00, Denis Magda :
>
> > Anton,
> >
> > Will it be possible to reuse such a functionality for the rest of data
> > structures? I would invest our time in this if all data structures would
> be
> > able to work with Ignite persistence this way.
> >
> > --
> > Denis
> >
> > On Tue, Jun 26, 2018 at 1:53 AM Anton Vinogradov  wrote:
> >
> > > >> Why don't we read data straight from the persistence layer warming
> RAM
> > > up
> > > >> in the background?
> > > Because it's not a trivial task to finish such loading on unstable
> > > topology.
> > > That's possible, ofcourse, but solution and complexity will be almost
> > > equals to WAL enable/disable.
> > >
> > > пн, 25 июн. 2018 г. в 22:13, Denis Magda :
> > >
> > > > Folks,
> > > >
> > > > Why don't we read data straight from the persistence layer warming
> RAM
> > up
> > > > in the background? (like we do for SQL and other APIs). If it's a
> > > question
> > > > of time, then I would suggest us not to hurry up and do it in a right
> > > way.
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On Mon, Jun 25, 2018 at 6:20 AM Anton Vinogradov 
> > wrote:
> > > >
> > > > > +1 to removal in case there is no easy, fast and consistent way to
> > > > restore
> > > > > setDataMap on node restart.
> > > > > I see that we'll gain some performance drop on size() or keys(),
> but
> > > > these
> > > > > methods are rarely used.
> > > > >
> > > > > пн, 25 июн. 2018 г. в 16:07, Pavel Pereslegin :
> > > > >
> > > > > > Hello, Igniters.
> > > > > >
> > > > > > I tried to implement IgniteSet data recovery when persistence
> > enabled
> > > > > > [1] using trivial cache scanning, however I cannot find optimal
> way
> > > to
> > > > > > do that because of the following reasons:
> > > > > > - Performing operations on IgniteSet requires completion of data
> > > > > > loading (restoring of setDataMap) on all nodes. Do this during
> > > > > > partition map exchange is too long.
> > > > > > - The prohibition of operations on IgniteSet before the
> completion
> > of
> > > > > > asynchronous cache scanning on all nodes looks rather
> complicated,
> > > > > > because It is necessary to support all situations of unstable
> > > > > > topology.
> > > > > >
> > > > > > So I see one option to fix data loss on node restart - remove the
> > > > > > entire optimization (setDataMap) and rework the iterator
> > > > > > implementation to perform cache scanning.
> > > > > >
> > > > > > Thoughts?
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-5553
> > > > > >
> > > > > >
> > > > > > 2018-03-17 8:20 GMT+03:00 Andrey Kuznetsov :
> > > > > > > Thanks, Dmitry. I agree ultimately, DS API uniformity is a
> > weighty
> > > > > > reason.
> > > > > > >
> > > > > > > 2018-03-17 3:54 GMT+03:00 Dmitriy Setrakyan <
> > dsetrak...@apache.org
> > > >:
> > > > > > >
> > > > > > >> On Fri, Mar 16, 2018 at 7:39 AM, Andrey Kuznetsov <
> > > > stku...@gmail.com>
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >> > Dmitry, your way allows to reuse existing {{Ignite.set()}}
> API
> > > to
> > > > > > create
> > > > > > >> > both set flavors. We can adopt it unless somebody in the
> > > community
> > > > > > >> objects.
> > > > > > >> > Personally, I like {{IgniteCache.asSet()}} approach proposed
> > by
> > > > > > Vladimir
> > > > > > >> O.
> > > > > > >> > more, since it emphasizes the difference between sets being
> > > > created,
> > > > > > but
> > > > > > >> > this will require API extension.
> > > > > > >> >
> > > > > > >>
> > > > > > >> Andrey, I am suggesting that Ignite.set(...) in non-collocated
> > > mode
> > > > > > behaves
> > > > > > >> exactly the same as the proposed IgniteCache.asSet() method. I
> > do
> > > > not
> > > > > > like
> > > > > > >> the IgniteCache.asSet() API because it is inconsistent with
> > Ignite
> > > > > data
> > > > > > >> 

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

[Amir Akhmedov]

Great, thanks! As always, happy to contribute!

Thanks,
Amir


On Fri, Jun 22, 2018 at 7:32 PM Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Amir,
>
> I merged you change to master and 2.6. Thanks!
>
> -Val
>
> On Fri, Jun 22, 2018 at 4:21 PM Amir Akhmedov 
> wrote:
>
>> Val,
>> I replied to it already :)
>>
>> Thanks,
>> Amir
>>
>>
>> On Fri, Jun 22, 2018 at 7:20 PM Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>>> Amir,
>>>
>>> Thanks for quick reaction. I added a follow up question in the ticket.
>>>
>>> -Val
>>>
>>> On Fri, Jun 22, 2018 at 3:48 PM Amir Akhmedov 
>>> wrote:
>>>
>>>> Hi Val,
>>>> Thanks for your comments. I replied in the ticket with my vision of the
>>>> issue and how I tried to solve it. Please check it and let me know.
>>>>
>>>> Thanks,
>>>> Amir
>>>>
>>>>
>>>> On Fri, Jun 22, 2018 at 5:42 PM Valentin Kulichenko <
>>>> valentin.kuliche...@gmail.com> wrote:
>>>>
>>>>> Hi Amir,
>>>>>
>>>>> I reviewed the changes and I'm not sure I understood how they fix they
>>>>> issue. I left more detailed comment in the ticket, can you please clarify?
>>>>>
>>>>> -Val
>>>>>
>>>>> On Fri, Jun 22, 2018 at 9:53 AM Dmitry Pavlov 
>>>>> wrote:
>>>>>
>>>>>> Hi Amir,
>>>>>>
>>>>>> let me say sincere thank you for continuing to contribute.
>>>>>>
>>>>>> Bumping up this thread.
>>>>>>
>>>>>> Igniters, who has an expertise here?
>>>>>>
>>>>>>
>>>>>> вс, 17 июн. 2018 г. в 17:59, Amir Akhmedov :
>>>>>>
>>>>>> > Hi All,
>>>>>> > Can you please review my changes for IGNITE-8740.
>>>>>> >
>>>>>> > PR: https://github.com/apache/ignite/pull/4208
>>>>>> > TC:
>>>>>> >
>>>>>> >
>>>>>> https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll
>>>>>> >
>>>>>> > Thanks,
>>>>>> > Amir
>>>>>> >
>>>>>>
>>>>>

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

[Amir Akhmedov]

Val,
I replied to it already :)

Thanks,
Amir


On Fri, Jun 22, 2018 at 7:20 PM Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Amir,
>
> Thanks for quick reaction. I added a follow up question in the ticket.
>
> -Val
>
> On Fri, Jun 22, 2018 at 3:48 PM Amir Akhmedov 
> wrote:
>
>> Hi Val,
>> Thanks for your comments. I replied in the ticket with my vision of the
>> issue and how I tried to solve it. Please check it and let me know.
>>
>> Thanks,
>> Amir
>>
>>
>> On Fri, Jun 22, 2018 at 5:42 PM Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>>> Hi Amir,
>>>
>>> I reviewed the changes and I'm not sure I understood how they fix they
>>> issue. I left more detailed comment in the ticket, can you please clarify?
>>>
>>> -Val
>>>
>>> On Fri, Jun 22, 2018 at 9:53 AM Dmitry Pavlov 
>>> wrote:
>>>
>>>> Hi Amir,
>>>>
>>>> let me say sincere thank you for continuing to contribute.
>>>>
>>>> Bumping up this thread.
>>>>
>>>> Igniters, who has an expertise here?
>>>>
>>>>
>>>> вс, 17 июн. 2018 г. в 17:59, Amir Akhmedov :
>>>>
>>>> > Hi All,
>>>> > Can you please review my changes for IGNITE-8740.
>>>> >
>>>> > PR: https://github.com/apache/ignite/pull/4208
>>>> > TC:
>>>> >
>>>> >
>>>> https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll
>>>> >
>>>> > Thanks,
>>>> > Amir
>>>> >
>>>>
>>>

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

[Amir Akhmedov]

Hi Val,
Thanks for your comments. I replied in the ticket with my vision of the
issue and how I tried to solve it. Please check it and let me know.

Thanks,
Amir


On Fri, Jun 22, 2018 at 5:42 PM Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Hi Amir,
>
> I reviewed the changes and I'm not sure I understood how they fix they
> issue. I left more detailed comment in the ticket, can you please clarify?
>
> -Val
>
> On Fri, Jun 22, 2018 at 9:53 AM Dmitry Pavlov 
> wrote:
>
>> Hi Amir,
>>
>> let me say sincere thank you for continuing to contribute.
>>
>> Bumping up this thread.
>>
>> Igniters, who has an expertise here?
>>
>>
>> вс, 17 июн. 2018 г. в 17:59, Amir Akhmedov :
>>
>> > Hi All,
>> > Can you please review my changes for IGNITE-8740.
>> >
>> > PR: https://github.com/apache/ignite/pull/4208
>> > TC:
>> >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll
>> >
>> > Thanks,
>> > Amir
>> >
>>
>

Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

[Amir Akhmedov]

Hi All,
Can you please review my changes for IGNITE-8740.

PR: https://github.com/apache/ignite/pull/4208
TC:
https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll

Thanks,
Amir

Re: IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Anton,
I created a news PR [1]. Since it includes the same changes I did not run
TC tests on it. Please let me know if you think otherwise.

[1]  https://github.com/apache/ignite/pull/4207

Thanks,
Amir


On Wed, Jun 13, 2018 at 8:38 AM Anton Vinogradov  wrote:

> Amir,
>
> Thanks for attempt.
> As far as I can see you have all changes at this commit:
>
> https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a
>
> You can simply apply it to local branch based on master by patch
>
> https://github.com/apache/ignite/commit/cd0e50e05d3860788378ebf1a29dc0525460872a.patch
>
> In case you use IDEA, just apply patch from clipboard, and that's will be
> you PR.
>
> BTW, next time you can use easiest way to squash your changes - just to
> pull all changes from existing PR with squash
> > git pull https://github.com/apache/ignite.git pull/XXX/head --squash
>
>
>
> вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov :
>
> > Dmitry P., Anton V.,
> > I made some changes and updated the ticket. Also as was asked I tried to
> > squash the commits into one but looks like I screwed up everything and
> the
> > PR now looks completely terrible. Since I'm not an advanced git user,
> could
> > you please check the PR and let me know if anything could be done there?
> If
> > not I will try to create a new PR.
> >
> > Thanks,
> > Amir
> >
> > On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov 
> > wrote:
> >
> > > Hi Amir,
> > >
> > > As far as I know, several Igniters provided some feedback in ticket.
> Are
> > > you agree?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov :
> > >
> > > > Hi Amir,
> > > >
> > > > This is a very necessary contribution, the patch defenetely will not
> be
> > > > ignored.
> > > >
> > > > Igniters,
> > > >
> > > > Who can make a review from the committers?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > вт, 8 мая 2018 г. в 5:52, Amir Akhmedov :
> > > >
> > > >> Hi Igniters,
> > > >>
> > > >> Can someone take a look at this PR please?
> > > >>
> > > >> Thanks,
> > > >> Amir
> > > >>
> > > >> On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn <
> ptupit...@apache.org
> > >
> > > >> wrote:
> > > >>
> > > >> > Hi Amir,
> > > >> >
> > > >> > I have filed [1] for multimap in .NET, it will be done later.
> > > >> > In order to fix IgniteParityTest failures, please add the
> following
> > to
> > > >> > MissingMembers array there:
> > > >> >
> > > >> > "multimap" // IGNITE-8425
> > > >> >
> > > >> > Thanks,
> > > >> > Pavel
> > > >> >
> > > >> >
> > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-8425
> > > >> >
> > > >> > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <
> > > >> amir.akhme...@gmail.com>
> > > >> > wrote:
> > > >> >
> > > >> > > Hi Igniters,
> > > >> > >
> > > >> > > I raised a pull request [1] for Ignite multimap [2]. TC run [3]
> > > seems
> > > >> ok
> > > >> > to
> > > >> > > me, some tests are failed though. Can someone review it please
> and
> > > >> let me
> > > >> > > know?
> > > >> > >
> > > >> > > Thanks,
> > > >> > > Amir
> > > >> > >
> > > >> > > [1] https://github.com/apache/ignite/pull/3926
> > > >> > > [2] https://issues.apache.org/jira/browse/IGNITE-640
> > > >> > > [3]
> > > >> > > https://ci.ignite.apache.org/viewLog.html?buildId=1255210
> > > >> > > b=buildResultsDiv=IgniteTests24Java8_RunAll
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>

Re: IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Dmitry P., Anton V.,
I made some changes and updated the ticket. Also as was asked I tried to
squash the commits into one but looks like I screwed up everything and the
PR now looks completely terrible. Since I'm not an advanced git user, could
you please check the PR and let me know if anything could be done there? If
not I will try to create a new PR.

Thanks,
Amir

On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov 
wrote:

> Hi Amir,
>
> As far as I know, several Igniters provided some feedback in ticket. Are
> you agree?
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov :
>
> > Hi Amir,
> >
> > This is a very necessary contribution, the patch defenetely will not be
> > ignored.
> >
> > Igniters,
> >
> > Who can make a review from the committers?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > вт, 8 мая 2018 г. в 5:52, Amir Akhmedov :
> >
> >> Hi Igniters,
> >>
> >> Can someone take a look at this PR please?
> >>
> >> Thanks,
> >> Amir
> >>
> >> On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn 
> >> wrote:
> >>
> >> > Hi Amir,
> >> >
> >> > I have filed [1] for multimap in .NET, it will be done later.
> >> > In order to fix IgniteParityTest failures, please add the following to
> >> > MissingMembers array there:
> >> >
> >> > "multimap" // IGNITE-8425
> >> >
> >> > Thanks,
> >> > Pavel
> >> >
> >> >
> >> > [1] https://issues.apache.org/jira/browse/IGNITE-8425
> >> >
> >> > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <
> >> amir.akhme...@gmail.com>
> >> > wrote:
> >> >
> >> > > Hi Igniters,
> >> > >
> >> > > I raised a pull request [1] for Ignite multimap [2]. TC run [3]
> seems
> >> ok
> >> > to
> >> > > me, some tests are failed though. Can someone review it please and
> >> let me
> >> > > know?
> >> > >
> >> > > Thanks,
> >> > > Amir
> >> > >
> >> > > [1] https://github.com/apache/ignite/pull/3926
> >> > > [2] https://issues.apache.org/jira/browse/IGNITE-640
> >> > > [3]
> >> > > https://ci.ignite.apache.org/viewLog.html?buildId=1255210
> >> > > b=buildResultsDiv=IgniteTests24Java8_RunAll
> >> > >
> >> >
> >>
> >
>

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi All,
It's definitely my bad, I had to synch up with community on ticket's
relevance.
Would be nice for future contributors to mention "do get updates on
ticket's relevance for outdated tickets" in Ignite's "How to contribute"
webpage.

Thanks,
Amir

On Tue, May 8, 2018 at 8:39 AM, Dmitriy Setrakyan <dsetrak...@apache.org>
wrote:

> Igniters, let's make sure we add ticket description to the email subject in
> future, so the community will know what the ticket is about. Not everyone
> has time to look for the ticket, especially when the link is not even
> provided in the email.
>
> For example, the subject of this thread should have been: "IGNITE-3999:
> Support case insensitive search in SQL"
>
> D.
>
> On Tue, May 8, 2018 at 2:28 PM, Dmitry Pavlov <dpavlov@gmail.com>
> wrote:
>
> > Hi Vladimir, thank you for stepping in.
> >
> > This case confirms the usefulness of the practice of discussing the
> problem
> > at the devlist before implementation.
> >
> > вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <voze...@gridgain.com>:
> >
> > > Hi,
> > >
> > > I provided my comments in the ticket.
> > >
> > > On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <amir.akhme...@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Nikolay, Dmitry Pavlov,
> > > > Can you take a look at this PR or maybe you have an idea when it
> > probably
> > > > can be reviewed?
> > > >
> > > > Thanks,
> > > > Amir
> > > >
> > > > On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <
> nizhi...@apache.org
> > >
> > > > wrote:
> > > >
> > > > > Hello, Amir.
> > > > >
> > > > > Sorry, but no.
> > > > >
> > > > > I will take a look in a next few days.
> > > > >
> > > > >
> > > > > В Ср, 11/04/2018 в 14:51 +, Amir Akhmedov пишет:
> > > > > > Hi Nikolay,
> > > > > >
> > > > > > Did you have a chance to check my changes?
> > > > > >
> > > > > > Thanks,
> > > > > > Amir
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi Nikolay, Dmitry Pavlov,
Can you take a look at this PR or maybe you have an idea when it probably
can be reviewed?

Thanks,
Amir

On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <nizhi...@apache.org>
wrote:

> Hello, Amir.
>
> Sorry, but no.
>
> I will take a look in a next few days.
>
>
> В Ср, 11/04/2018 в 14:51 +, Amir Akhmedov пишет:
> > Hi Nikolay,
> >
> > Did you have a chance to check my changes?
> >
> > Thanks,
> > Amir
>

Re: IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Hi Igniters,

Can someone take a look at this PR please?

Thanks,
Amir

On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn <ptupit...@apache.org>
wrote:

> Hi Amir,
>
> I have filed [1] for multimap in .NET, it will be done later.
> In order to fix IgniteParityTest failures, please add the following to
> MissingMembers array there:
>
> "multimap" // IGNITE-8425
>
> Thanks,
> Pavel
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-8425
>
> On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <amir.akhme...@gmail.com>
> wrote:
>
> > Hi Igniters,
> >
> > I raised a pull request [1] for Ignite multimap [2]. TC run [3] seems ok
> to
> > me, some tests are failed though. Can someone review it please and let me
> > know?
> >
> > Thanks,
> > Amir
> >
> > [1] https://github.com/apache/ignite/pull/3926
> > [2] https://issues.apache.org/jira/browse/IGNITE-640
> > [3]
> > https://ci.ignite.apache.org/viewLog.html?buildId=1255210
> > b=buildResultsDiv=IgniteTests24Java8_RunAll
> >
>

IGNITE-640: multimap initial implementation

[Amir Akhmedov]

Hi Igniters,

I raised a pull request [1] for Ignite multimap [2]. TC run [3] seems ok to
me, some tests are failed though. Can someone review it please and let me
know?

Thanks,
Amir

[1] https://github.com/apache/ignite/pull/3926
[2] https://issues.apache.org/jira/browse/IGNITE-640
[3]
https://ci.ignite.apache.org/viewLog.html?buildId=1255210=buildResultsDiv=IgniteTests24Java8_RunAll

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi Nikolay,

Did you have a chance to check my changes?

Thanks,
Amir

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi Nikolay,
I fixed the comments. Please check them and let me know.

Thanks,
Amir

On Thu, Apr 5, 2018 at 12:30 AM, Nikolay Izhikov <nizhi...@apache.org>
wrote:

> Hello, Amir.
>
> Please, see my jira comment - https://issues.apache.org/
> jira/browse/IGNITE-3999?focusedCommentId=16426473=com.atlassian.jira.
> plugin.system.issuetabpanels:comment-tabpanel#comment-16426473
>
> В Ср, 04/04/2018 в 20:16 -0400, Amir Akhmedov пишет:
> > Hi Nikolay,
> >
> > Just a gentle reminder :)
> >
> > Thanks,
> > Amir
> >
> > On Fri, Mar 30, 2018 at 12:29 PM, Nikolay Izhikov <nizhi...@apache.org>
> > wrote:
> >
> > > I will take a look at the next week.
> > >
> > > В Пт, 23/03/2018 в 09:50 +0700, Alexey Kuznetsov пишет:
> > > > Vladimir,
> > > >
> > > > As SQL expert, could you review this PR?
> > > >
> > > > In this PR QueryEntity.java was changed. And it may impact whole SQL
> > >
> > > engine.
> > > >
>

Re: IGNITE-3999 review

[Amir Akhmedov]

Hi Nikolay,

Just a gentle reminder :)

Thanks,
Amir

On Fri, Mar 30, 2018 at 12:29 PM, Nikolay Izhikov 
wrote:

> I will take a look at the next week.
>
> В Пт, 23/03/2018 в 09:50 +0700, Alexey Kuznetsov пишет:
> > Vladimir,
> >
> > As SQL expert, could you review this PR?
> >
> > In this PR QueryEntity.java was changed. And it may impact whole SQL
> engine.
> >
>

Re: IGNITE-3999 review

[Amir Akhmedov]

Dmitriy,

Thank you for a hint. Please find below a link to new TeamCity run. This
time looks much better but still has a lot of failed tests. But most of
them not related to my changes except failed .Net tests. Can you please
review and advise on next steps?

Thanks,
Amir

https://ci.ignite.apache.org/viewLog.html?buildId=1152609=buildResultsDiv=IgniteTests24Java8_RunAll

On Thu, Mar 22, 2018 at 7:36 AM, Dmitry Pavlov <dpavlov@gmail.com>
wrote:

> Hi Amir,
>
> It seems reason was compilation error
>  Compilation error: Compiler
> Compilation failure
> /data/teamcity/work/bd85361428dcdb1/modules/indexing/src/test/java/org/
> apache/ignite/internal/processors/query/IgniteSqlCaseInsensitiveTest.
> java:[614,23]
> cannot find symbol
>   symbol:   method
> querySqlFieldsNoCache(org.apache.ignite.cache.query.
> SqlFieldsQuery,boolean)
>   location: variable qryProc of type
> org.apache.ignite.internal.processors.query.GridQueryProcessor
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 22 мар. 2018 г. в 6:02, Amir Akhmedov <amir.akhme...@gmail.com>:
>
> > Dmitry,
> >
> > TeamCity RunAll completed but the results look awkward. Almost all test
> > suites marked as failed. I noticed the same behavior for other builds
> > though.
> > If you don't mind could you please check is it alright and let me know?
> >
> >
> > https://ci.ignite.apache.org/viewLog.html?buildTypeId=
> IgniteTests24Java8_RunAll=1150589_
> IgniteTests24Java8_RunAll=pull/3444/head
> >
> > Thanks,
> > Amir
> >
>



-- 
Sincerely Yours Amir Akhmedov

Re: Subject: new committer: Dmitry Pavlov

[Amir Akhmedov]

Congratulations!
Such an impressive amount of work in such a short time!

Thanks,
Amir

Re: IGNITE-3999 review

[Amir Akhmedov]

Dmitry,

TeamCity RunAll completed but the results look awkward. Almost all test
suites marked as failed. I noticed the same behavior for other builds
though.
If you don't mind could you please check is it alright and let me know?

https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_RunAll=1150589_IgniteTests24Java8_RunAll=pull/3444/head

Thanks,
Amir

Re: IGNITE-3999 review

[Amir Akhmedov]

Dmitry,

Since the last TC test run has been done almost 2 months ago I decided to
run it again since lot of changes were introduced.
I will let you know when tests are finished.

Thanks,
Amir

IGNITE-3999 review

[Amir Akhmedov]

Hi Team,

Can anybody review https://github.com/apache/ignite/pull/3444 please?

Thanks,
Amir

IGNITE-3999: Design discussion

[Amir Akhmedov]

Hi Igniters,

I was looking into ticket IGNITE-3999 and I have a concern on this, can you
please advise what will be the correct way to solve it. As of today, SQL
fields are defined as setFields(LinkedHashMap<String, String> fields), with
introduction of case insensitive property need to create a new POJO
e.g. QueryField(String
type, boolean caseInsensitive). So, to keep backward compatibility we can
introduce a new method e.g. setQueryFields(LinkedHashMap<String,
QueryField> fields), in my opinion it looks like counter-intuitive with
existing setFields method. Another possible way, this change can be done
with changing the generic type of setFields (which will not be backward
compatible) and released in Ignite 2.0.
Please advise on this, or maybe you have an alternative solutions?

-- 
Sincerely Yours Amir Akhmedov

PR review

[Amir Akhmedov]

Hi Igniters,

I raised PR for IGNITE-4176. Can you please review it and let me know?

https://issues.apache.org/jira/browse/IGNITE-4176

-- 
Sincerely Yours Amir Akhmedov

Pull request for IGNITE-3699

[Amir Akhmedov]

Hi community,

I raised a pull request [1] Can you please review it?

[1] https://github.com/apache/ignite/pull/1011

Thanks.

Re: IGNITE-640: IgniteMultimap interface draft version

[Amir Akhmedov]

I updated the ticket with design details. Can you please review it and put
your comments?

https://issues.apache.org/jira/browse/IGNITE-640

On Fri, Aug 12, 2016 at 4:03 PM, Amir Akhmedov <amir.akhme...@gmail.com>
wrote:

> I think we need both Collection and List interfaces as Guava has.
> Dmitriy provided a really good example for List based Multimap. Set based
> implementation also has a plenty use cases like guarantee for value
> uniqueness or performance reasons for remove(key, value),
> containsEntry(key, value) methods
>
> On Aug 12, 2016 3:41 PM, "Dmitriy Setrakyan" <dsetrak...@apache.org>
> wrote:
>
>> One of the good use cases for MutliMap is time-series data, which assumes
>> ordering. This means that we need to store values for the key exactly in
>> the same order as they are provided. If we do that, then returning lists
>> should not be a problem. No?
>>
>> On Fri, Aug 12, 2016 at 9:38 AM, Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>> > Vova, Denis,
>> >
>> > How do you see this API-wise? What if user actually wants to get a
>> sublist
>> > of values, without fetching the whole collection?  Are you suggesting to
>> > have subinterfaces, similar to Guava [1]?
>> >
>> > [1]
>> > https://google.github.io/guava/releases/snapshot/api/
>> > docs/com/google/common/collect/ListMultimap.html
>> >
>> > -Val
>> >
>> > On Fri, Aug 12, 2016 at 12:14 PM, Denis Magda <dma...@gridgain.com>
>> wrote:
>> >
>> > > Fully agree with Vovan’s suggestion. It’s not a good idea to hard code
>> > the
>> > > interface to the usage of List.
>> > >
>> > > Moreover, I would provide an implementation of the IgniteMultimap with
>> > > TreeSet under the hood out of the box. A user will be able to use this
>> > > implementation if performance of multi map updates is more critical
>> for a
>> > > use case.
>> > >
>> > > —
>> > > Denis
>> > >
>> > >
>> > > > On Aug 12, 2016, at 12:01 PM, Vladimir Ozerov <voze...@gridgain.com
>> >
>> > > wrote:
>> > > >
>> > > > Correct me if I am wrong, but I always thought that multimap is
>> about
>> > > > associating multiple values with a single key without explicit
>> > > > specification on how these values are stored. E.g.:
>> > > > Google Guava -
>> > > > https://google.github.io/guava/releases/snapshot/api/
>> > > docs/com/google/common/collect/Multimap.html#get(K)
>> > > > Apache Commons -
>> > > > https://commons.apache.org/proper/commons-collections/
>> > > apidocs/org/apache/commons/collections4/MultiValuedMap.html#get(K)
>> > > >
>> > > > I would rather return *Collection*, but with ability to specify
>> > > underlying
>> > > > data structure using some factory.
>> > > >
>> > > > On Fri, Aug 12, 2016 at 6:35 PM, Dmitriy Setrakyan <
>> > > dsetrak...@apache.org>
>> > > > wrote:
>> > > >
>> > > >> Amir,
>> > > >>
>> > > >> It is great that you decided to pick this ticket. I suggest to
>> handle
>> > > the
>> > > >> design discussions in the ticket itself, as Jira allows for better
>> > code
>> > > >> formatting. It still makes sense, though, to notify the dev list
>> that
>> > > you
>> > > >> have updated the ticket, so folks remember to look at it.
>> > > >>
>> > > >> D.
>> > > >>
>> > > >> On Thu, Aug 11, 2016 at 7:26 PM, Amir Akhmedov <
>> > amir.akhme...@gmail.com
>> > > >
>> > > >> wrote:
>> > > >>
>> > > >>> Hi guys,
>> > > >>>
>> > > >>> I noticed that IgniteMultimap waits too long to be implemented
>> and I
>> > > >>> decided to pick it up :-)
>> > > >>>
>> > > >>> For now I want to bring to community up a draft version for
>> > > >> IgniteMultimap
>> > > >>> interface. Will appreciate any feedback and once it's fine I will
>> > start
>> > > >> its
>> > > >>> implementation
>> > > >>>
>> > > >>>

IGNITE-640: IgniteMultimap interface draft version

[Amir Akhmedov]

ultimap multimap);

/**
 * Removes the key and all values associated with the key {@code key}.
 *
 * @return the list of values that were removed, or {@code null}
 * if this map contains no mapping for the key.
 * @throws ClassCastException if the key is of an inappropriate
type for this map
 */
public List remove(K key);

/**
 * Removes a single key-value pair with the key {@code key} and the value
 * {@code value} from this multimap, if such exists. If multiple key-value
 * pairs in the multimap fit this description, which one is removed is
 * unspecified.
 *
 * @return {@code true} if the multimap changed
 * @throws ClassCastException if the key is of an inappropriate
type for this map
 */
public boolean remove(K key, V value);

/**
 * Stores a collection of values with the same key, replacing any existing
 * values for that key.
 *
 * @return the collection of replaced values, or {@code null}
 * if this map contains no mapping for the key.
 * @throws ClassCastException if the key is of an inappropriate
type for this map
 */
List replaceValues(K key, Iterable values);

/**
 * Returns {@code true} if this map contains no key-value mappings.
 *
 * @return {@code true} if this map contains no key-value mappings
 */

public boolean isEmpty();

/**
 * Returns the number of keys in this map. If the map contains
more than {@code Integer.MAX_VALUE}
 * elements, returns {@code Integer.MAX_VALUE}.
 *
 * @return the number of keys in this map
 */
public int size();

/**
 * Returns a list containing the value from each key-value
 * pair contained in this multimap, without collapsing duplicates.
 *
 * @return a list containing the value from each key-value
 * pair contained in this multimap, without collapsing duplicates.
 */
public List values();

/**
 * Returns the number of values that match the given key in the multimap.
 *
 * @param key the key whose values count is to be returned
 * @return the number of values that match the given key in the multimap
 */
public int valueCount(K key);

/**
 * Gets multimap name.
 *
 * @return Multimap name.
 */
public String name();

/**
 * Removes this multimap.
 *
 * @throws IgniteException If operation failed.
 */
@Override public void close() throws IgniteException;

/**
 * Returns {@code true} if this multimap can be kept on the one node only.
 * Returns {@code false} if this multimap can be kept on the many nodes.
 *
 * @return {@code true} if this multimap is in {@code collocated}
mode {@code false} otherwise.
 */
public boolean collocated();

/**
 * Executes given job on collocated multimap on the node where the
multimap is located
 * (a.k.a. affinity co-location).
 * 
 * This is not supported for non-collocated multimaps.
 *
 * @param job Job which will be co-located with the multimap.
 * @throws IgniteException If job failed.
 */
public void affinityRun(IgniteRunnable job) throws IgniteException;

/**
 * Executes given job on collocated multimap on the node where the
multimap is located
 * (a.k.a. affinity co-location).
 * 
 * This is not supported for non-collocated multimaps.
 *
 * @param job Job which will be co-located with the multimap.
 * @throws IgniteException If job failed.
 */
public  R affinityCall(IgniteCallable job) throws IgniteException;
}



-- 
Sincerely Yours Amir Akhmedov

Re: IGNITE-1227 patch available

[Amir Akhmedov]

Denis, Artem,

Thank you guys for clarification. Latter I'll provide a pull-request for
this ticket.

I think the page [1] should also be updated, cause I followed the steps
from there.

[1] https://ignite.apache.org/community/contribute.html#contribute

2015-11-16 14:26 GMT+03:00 Artem Shutak <ashu...@gridgain.com>:

> Denis, Amir,
>
> First of all, need to understand how it works on TC. TC downloads a patch
> file and applies it by 'git am ' to the latest master. That is
> mentioned on How to Contribute
> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> -
> see "2. Create a Patch-file"/"Applying"
>
> As I see in build logs (
>
> http://ci.ignite.apache.org/viewLog.html?buildId=75417=Ignite_IgniteCacheFullApi=buildLog==none#_state=78=78
> )
> the patch-file couldn't be applied.
>
> Step 3/7: Apply patch (if exist) (Gradle)
> ...
> :patchapply
> ...
> [10:32:08]Trying to apply patch.
> [10:32:08]Executing command 'git am
> dev-tools/IGNITE-1227-12772149.patch'...
> [10:32:08]Command output:
> [10:32:08]
> [10:32:08]Return code: 1
> [10:32:08]Patch was not applied successfully. Aborting patch applying.
>
> I did it locally and got "Patch format detection failed.". According to a
> head of the content of the file, the patch has been created by IDEA - it's
> wrong way. To create patch manually you need to use "git format-patch" or I
> recommend you to use "/scripts/git-format-patch.sh". See How
> to Contribute
> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> -
> "2.
> Create a Patch-file".
>
> Also, I want to say +1 for an Denis's advice to use a pull-request way.
> This way has no minuses and has a lots of pluses by my opinion against
> patch-way.
>
> Thanks,
> -- Artem --
>
> On Mon, Nov 16, 2015 at 1:39 PM, Denis Magda <dma...@gridgain.com> wrote:
>
> > Amir, before making a review I want to be sure that all Ignite test
> suites
> > are green.
> >
> > However, seems that the patch based way contribution is broken. When I
> > open a test run info for any suite I see the following
> > http://ci.ignite.apache.org/viewLog.html?buildId=75417
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':patchapply'.
> > > Process 'command '/usr/lib/jvm/java-7-oracle/bin/java'' finished with
> > non-zero exit value 1
> >
> >
> > Artem, do we still support the patch based contribution?
> >
> > Amir, until we’re resolving issue with the patches please follow the
> > pull-request way. This way of contribution is a preferred one and works
> > fine:
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
> > <
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
> > >
> > Before you push your pull request please get to know our coding
> guidelines
> > (identations, brackets usage, etc.). You have some issues in your code
> > related to guidelines. You’ll see them when familiarize yourself with
> this
> > doc:
> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines <
> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines>
> >
> >
> > Regards,
> > Denis
> >
> > > On 13 нояб. 2015 г., at 15:32, Denis Magda <dma...@gridgain.com>
> wrote:
> > >
> > > Amir, great thanks!
> > >
> > > If you don't mind I'll review your changes in a couple of days.
> > >
> > >
> > > However, probably someone else will do this earlier:)
> > >
> > > --
> > > Denis
> > >
> > >
> > > From: Amir Akhmedov <amir.akhme...@gmail.com  > amir.akhme...@gmail.com>>
> > > Date: Fri, Nov 13, 2015 at 11:28 AM
> > > Subject: IGNITE-1227 patch available
> > > To: dev@ignite.apache.org <mailto:dev@ignite.apache.org>
> > >
> > >
> > > Hi Igniters,
> > >
> > > I submitted patch for IGNITE-1227
> > > <https://issues.apache.org/jira/browse/IGNITE-1227 <
> > https://issues.apache.org/jira/browse/IGNITE-1227>>, could review it
> > > whenever it is possible.
> > >
> > > Thanks.
> > >
> > > --
> > > Sincerely Yours Amir Akhmedov
> > >
> > >
> >
> >
>



-- 
Sincerely Yours Amir Akhmedov

Re: Implement IgniteMultimap data structures

[Amir Akhmedov]

I'll do my best :)

Then I'll assign it to me.

Thanks.

2015-11-13 14:47 GMT+03:00 Yakov Zhdanov <yzhda...@apache.org>:

> Amir, you are welcome! It would be cool if we can get it to 1.6
>
> --Yakov
>
> 2015-11-13 13:50 GMT+03:00 Amir Akhmedov <amir.akhme...@gmail.com>:
>
> > Hi,
> >
> > If no objections then I would like to start to work on this ticket (
> > IGNITE-640 <https://issues.apache.org/jira/browse/IGNITE-640>)
> >
> > --
> > Sincerely Yours Amir Akhmedov
> >
>



-- 
Sincerely Yours Amir Akhmedov

IGNITE-1227 patch available

[Amir Akhmedov]

Hi Igniters,

I submitted patch for IGNITE-1227
<https://issues.apache.org/jira/browse/IGNITE-1227>, could review it
whenever it is possible.

Thanks.

-- 
Sincerely Yours Amir Akhmedov

Implement IgniteMultimap data structures

[Amir Akhmedov]

Hi,

If no objections then I would like to start to work on this ticket (
IGNITE-640 <https://issues.apache.org/jira/browse/IGNITE-640>)

-- 
Sincerely Yours Amir Akhmedov

Re: Integration with Spring Transaction Manager

[Amir Akhmedov]

Hi Denis,

No, my account has not been granted permissions. If you have a permission
could you grant me them. My jira account: aakhmedov

Thanks.

2015-11-04 15:32 GMT+03:00 Denis Magda <dma...@gridgain.com>:

> Hello Amir,
>
> You can do it on your own. Do you have a JIRA account that was granted all
> required permissions?
>
> --
> Denis
>
>
> On 11/4/2015 1:01 PM, Amir Akhmedov wrote:
>
>> Hi Dmitriy,
>>
>> I want to give a try on this ticket. Could you assign it to me?
>>
>> Thanks.
>>
>>
>


-- 
Sincerely Yours Amir Akhmedov

Re: Integration with Spring Transaction Manager

[Amir Akhmedov]

Hi Dmitriy,

I want to give a try on this ticket. Could you assign it to me?

Thanks.