Review needed: IGNITE-13572, Duplicates in select query during partition eviction for caches with 0 backups

2020-12-01 Thread Konstantin Sirotkin
Hi!

Please review the changes.

https://issues.apache.org/jira/browse/IGNITE-13572 
<https://issues.apache.org/jira/browse/IGNITE-13572>

Thanks!

---
Best regards,
Konstantin Sirotkin | Senior Java Developer



[jira] [Created] (IGNITE-13700) ConcurrentModificationException on node join.

2020-11-12 Thread Konstantin Sirotkin (Jira)
Konstantin Sirotkin created IGNITE-13700:


 Summary: ConcurrentModificationException on node join.
 Key: IGNITE-13700
 URL: https://issues.apache.org/jira/browse/IGNITE-13700
 Project: Ignite
  Issue Type: Bug
Reporter: Konstantin Sirotkin
Assignee: Konstantin Sirotkin


This issue was created for more complex investigation of problem IGNITE-13554.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review needed: IGNITE-13420, Add assertion message to assert in CachedDeploymentInfo private constructor

2020-09-09 Thread Konstantin Sirotkin
Hi!

Please review the changes.

https://issues.apache.org/jira/browse/IGNITE-13420 
<https://issues.apache.org/jira/browse/IGNITE-13420>

Thanks!

---
Kind Regards,
Konstantin Sirotkin



Review needed: IGNITE-13102, IgniteCache#isClosed() returns false on server node even if the cache had been closed before.

2020-08-06 Thread Konstantin Sirotkin
Hi!

Please review the changes.

https://issues.apache.org/jira/browse/IGNITE-13102

Thanks!

---
Kind Regards,
Konstantin Sirotkin



IGNITE-13315, please review the pull request

2020-07-31 Thread Konstantin Sirotkin
Hello!

Please review the changes. 
This PR contains one line:)

Thanks.

---
Kind Regards,
Konstantin Sirotkin



Re: IGNITE-13069, please review pull request

2020-07-31 Thread Konstantin Sirotkin
Hello!

Done, I divided the PR into five smaller ones 8090-8093,8095.
Can someone please check the changes now?

Thanks.

---
Kind Regards,
Konstantin Sirotkin

> On 28 Jul 2020, at 22:18, Konstantin Sirotkin  
> wrote:
> 
> Now I am working on breaking this PR into smaller parts.
> 
> On 2020/07/28 18:55:51, Denis Magda http://apache.org/>> 
> wrote: 
> > Nick, Alex,> 
> > 
> > Could any of you please check the changes by Konstantin? If there are 
> > other> 
> > committers who can review the pull-request please loop them in.> 
> > 
> > -> 
> > Denis> 
> > 
> > 
> > On Mon, Jul 27, 2020 at 11:37 PM Konstantin Sirotkin <> 
> > konstantins...@gmail.com <mailto:konstantins...@gmail.com>> wrote:> 
> > 
> > > Hello> 
> > >> 
> > > Please review pull request - https://github.com/apache/ignite/pull/8063 
> > > <https://github.com/apache/ignite/pull/8063> <> 
> > > https://github.com/apache/ignite/pull/8063 
> > > <https://github.com/apache/ignite/pull/8063>>> 
> > > Apache jira issue - https://issues.apache.org/jira/browse/IGNITE-13069 
> > > <https://issues.apache.org/jira/browse/IGNITE-13069> <> 
> > > https://issues.apache.org/jira/browse/IGNITE-13069 
> > > <https://issues.apache.org/jira/browse/IGNITE-13069>>> 
> > >> 
> > > Thanks> 
> > >> 
> > > Konstantin Sirotkin> 
> >  
> 
> 
> ---
> Kind Regards,
> Konstantin Sirotkin
> 



[jira] [Created] (IGNITE-13315) Uninformative TxDumpsThrottling toString output.

2020-07-30 Thread Konstantin Sirotkin (Jira)
Konstantin Sirotkin created IGNITE-13315:


 Summary: Uninformative TxDumpsThrottling toString output.
 Key: IGNITE-13315
 URL: https://issues.apache.org/jira/browse/IGNITE-13315
 Project: Ignite
  Issue Type: Improvement
  Components: general
Affects Versions: 2.8.1
Reporter: Konstantin Sirotkin
Assignee: Konstantin Sirotkin


looks like e need additional @GridToStringExclude for:
GridNearTxLocal#txDumpsThrottling

{noformat} 

2020-07-27 18:38:06.983[WARN 
][exchange-worker-#155%DPL_GRID%DplGridNodeName%][o.apache.ignite.internal.diagnostic]
 >>> [txVer=null, exchWait=false, tx=GridNearTxLocal 
[mappings=IgniteTxMappingsSingleImpl [mapping=null], nearLocallyMapped=false, 
colocatedLocallyMapped=false, needCheckBackup=null, hasRemoteLocks=false, 
trackTimeout=false, systemTime=0, systemStartTime=0, prepareStartTime=0, 
prepareTime=0, commitOrRollbackStartTime=0, commitOrRollbackTime=0, 
*txDumpsThrottling=o.a.i.i.processors.cache.transactions.IgniteTxManager$TxDumpsThrottling@66ede293*,
 lb=null, thread=, 
mappings=IgniteTxMappingsSingleImpl [mapping=null], super=GridDhtTxLocalAdapter 
[nearOnOriginatingNode=false, nearNodes=KeySetView [], dhtNodes=KeySetView [], 
explicitLock=false, super=IgniteTxLocalAdapter [completedBase=null, 
sndTransformedVals=false, depEnabled=false, 
txState=IgniteTxImplicitSingleStateImpl [init=false, recovery=false], 
super=IgniteTxAdapter [xidVer=GridCacheVersion [topVer=206004504, 
order=1595859218447, nodeOrder=1], writeVer=null, implicit=true, loc=true, 
threadId=997408, startTime=1595863641166, 
nodeId=1227c1de-f539-47ef-baef-5d04e259d590, startVer=GridCacheVersion 
[topVer=206004504, order=1595859218447, nodeOrder=1], endVer=null, 
isolation=READ_COMMITTED, concurrency=OPTIMISTIC, timeout=0, 
sysInvalidate=false, sys=true, plc=5, commitVer=null, finalizing=NONE, 
invalidParts=null, state=ACTIVE, timedOut=false, topVer=AffinityTopologyVersion 
[topVer=-1, minorTopVer=0], skipCompletedVers=false, duration=645816ms, 
onePhaseCommit=false], size=0

{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: IGNITE-13069, please review pull request

2020-07-28 Thread Konstantin Sirotkin
Now I am working on breaking this PR into smaller parts.

On 2020/07/28 18:55:51, Denis Magda  wrote: 
> Nick, Alex,> 
> 
> Could any of you please check the changes by Konstantin? If there are other> 
> committers who can review the pull-request please loop them in.> 
> 
> -> 
> Denis> 
> 
> 
> On Mon, Jul 27, 2020 at 11:37 PM Konstantin Sirotkin <> 
> konstantins...@gmail.com> wrote:> 
> 
> > Hello> 
> >> 
> > Please review pull request - https://github.com/apache/ignite/pull/8063 <> 
> > https://github.com/apache/ignite/pull/8063>> 
> > Apache jira issue - https://issues.apache.org/jira/browse/IGNITE-13069 <> 
> > https://issues.apache.org/jira/browse/IGNITE-13069>> 
> >> 
> > Thanks> 
> >> 
> > Konstantin Sirotkin> 
>  


---
Kind Regards,
Konstantin Sirotkin



[jira] [Created] (IGNITE-13307) need update documentation in part of baseline-topology

2020-07-28 Thread Konstantin Sirotkin (Jira)
Konstantin Sirotkin created IGNITE-13307:


 Summary: need update documentation in part of baseline-topology
 Key: IGNITE-13307
 URL: https://issues.apache.org/jira/browse/IGNITE-13307
 Project: Ignite
  Issue Type: Improvement
  Components: documentation
Reporter: Konstantin Sirotkin


Need to update documentation 
[baseline-topology|https://apacheignite.readme.io/docs/baseline-topology]

Documentation says that the baseline topology is built only for server nodes 
with enabled persistence

At the moment, the basic topology is being built for all server nodes, 
including in-memory



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-13305) if create topologyValidator as lambda then get error "Cache topology validator mismatch"

2020-07-28 Thread Konstantin Sirotkin (Jira)
Konstantin Sirotkin created IGNITE-13305:


 Summary: if create topologyValidator as lambda then get error 
"Cache topology validator mismatch"
 Key: IGNITE-13305
 URL: https://issues.apache.org/jira/browse/IGNITE-13305
 Project: Ignite
  Issue Type: Bug
  Components: cache
Reporter: Konstantin Sirotkin


Check of cache topology validator fails if create it as lambda.

For reproducing: 

In 
org.apache.ignite.internal.processors.cache.IgniteTopologyValidatorCacheGroupsAbstractTest#getConfiguration

{{{code:java|borderStyle=solid}}}

{{}}

TopologyValidator val1 = new TopologyValidator() {
    @Override public boolean validate(Collection nodes) {
        return nodes.size() == 2;
    }
};

{{}}

{{{code}}}

replace on {{}}

{{}}

{{{code:java|borderStyle=solid}}}

TopologyValidator val1 = nodes -> nodes.size() == 2;

{{{code}}}

{{Check fails in }}

{{org.apache.ignite.internal.processors.cache.ClusterCachesInfo#checkCache}}

{{when compare local and remote topologyValidators by class name }}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


IGNITE-13069, please review pull request

2020-07-28 Thread Konstantin Sirotkin
Hello

Please review pull request - https://github.com/apache/ignite/pull/8063 
<https://github.com/apache/ignite/pull/8063>
Apache jira issue - https://issues.apache.org/jira/browse/IGNITE-13069 
<https://issues.apache.org/jira/browse/IGNITE-13069>

Thanks

Konstantin Sirotkin

Re: request for contributors permissions

2020-07-17 Thread Konstantin Sirotkin
ksirotkin

On 2020/07/16 15:33:15, Denis Magda  wrote: 
> Hello Konstantin and welcome to the community!> 
> 
> Please share your JIRA id so that we can add you to the contributors' list> 
> there and you can select a ticket of your interest.> 
> 
> -> 
> Denis> 
> 
> 
> On Thu, Jul 16, 2020 at 8:29 AM Konstantin Sirotkin <> 
> konstantins...@gmail.com> wrote:> 
> 
> > Helloi've registered on> 
> > https://issues.apache.org/jira/secure/Dashboard.jsp> 
> >  and> 
> > according to> 
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute I'm> 
> > requesting contributors permissionsthank you> 
> >> 
> > Konstantin Sirotkin> 
> >> 
>  

С уважением,
Konstantin Sirotkin (Константин Сироткин) | Senior Java Developer
skype, telegram: konstantins304 | linkedin 
<https://www.linkedin.com/in/konstantin-sirotkin-609b31100> | career.habr 
<https://career.habr.com/konstantins304>


Re: request for contributors permissions

2020-07-17 Thread Konstantin Sirotkin
ksirotkin

Thank you,
Konstantin Sirotkin

On 2020/07/16 15:33:15, Denis Magda  wrote: 
> Hello Konstantin and welcome to the community!> 
> 
> Please share your JIRA id so that we can add you to the contributors' list> 
> there and you can select a ticket of your interest.> 
> 
> -> 
> Denis> 
> 
> 
> On Thu, Jul 16, 2020 at 8:29 AM Konstantin Sirotkin <> 
> konstantins...@gmail.com> wrote:> 
> 
> > Helloi've registered on> 
> > https://issues.apache.org/jira/secure/Dashboard.jsp> 
> >  and> 
> > according to> 
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute I'm> 
> > requesting contributors permissionsthank you> 
> >> 
> > Konstantin Sirotkin> 
> >> 
>  

С уважением,
Konstantin Sirotkin (Константин Сироткин) | Senior Java Developer
skype, telegram: konstantins304 | linkedin 
<https://www.linkedin.com/in/konstantin-sirotkin-609b31100> | career.habr 
<https://career.habr.com/konstantins304>


request for contributors permissions

2020-07-16 Thread Konstantin Sirotkin
Helloi've registered on https://issues.apache.org/jira/secure/Dashboard.jsp
 and
according to
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute I'm
requesting contributors permissionsthank you

Konstantin Sirotkin