Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-05-14 Thread Nikolay Izhikov
Ticket for IEP.Phase1 created - https://issues.apache.org/jira/browse/IGNITE-11848 В Пн, 13/05/2019 в 18:06 +0300, Nikolay Izhikov пишет: > Hello, Igniters. > > We have discussed this IEP [1] with Alexey Goncharyuk, Anton Vinogradov, > Andrey Gura, Alexey Scherbakov and Pavel Kovalenko. > >

Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-05-13 Thread Nikolay Izhikov
Hello, Igniters. We have discussed this IEP [1] with Alexey Goncharyuk, Anton Vinogradov, Andrey Gura, Alexey Scherbakov and Pavel Kovalenko. Issues to address: 1. Study experience of following libs, tools: * OpenTracing * OpenSensus * DropWizard 2. Support histogram

Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-05-02 Thread Nikolay Izhikov
Hello, Maxim. > How will be recorded throughput sensor values which will require an interval > for the rate calculations? I answered to this question in IEP "Design principles": ``` Sensors should contain only raw values. No aggregation of numeric metrics on Ignite side. Min, max, avg and

Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-04-30 Thread Maxim Muzafarov
Hello Nikolay, I've looked through your PRs changes. > Sensors How will be recorded throughput sensor values which will require an interval for the rate calculations? Do we have such an example? For instance, getAllocationRate() or getEvictionRate(). These metrics are out of the scope of

Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-04-29 Thread Nikolay Izhikov
Hello, Vyacheslav. Thanks for the feedback! > HttpExposer with Jetty's dependencies should be detached> from the core > module. Agreed. module hierarchy is the essence of the next steps. For now it just a proof of my ideas for Ignite monitoring we can discuss. > I like your approach with

Re: [IEP-35] Monitoring & Profiling. Proof of concept

2019-04-28 Thread Vyacheslav Daradur
Hi, Nikolay, I looked through PR and IEP, and I have some comments: It would be better to implement it as a separate module, I can't say if it is possible for the main part of monitoring or not, but I believe that HttpExposer with Jetty's dependencies should be detached from the core module. I

[IEP-35] Monitoring & Profiling. Proof of concept

2019-04-26 Thread Nikolay Izhikov
Hello, Igniters. I've prepared Proof of Concept for IEP-35 [1] PR can be found here - https://github.com/apache/ignite/pull/6510 I've done following changes: 1. `GridMonitoringManager` [2] - simple implementation of manager to store all monitoring info 2. `HttpPullExposerSpi`