RE: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Jason Man, CLSA
To: dev@ignite.apache.org; Igor Rudyak Subject: Re: Adopting mock framework (ex. Mockito) for unit tests Looks we came to a consensus. Jason, please change the PR the way you say > I will change my PR to add the dependency at parent POM level and use it only > for my test in ignite-cas

Re: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Denis Magda
> for my test in ignite-cassandra. > > Jason > > -Original Message- > From: Denis Magda [mailto:dma...@apache.org] > Sent: Wednesday, January 17, 2018 3:53 AM > To: dev@ignite.apache.org > Subject: Re: Adopting mock framework (ex. Mockito) for unit t

RE: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Jason Man, CLSA
...@apache.org] Sent: Wednesday, January 17, 2018 3:53 AM To: dev@ignite.apache.org Subject: Re: Adopting mock framework (ex. Mockito) for unit tests Agree with Igor’s opinion. If it simplifies Cassandra integration testing cycles and maintenance then we should go for it for *this* component only. No need

Re: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Denis Magda
Agree with Igor’s opinion. If it simplifies Cassandra integration testing cycles and maintenance then we should go for it for *this* component only. No need to push it to all the component we have. — Denis > On Jan 16, 2018, at 10:24 AM, Igor Rudyak wrote: > > It will be

Re: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Igor Rudyak
It will be good to clarify what do you mean by adopt? Can't we just start using it as is for specific cases? I understand that there are some cases which probably not the best scenario for Mockito. At the same time there are lot's of other cases (like in IGNITE-6853

Re: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Vladimir Ozerov
Mocking is a good testing technique, but over years we failed to adopt it in Ignite. The reason is high project complexity, when a lot of components are interact with each other, and it is very hard to extract clean interfaces out of it. We definitely could do better with our OOP, but you should

Re: Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Alexey Kukushkin
Hi Jason, I heartily support unit testing practices and introducing a mocking framework into ignite development environment. Today I can hardly find a single unit test in Apache Ignite, which does not allow me to use the best TDD and CI/CD practices like running tests on every commit (or even on

Adopting mock framework (ex. Mockito) for unit tests

2018-01-16 Thread Jason Man, CLSA
Hi Igniters, I'd like to discuss the topic of adopting a mock framework such as Mockito into Ignite's project for writing unit tests. Here's a simple article that illustrate why using a mock object for testing is necessary, and why using a framework is better than doing it yourself: