Re: GridCacheReplicatedFullApiMultithreadedSelfTest1 not used, not compile. Remove?
Merged to master. Thank you, Maxim. пт, 27 июл. 2018 г. в 11:17, Maxim Muzafarov : > Folks, > > I've found issue related to this test [1] (created 2016). > Looks like it not used, I've prepared PR [2]. > > If you have time, please, review changes. > > > [1] https://issues.apache.org/jira/browse/IGNITE-3499 > [2] https://github.com/apache/ignite/pull/4443 > > > On Fri, 20 Jul 2018 at 13:27 Dmitry Pavlov wrote: > > > Hi Maxim, > > > > I think we should remove such code. And if nobody objects I can apply PR > on > > Monday. > > > > Ilya, please confirm you're agree. > > > > Sincerely, > > Dmitriy Pavlov > > > > пт, 20 июл. 2018 г. в 13:16, Maxim Muzafarov : > > > > > Ignites, > > > > > > I've faced with test in Ignite code base that is fully commented. You > can > > > check it > > > by yoursefl [1]. As it not used since 2014 and not even compile I'm > > > suggesting > > > to remove it. > > > > > > What do you think about it? Please, share your thoughts. > > > > > > Full name: > > > > > > > > > org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedFullApiMultithreadedSelfTest1 > > > > > > [1] > > > > > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/replicated/GridCacheReplicatedFullApiMultithreadedSelfTest1.java > > > -- > > > -- > > > Maxim Muzafarov > > > > > > -- > -- > Maxim Muzafarov >
Re: GridCacheReplicatedFullApiMultithreadedSelfTest1 not used, not compile. Remove?
Folks, I've found issue related to this test [1] (created 2016). Looks like it not used, I've prepared PR [2]. If you have time, please, review changes. [1] https://issues.apache.org/jira/browse/IGNITE-3499 [2] https://github.com/apache/ignite/pull/4443 On Fri, 20 Jul 2018 at 13:27 Dmitry Pavlov wrote: > Hi Maxim, > > I think we should remove such code. And if nobody objects I can apply PR on > Monday. > > Ilya, please confirm you're agree. > > Sincerely, > Dmitriy Pavlov > > пт, 20 июл. 2018 г. в 13:16, Maxim Muzafarov : > > > Ignites, > > > > I've faced with test in Ignite code base that is fully commented. You can > > check it > > by yoursefl [1]. As it not used since 2014 and not even compile I'm > > suggesting > > to remove it. > > > > What do you think about it? Please, share your thoughts. > > > > Full name: > > > > > org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedFullApiMultithreadedSelfTest1 > > > > [1] > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/replicated/GridCacheReplicatedFullApiMultithreadedSelfTest1.java > > -- > > -- > > Maxim Muzafarov > > > -- -- Maxim Muzafarov
Re: GridCacheReplicatedFullApiMultithreadedSelfTest1 not used, not compile. Remove?
Hi Maxim, I think we should remove such code. And if nobody objects I can apply PR on Monday. Ilya, please confirm you're agree. Sincerely, Dmitriy Pavlov пт, 20 июл. 2018 г. в 13:16, Maxim Muzafarov : > Ignites, > > I've faced with test in Ignite code base that is fully commented. You can > check it > by yoursefl [1]. As it not used since 2014 and not even compile I'm > suggesting > to remove it. > > What do you think about it? Please, share your thoughts. > > Full name: > > org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedFullApiMultithreadedSelfTest1 > > [1] > > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/replicated/GridCacheReplicatedFullApiMultithreadedSelfTest1.java > -- > -- > Maxim Muzafarov >
GridCacheReplicatedFullApiMultithreadedSelfTest1 not used, not compile. Remove?
Ignites, I've faced with test in Ignite code base that is fully commented. You can check it by yoursefl [1]. As it not used since 2014 and not even compile I'm suggesting to remove it. What do you think about it? Please, share your thoughts. Full name: org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedFullApiMultithreadedSelfTest1 [1] https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/replicated/GridCacheReplicatedFullApiMultithreadedSelfTest1.java -- -- Maxim Muzafarov
