Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)

Hi Maxim, I merged your changes to master. Thanks for the contribution! -Val On Thu, Apr 6, 2017 at 1:33 AM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Maxim, > > I will take a look today or tomorrow. > > -Val > > On Tue, Apr 4, 2017 at 7:40 AM, Kozlov Maxim

Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)

Maxim, I will take a look today or tomorrow. -Val On Tue, Apr 4, 2017 at 7:40 AM, Kozlov Maxim wrote: > Create ticket https://issues.apache.org/jira/browse/IGNITE-4910 < > https://issues.apache.org/jira/browse/IGNITE-4910> and fix PR. > > > 4 апр. 2017 г., в 17:06,

Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)

Create ticket https://issues.apache.org/jira/browse/IGNITE-4910 and fix PR. > 4 апр. 2017 г., в 17:06, Kozlov Maxim написал(а): > > Valentin, of course. I'll let you know how I'll do it. > >> 4 апр. 2017 г., в 16:38,

Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)

Valentin, of course. I'll let you know how I'll do it. > 4 апр. 2017 г., в 16:38, Valentin Kulichenko > написал(а): > > Maxim, > > It looks like you added copyOnRead property on configuration, but I'm > pretty sure that currently it will be ignored. Basically,

Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)

Maxim, It looks like you added copyOnRead property on configuration, but I'm pretty sure that currently it will be ignored. Basically, it's a new feature and I'm OK if we do this as a separate task sometime later (e.g. in 2.1). Can you create a ticket and remove the property for now? -Val On