Re: IGNITE-6005 is ready for review

Thank you. I am sure you now, by anyway: It is important to fail test in code, because all muted tests are actually started in suite each run. And if some test causes timeout it will cause it in both cases: muted and not muted. чт, 22 февр. 2018 г. в 10:17, Nikolay Izhikov

Re: IGNITE-6005 is ready for review

Hello, Dmitry. OK, I'll rerun TC with muted test. В Чт, 22/02/2018 в 07:12 +, Dmitry Pavlov пишет: > Hi Nikolay, > > It seems Data structures test suite is still have timeout. Could you fail > test caused this timeout? >

Re: IGNITE-6005 is ready for review

Hi Nikolay, It seems Data structures test suite is still have timeout. Could you fail test caused this timeout? https://ci.ignite.apache.org/viewLog.html?buildId=1105706=buildResultsDiv=IgniteTests24Java8_IgniteDataStructures Data structures is most relevant suite so I suggest to re-run it after

Re: IGNITE-6005 is ready for review

Andrey, I made TC run. Please, see my comment in JIRA. https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502 В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет: > Nikolay, > > it doesn't

Re: IGNITE-6005 is ready for review

Nikolay, it doesn't matter. I just want to be sure that there are no new failures in tests. On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov wrote: > Hi, I didn't find any runs in our new TC suite group (project) for 2.4+: >

Re: IGNITE-6005 is ready for review

Hi, I didn't find any runs in our new TC suite group (project) for 2.4+: https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead So, Nikolay, I suggest to start RunAll in this suite group. I can check results later

Re: IGNITE-6005 is ready for review

Hello, Andrey. Do you run TC by yourself, or I as patch contributor should do it? В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет: > I'll merge it if there are no any objections. But, the first, I'll run TC > once again. > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" >

Re: IGNITE-6005 is ready for review

I'll merge it if there are no any objections. But, the first, I'll run TC once again. 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" < dpavlov@gmail.com> написал: > Hi Igniters, > > It seems this issue review process hang up. > > Andrey Gura had concerns about this implementation. In

Re: IGNITE-6005 is ready for review

Hi Igniters, It seems this issue review process hang up. Andrey Gura had concerns about this implementation. In the same time Ilya L checked this implementation and approves it. I didn't find points to improve and concerns are not clear for me. I didn't managed to get more info in issue

Re: IGNITE-6005 is ready for review

Hi Nikolay, Thanks for contribution! I will try to review your pull request by tomorrow. On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov wrote: > Hello, Igniters. > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR [2] > The fix in

IGNITE-6005 is ready for review

Hello, Igniters. I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR [2] The fix in DataStructuresProcessor.java As far as I can see from git log Ilya Lantukh maintains this piece of code. Ilya, can you please take a look at the fix? [1]