Re: Looks like a bug in ServerImpl.joinTopology()

2018-05-04 Thread Anton Vinogradov
Alex, I checked reproducer you presented, please fix it according to the following rules 1) Never use System.out.println() as a part of reproducer, use assetrions if necessary. 2) Reproducer should be small. As small as possible. 3) Try to make reproducer clear. As crear as possible. In case foll

Re: Looks like a bug in ServerImpl.joinTopology()

2018-04-28 Thread Александр Меньшиков
+ Anton Vinogradov 2018-04-27 17:40 GMT+03:00 Александр Меньшиков : > Yakov, thank you for the advice. > > The thread.sleep is not enough, but some latch + future give me a way to > the > reproducer. > > I have created PR [1] into my master, for showing a test and modification > of > ServerImpl w

Re: Looks like a bug in ServerImpl.joinTopology()

2018-04-27 Thread Александр Меньшиков
Yakov, thank you for the advice. The thread.sleep is not enough, but some latch + future give me a way to the reproducer. I have created PR [1] into my master, for showing a test and modification of ServerImpl which help me to slow down execution inside a danger section. A code of test a bit lon

Re: Looks like a bug in ServerImpl.joinTopology()

2018-02-13 Thread Yakov Zhdanov
Alex, you can alter ServerImpl and insert a latch or thread.sleep(xxx) anywhere you like to show the incorrect behavior you describe. --Yakov

Looks like a bug in ServerImpl.joinTopology()

2018-02-13 Thread Александр Меньшиков
Hello. I saw such code in `ServerImpl.joinTopology()` locNode.order(1); locNode.internalOrder(1); spi.gridStartTime = U.currentTimeMillis(); locNode.visible(true); ring.clear(); ring.topologyVersion(1); And it looks like a bug because the `locNode` is contained inside the `ring` (`TcpDis