Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Dmitry, Nikolay, thanks for your help! Since the changes are merged we are able to implement this feature in Compatibility Testing Framework. It provides us to work flexibly with multi-version cluster and implement new testing scenarios (I know that Ignite doesn't have such feature yet). Does

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Hi Nickolay, it seems we have lazy consesus here. Failures: tests 11 suites 1, all these tests are failed in master. Could you merge? Sincerely, Dmitriy Pavlov пт, 16 мар. 2018 г. в 18:29, Nikolay Izhikov : > Hello, Guys. > > I'm reviewed changes and it looks good to

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Hello, Guys. I'm reviewed changes and it looks good to me. There is a simple reproducer for a bug in test framework, see below. It fails in master and works in branch. I'm planning to merge the fix [1] if Run All will be OK. Please, write to me if you have any objections. [1]

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

I see now. Thank you. Nikolay, could you please merge this change? чт, 15 мар. 2018 г. в 18:48, Vyacheslav Daradur : > In brief: > Nodes in *separate* JVMs are shutting down by the computing task > *StopGridTask* which has sent from *local* JVM *synchronously* that > means

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

In brief: Nodes in *separate* JVMs are shutting down by the computing task *StopGridTask* which has sent from *local* JVM *synchronously* that means *local* node must wait for task's finish. At the same time when a node in *separate* JVM executes the received *StopGridTask* which *synchronously*

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Please address comments in PR. I did not fully understood why sync GridStopMessage message was lost, but async will be successfull. Probably we need discuss it briefly. чт, 1 мар. 2018 г. в 12:11, Vyacheslav Daradur : > Thank you, Dmitry! > > I'll join this review soon. > >

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Thank you, Dmitry! I'll join this review soon. On Thu, Mar 1, 2018 at 12:07 PM, Dmitry Pavlov wrote: > Hi Vyacheslav, > > I will take a look, but first of all I am going to review > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 - it is impact > change in

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Hi Vyacheslav, I will take a look, but first of all I am going to review https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 - it is impact change in testing framework. Hope you also will join to this review . Sincerely, Dmitiry Pavlov чт, 1 мар. 2018 г. в 11:13, Vyacheslav Daradur

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Hi, Dmitry, could you please review it, because you are one of the most experienced people in the testing framework. Please see comment in Jira, because it is in pretty-format there. On Thu, Feb 22, 2018 at 11:56 AM, Vyacheslav Daradur wrote: > Hi Igniters! > > I have

Re: Nodes which started in separate JVM couldn't stop properly (in tests)

Hi Igniters! I have investigated the issue [1] and found that stopping node in separate JVM may stuck thread or leave system process alive after test finished. The main reason is *StopGridTask* that we send from node in local JVM to node in separate JVM via remote computing. We send job

Nodes which started in separate JVM couldn't stop properly (in tests)

Hi Igniters, Working on my task I found a bug at call the method #stopGrid(name), it produced ClassCastException. I created a ticket[1]. After it was fixed[2] I saw that nodes which was started in a separate JVM could stay in process of operation system. It was fixed too, but not sure is it