Re: Proxy serialization issue

2016-02-05 Thread Valentin Kulichenko
Alex, I don't know in advance how many bytes I will write because some classes can be successfully registered, but some not. Therefore I can't extend by more than 5 bytes at this point. Makes sense? -Val On Fri, Feb 5, 2016 at 4:02 AM, Alexey Goncharuk wrote: >

Re: Proxy serialization issue

2016-02-05 Thread Alexey Goncharuk
Val, The code looks good to me. The only place that made me wonder was out.unsafeEnsure(1 + 4) call which extends the stream by 5 bytes, however we can write significantly more bytes. I see that we use the same approach in other places, so I was wondering if this is a required call or a

Proxy serialization issue

2016-02-03 Thread Valentin Kulichenko
Igniters, I fixed java.lang.reflect.Proxy serialization in both optimized and binary marshaller. Can someone familiar with marshalling code review my changes before I merge? Patch is attached to the ticket [1]. [1] https://issues.apache.org/jira/browse/IGNITE-2450 Thanks! -Val

Re: Proxy serialization issue

2016-01-28 Thread Valentin Kulichenko
To my knowledge Alex G. was taking care of this initial issue. > > > > This particular one is reproduced only in multi JVM mode. > > > > -- > > Denis > > > > > > On 1/28/2016 2:59 AM, Dmitriy Setrakyan wrote: > > > >> Who was originally

Re: Proxy serialization issue

2016-01-28 Thread Dmitriy Setrakyan
my knowledge Alex G. was taking care of this initial issue. > > > > > > This particular one is reproduced only in multi JVM mode. > > > > > > -- > > > Denis > > > > > > > > > On 1/28/2016 2:59 AM, Dmitriy Setrakyan wr

Re: Proxy serialization issue

2016-01-28 Thread Alexey Goncharuk
com>: > To my knowledge Alex G. was taking care of this initial issue. > > This particular one is reproduced only in multi JVM mode. > > -- > Denis > > > On 1/28/2016 2:59 AM, Dmitriy Setrakyan wrote: > >> Who was originally responsible for fixing the Proxy

Re: Proxy serialization issue

2016-01-28 Thread Denis Magda
To my knowledge Alex G. was taking care of this initial issue. This particular one is reproduced only in multi JVM mode. -- Denis On 1/28/2016 2:59 AM, Dmitriy Setrakyan wrote: Who was originally responsible for fixing the Proxy serialization issue? On Wed, Jan 27, 2016 at 4:07 AM, Denis

Re: Proxy serialization issue

2016-01-27 Thread Dmitriy Setrakyan
Who was originally responsible for fixing the Proxy serialization issue? On Wed, Jan 27, 2016 at 4:07 AM, Denis Magda <dma...@gridgain.com> wrote: > Igniters, > > A end user reported on the issue related to proxy > serialization/deserialization > https://issues.apache.org/ji

Proxy serialization issue

2016-01-27 Thread Denis Magda
Igniters, A end user reported on the issue related to proxy serialization/deserialization https://issues.apache.org/jira/browse/IGNITE-2450 Could someone experienced in marshalling take a look at this? Seems that the original proxy related issue wasn't fully fixed. -- Denis