Re: [DISCUSSION] Removal of ignitevisorcmd
Thanks. Ticket created - https://issues.apache.org/jira/browse/IGNITE-18327 пт, 2 дек. 2022 г. в 15:25, 18624049226 <18624049...@163.com>: > Visor has a 'cache -clear' function, this function is very useful, > especially in some O scenarios. > > Because Ignite does not support the TRUNCATE command, it is necessary to > provide a high-performance clear table data command. > > 在 2022/12/2 19:13, Nikolay Izhikov 写道: > > THanks, Slava, Stephen. > > > > Ticket to reimplement cache scan created - > > https://issues.apache.org/jira/browse/IGNITE-18320 > > > > пт, 2 дек. 2022 г. в 13:30, Stephen Darlington < > > stephen.darling...@gridgain.com>: > > > >> One option that’s in Visor but not control.sh is the ability to view > cache > >> content (cache -scan). I do hear of people using that. > >> > >>> On 2 Dec 2022, at 09:17, Andrey Mashenkov > >> wrote: > >>> Hi Igniters, > >>> > >>> I agree with Slava, we have to provide alternative ways for users > before > >>> dropping a feature that just worked. > >>> A user may use some feature for a long time without any issues, so, > this > >> is > >>> why there is no mention in chats/mails. > >>> I mean here, the feature is not only the whole visor command, but a > >> command > >>> option that just makes UX better. > >>> > >>> I think we can revise visor features, which are not supported by > >>> control.sh, and create an umbrella ticket for supporting in control.sh. > >>> Set this ticket either as 'required' for a 'dropping visor ticket', or > >> as a > >>> blocker for the next release if visor dropping will come first. > >>> > >>> On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov > >> wrote: > Hello, Slava. > > > However, do we have a list of useful features that do not exist in > our > control utility? > > I don't have the list on hand. > Do you have some feature in mind that must be transferred in > control.sh? > > I don't find any mentions of visorcmd on user list and in user chats > so > >> my > guess is - this utility is not used by the users in any way. > Do you have some other inputs? > > If yes, don't hesitate to create a ticket with the IEP-94 label. > > > чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин < > slava.kopti...@gmail.com > >>> : > > Hi Igniters, > > > > I fully support the idea to stop supporting Visor and removing its > > implementation. > > However, do we have a list of useful features that do not exist in > our > > control utility? > > Perhaps, it makes sense to reimplement such functionality and provide > >> it > > based on control.sh script. > > > > Thanks, > > Slava. > > > > чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov: > > > >> PR is ready for review -https://github.com/apache/ignite/pull/10411 > >> > >> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov: > >> > >>> Hi, > >>> > >>> +1 for remove Visor related code. > >>> Unfortunately we have to migrate `control-utility` to use > IgniteClient > >>> (thin client) before drop GridClient. I guess we will do it in the > >> future. > >>> Also, the old thin JDBC based on the GridClient (classes placed at > the > >>> org.apache.ignite.internal.jdbc.*) must be removed. > >>> > >>> > >>> -- > >>> Best regards, > >>> Andrey V. Mashenkov > >>
Re: [DISCUSSION] Removal of ignitevisorcmd
Visor has a 'cache -clear' function, this function is very useful, especially in some O scenarios. Because Ignite does not support the TRUNCATE command, it is necessary to provide a high-performance clear table data command. 在 2022/12/2 19:13, Nikolay Izhikov 写道: THanks, Slava, Stephen. Ticket to reimplement cache scan created - https://issues.apache.org/jira/browse/IGNITE-18320 пт, 2 дек. 2022 г. в 13:30, Stephen Darlington < stephen.darling...@gridgain.com>: One option that’s in Visor but not control.sh is the ability to view cache content (cache -scan). I do hear of people using that. On 2 Dec 2022, at 09:17, Andrey Mashenkov wrote: Hi Igniters, I agree with Slava, we have to provide alternative ways for users before dropping a feature that just worked. A user may use some feature for a long time without any issues, so, this is why there is no mention in chats/mails. I mean here, the feature is not only the whole visor command, but a command option that just makes UX better. I think we can revise visor features, which are not supported by control.sh, and create an umbrella ticket for supporting in control.sh. Set this ticket either as 'required' for a 'dropping visor ticket', or as a blocker for the next release if visor dropping will come first. On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov wrote: Hello, Slava. However, do we have a list of useful features that do not exist in our control utility? I don't have the list on hand. Do you have some feature in mind that must be transferred in control.sh? I don't find any mentions of visorcmd on user list and in user chats so my guess is - this utility is not used by the users in any way. Do you have some other inputs? If yes, don't hesitate to create a ticket with the IEP-94 label. чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин : Hi Igniters, I fully support the idea to stop supporting Visor and removing its implementation. However, do we have a list of useful features that do not exist in our control utility? Perhaps, it makes sense to reimplement such functionality and provide it based on control.sh script. Thanks, Slava. чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov: PR is ready for review -https://github.com/apache/ignite/pull/10411 чт, 1 дек. 2022 г. в 16:49, Taras Ledkov: Hi, +1 for remove Visor related code. Unfortunately we have to migrate `control-utility` to use IgniteClient (thin client) before drop GridClient. I guess we will do it in the future. Also, the old thin JDBC based on the GridClient (classes placed at the org.apache.ignite.internal.jdbc.*) must be removed. -- Best regards, Andrey V. Mashenkov
Re: [DISCUSSION] Removal of ignitevisorcmd
THanks, Slava, Stephen. Ticket to reimplement cache scan created - https://issues.apache.org/jira/browse/IGNITE-18320 пт, 2 дек. 2022 г. в 13:30, Stephen Darlington < stephen.darling...@gridgain.com>: > One option that’s in Visor but not control.sh is the ability to view cache > content (cache -scan). I do hear of people using that. > > > On 2 Dec 2022, at 09:17, Andrey Mashenkov > wrote: > > > > Hi Igniters, > > > > I agree with Slava, we have to provide alternative ways for users before > > dropping a feature that just worked. > > A user may use some feature for a long time without any issues, so, this > is > > why there is no mention in chats/mails. > > I mean here, the feature is not only the whole visor command, but a > command > > option that just makes UX better. > > > > I think we can revise visor features, which are not supported by > > control.sh, and create an umbrella ticket for supporting in control.sh. > > Set this ticket either as 'required' for a 'dropping visor ticket', or > as a > > blocker for the next release if visor dropping will come first. > > > > On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov > wrote: > > > >> Hello, Slava. > >> > >>> However, do we have a list of useful features that do not exist in our > >> control utility? > >> > >> I don't have the list on hand. > >> Do you have some feature in mind that must be transferred in control.sh? > >> > >> I don't find any mentions of visorcmd on user list and in user chats so > my > >> guess is - this utility is not used by the users in any way. > >> Do you have some other inputs? > >> > >> If yes, don't hesitate to create a ticket with the IEP-94 label. > >> > >> > >> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин >: > >> > >>> Hi Igniters, > >>> > >>> I fully support the idea to stop supporting Visor and removing its > >>> implementation. > >>> However, do we have a list of useful features that do not exist in our > >>> control utility? > >>> Perhaps, it makes sense to reimplement such functionality and provide > it > >>> based on control.sh script. > >>> > >>> Thanks, > >>> Slava. > >>> > >>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : > >>> > PR is ready for review - https://github.com/apache/ignite/pull/10411 > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > > > Hi, > > > > +1 for remove Visor related code. > > Unfortunately we have to migrate `control-utility` to use > >> IgniteClient > > (thin client) before drop GridClient. I guess we will do it in the > future. > > > > Also, the old thin JDBC based on the GridClient (classes placed at > >> the > > org.apache.ignite.internal.jdbc.*) must be removed. > > > > >>> > >> > > > > > > -- > > Best regards, > > Andrey V. Mashenkov > >
Re: [DISCUSSION] Removal of ignitevisorcmd
One option that’s in Visor but not control.sh is the ability to view cache content (cache -scan). I do hear of people using that. > On 2 Dec 2022, at 09:17, Andrey Mashenkov wrote: > > Hi Igniters, > > I agree with Slava, we have to provide alternative ways for users before > dropping a feature that just worked. > A user may use some feature for a long time without any issues, so, this is > why there is no mention in chats/mails. > I mean here, the feature is not only the whole visor command, but a command > option that just makes UX better. > > I think we can revise visor features, which are not supported by > control.sh, and create an umbrella ticket for supporting in control.sh. > Set this ticket either as 'required' for a 'dropping visor ticket', or as a > blocker for the next release if visor dropping will come first. > > On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov wrote: > >> Hello, Slava. >> >>> However, do we have a list of useful features that do not exist in our >> control utility? >> >> I don't have the list on hand. >> Do you have some feature in mind that must be transferred in control.sh? >> >> I don't find any mentions of visorcmd on user list and in user chats so my >> guess is - this utility is not used by the users in any way. >> Do you have some other inputs? >> >> If yes, don't hesitate to create a ticket with the IEP-94 label. >> >> >> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин : >> >>> Hi Igniters, >>> >>> I fully support the idea to stop supporting Visor and removing its >>> implementation. >>> However, do we have a list of useful features that do not exist in our >>> control utility? >>> Perhaps, it makes sense to reimplement such functionality and provide it >>> based on control.sh script. >>> >>> Thanks, >>> Slava. >>> >>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : >>> PR is ready for review - https://github.com/apache/ignite/pull/10411 чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > Hi, > > +1 for remove Visor related code. > Unfortunately we have to migrate `control-utility` to use >> IgniteClient > (thin client) before drop GridClient. I guess we will do it in the future. > > Also, the old thin JDBC based on the GridClient (classes placed at >> the > org.apache.ignite.internal.jdbc.*) must be removed. > >>> >> > > > -- > Best regards, > Andrey V. Mashenkov
Re: [DISCUSSION] Removal of ignitevisorcmd
Hi Igniters, I agree with Slava, we have to provide alternative ways for users before dropping a feature that just worked. A user may use some feature for a long time without any issues, so, this is why there is no mention in chats/mails. I mean here, the feature is not only the whole visor command, but a command option that just makes UX better. I think we can revise visor features, which are not supported by control.sh, and create an umbrella ticket for supporting in control.sh. Set this ticket either as 'required' for a 'dropping visor ticket', or as a blocker for the next release if visor dropping will come first. On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov wrote: > Hello, Slava. > > > However, do we have a list of useful features that do not exist in our > control utility? > > I don't have the list on hand. > Do you have some feature in mind that must be transferred in control.sh? > > I don't find any mentions of visorcmd on user list and in user chats so my > guess is - this utility is not used by the users in any way. > Do you have some other inputs? > > If yes, don't hesitate to create a ticket with the IEP-94 label. > > > чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин : > > > Hi Igniters, > > > > I fully support the idea to stop supporting Visor and removing its > > implementation. > > However, do we have a list of useful features that do not exist in our > > control utility? > > Perhaps, it makes sense to reimplement such functionality and provide it > > based on control.sh script. > > > > Thanks, > > Slava. > > > > чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : > > > > > PR is ready for review - https://github.com/apache/ignite/pull/10411 > > > > > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > > > > > > > Hi, > > > > > > > > +1 for remove Visor related code. > > > > Unfortunately we have to migrate `control-utility` to use > IgniteClient > > > > (thin client) before drop GridClient. I guess we will do it in the > > > future. > > > > > > > > Also, the old thin JDBC based on the GridClient (classes placed at > the > > > > org.apache.ignite.internal.jdbc.*) must be removed. > > > > > > > > > > -- Best regards, Andrey V. Mashenkov
Re: [DISCUSSION] Removal of ignitevisorcmd
Hello, Slava. > However, do we have a list of useful features that do not exist in our control utility? I don't have the list on hand. Do you have some feature in mind that must be transferred in control.sh? I don't find any mentions of visorcmd on user list and in user chats so my guess is - this utility is not used by the users in any way. Do you have some other inputs? If yes, don't hesitate to create a ticket with the IEP-94 label. чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин : > Hi Igniters, > > I fully support the idea to stop supporting Visor and removing its > implementation. > However, do we have a list of useful features that do not exist in our > control utility? > Perhaps, it makes sense to reimplement such functionality and provide it > based on control.sh script. > > Thanks, > Slava. > > чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : > > > PR is ready for review - https://github.com/apache/ignite/pull/10411 > > > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > > > > > Hi, > > > > > > +1 for remove Visor related code. > > > Unfortunately we have to migrate `control-utility` to use IgniteClient > > > (thin client) before drop GridClient. I guess we will do it in the > > future. > > > > > > Also, the old thin JDBC based on the GridClient (classes placed at the > > > org.apache.ignite.internal.jdbc.*) must be removed. > > > > > >
Re: [DISCUSSION] Removal of ignitevisorcmd
Hi Igniters, I fully support the idea to stop supporting Visor and removing its implementation. However, do we have a list of useful features that do not exist in our control utility? Perhaps, it makes sense to reimplement such functionality and provide it based on control.sh script. Thanks, Slava. чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : > PR is ready for review - https://github.com/apache/ignite/pull/10411 > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > > > Hi, > > > > +1 for remove Visor related code. > > Unfortunately we have to migrate `control-utility` to use IgniteClient > > (thin client) before drop GridClient. I guess we will do it in the > future. > > > > Also, the old thin JDBC based on the GridClient (classes placed at the > > org.apache.ignite.internal.jdbc.*) must be removed. > > >
Re: [DISCUSSION] Removal of ignitevisorcmd
PR is ready for review - https://github.com/apache/ignite/pull/10411 чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > Hi, > > +1 for remove Visor related code. > Unfortunately we have to migrate `control-utility` to use IgniteClient > (thin client) before drop GridClient. I guess we will do it in the future. > > Also, the old thin JDBC based on the GridClient (classes placed at the > org.apache.ignite.internal.jdbc.*) must be removed. >
Re:[DISCUSSION] Removal of ignitevisorcmd
Hi, +1 for remove Visor related code. Unfortunately we have to migrate `control-utility` to use IgniteClient (thin client) before drop GridClient. I guess we will do it in the future. Also, the old thin JDBC based on the GridClient (classes placed at the org.apache.ignite.internal.jdbc.*) must be removed.
Re: [DISCUSSION] Removal of ignitevisorcmd
+1 This module seems to be completely abandoned чт, 1 дек. 2022 г., 00:46 Ilya Kasnacheev : > Hello! > > Let's go ahead and remove what we don't use. Most of that stuff is deep > legacy, even if it contains some rare gems of functionality that nobody > knows how to use anymore. > > Regards, > -- > Ilya Kasnacheev > > > ср, 30 нояб. 2022 г. в 20:12, Nikolay Izhikov : > > > Hello, Igniters. > > > > There are legacy modules - visor-console, visor-plugins, > visor-console-2.10 > > Looks like that modules are not evolving by community and barely used by > > the Ignite users. > > > > I propose to remove it completely. > > There are IEP [1] for this > > > > It seems that removal of visor modules allow to us to remove another > legacy > > code from Ignite codebase: > > > > * support of daemon nodes. > > * GridClient and related classes. > > > > What do you think? > > > > [1] > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217392419 > > >
Re: [DISCUSSION] Removal of ignitevisorcmd
Hello! Let's go ahead and remove what we don't use. Most of that stuff is deep legacy, even if it contains some rare gems of functionality that nobody knows how to use anymore. Regards, -- Ilya Kasnacheev ср, 30 нояб. 2022 г. в 20:12, Nikolay Izhikov : > Hello, Igniters. > > There are legacy modules - visor-console, visor-plugins, visor-console-2.10 > Looks like that modules are not evolving by community and barely used by > the Ignite users. > > I propose to remove it completely. > There are IEP [1] for this > > It seems that removal of visor modules allow to us to remove another legacy > code from Ignite codebase: > > * support of daemon nodes. > * GridClient and related classes. > > What do you think? > > [1] > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217392419 >
