PRs have been merged. Many thanks for review to Nikita Amelchev and Aleksei
Zinoviev
пт, 25 авг. 2023 г. в 17:05, Nikita Amelchev :
> +1 for moving to extensions
>
> This module is good as an extension:
> - does not depend on the internal Ignite API,
> - the released module will be compatible
+1 for moving to extensions
This module is good as an extension:
- does not depend on the internal Ignite API,
- the released module will be compatible with any required version of
Ignite using the provided dependency scope.
Ivan, I have reviewed your patch, LGTM.
чт, 17 авг. 2023 г. в 17:06,
+1 for Apache Way in decision making (it states there should not be time
pressure for the decision making).
0 for removal
0 for moving to extensions
but since Aleksei is an expert here, it makes sense to me to wait for him.
Sincerely,
Dmitriy Pavlov
On 2023/08/16 17:32:55 Aleksei Zinovev
Hi, I have objection for fast merging, (not for moving) as a module
maintainer.
I never used ignite extension, need a time to be familiar with it and test
the pr.
Please postpone it till 10 september.
I don't understand reasons to do it so fast. I suppose it's ok to wait
15-20 days with PR
ML Extensions suite is ready and it works, all tests from the main module
and parsers, all examples -- everything works and all green [1].
The green visa has been obtained. So I am going to merge it tomorrow, if
there is no objection.
[1] ---
>> https://issues.apache.org/jira/browse/IGNITE-20216
Also, I've updated dependencies and fixed BLAS issue (tested with intel mkl
blas on ubuntu 22.04)
ср, 16 авг. 2023 г. в 12:11, Ivan Daschinsky :
> I've filed a ticket and created 2 PRs. After tuning of TC I'm going to
> merge both of them, if
Hi, as PMC and maintainer of this module
-1 for removal
+1 for moving to an extension, if it is compatible with the Ignite and
could be compiled separately from other extension modules
Some facts:
- nobody updates it for latest 3 years—it's true
- classic ML algorithms are not changed in
I've filed a ticket and created 2 PRs. After tuning of TC I'm going to
merge both of them, if nobody disagrees with it.
https://issues.apache.org/jira/browse/IGNITE-20216
пн, 14 авг. 2023 г. в 22:29, Ivan Daschinsky :
> >> * com.github.fommil.netlib:core:1.1.2 - not developed and archived
>
>> * com.github.fommil.netlib:core:1.1.2 - not developed and archived since
2017. Last version released in 2013 [2]
Moreover, this version is so outdated and JNI extension was so strangely
made (linked to libgfortran3 for example), that native BLAS simply doesn't
work.
Always fallback option is
A few cents to let you know how abandoned ML module is.
1. Last valuable commit December 9, 2020 -
https://github.com/apache/ignite/commit/04f6a33851d9f7bd269a09fdc2c74485b1e01a8a
2. Dependencies and current versions of them:
* com.dropbox.core:dropbox-core-sdk:2.1.1 current version is -
As far as I know, the integration was removed from the Tensorflow side.
On Thu, Aug 10, 2023 at 2:04 PM Andrey Mashenkov
wrote:
> Ivan,
>
> > Actually, I haven't found any integration with tensorflow in AI code.
>
> Ok. You are right.
> Tensorflow is mentioned in docs: docs/_docs/setup.adoc.
>
Ivan,
> Actually, I haven't found any integration with tensorflow in AI code.
Ok. You are right.
Tensorflow is mentioned in docs: docs/_docs/setup.adoc.
Adapters may require compilation time dependencies, but these dependencies
shouldn't be part or release package,
regardless whether the ML
Actually, I haven't found any integration with tensorflow in AI code.
Actually, all integrations are some adapters that allow to load pretrained
models (h2o, catboost etc.)
чт, 10 авг. 2023 г. в 13:08, Ivan Daschinsky :
> I am personally for moving to extensions. Alex has already mentioned all
>
I am personally for moving to extensions. Alex has already mentioned all
the reasons why it should be done and all of them are quite important.
The module seems to be quite independent and there is no problem to move it
to ignite-extensions.
So I am +1 for moving to ignite-extensions.
чт, 10
>
> do you know anyone who uses it?
I know some teams, who do. At the last Ignite Summit we had a talk
featuring Ml module (from the Groovy community).
Anyway, We need here the module maintainer opinion
+ Alex
On Wed, Aug 9, 2023 at 3:38 PM Andrey Mashenkov
wrote:
> -1 for removal.
> 0 for
-1 for removal.
0 for relocation
imho, TC resources and module size aren't good arguments for
removal/moving.
ML tests could be run nightly.
ML module contains few integrations (with TensorFlow and other), these
optional integrations are wighty and could be moved to extension,
but core
+1 to relocation
On Wed, Aug 9, 2023 at 3:09 PM Alex Plehanov
wrote:
> Pavel, do you know anyone who uses it?
>
> Looks like it isn't used at all (no questions on mail lists, no
> tickets), but we spend developers time to build module with every
> Ignite rebuild, we spend users traffic to
Pavel, do you know anyone who uses it?
Looks like it isn't used at all (no questions on mail lists, no
tickets), but we spend developers time to build module with every
Ignite rebuild, we spend users traffic to download module (ML with
dependencies takes about 1/4 of our binary release package
Hello, Pavel.
I think the ignite-extension project is right place for ignite-ml.
Useful module that has its own release cycle and don’t contains core Ignite
features has to be inside extensions.
> 9 авг. 2023 г., в 14:18, Pavel Tupitsyn написал(а):
>
> Does it have any outstanding issues? A
Does it have any outstanding issues? A stable and useful module should not
be removed just because it does not evolve.
On Wed, Aug 9, 2023 at 1:46 PM Ivan Daschinsky wrote:
> Igniters, seems that this module is completely abandoned for more than 2
> years. But it is enormous and it seems that
Igniters, seems that this module is completely abandoned for more than 2
years. But it is enormous and it seems that nobody wants to take care of
it. I suggest just removing it or moving it to extensions (as option). WDYT?
21 matches
Mail list logo
